All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ramsay Jones <ramsay@ramsayjones.plus.com>
To: christian.couder@gmail.com
Cc: Junio C Hamano <gitster@pobox.com>,
	GIT Mailing-list <git@vger.kernel.org>,
	Johannes Schindelin <Johannes.Schindelin@gmx.de>
Subject: [PATCH] dir: mark add_untracked_ident() as a file local symbol
Date: Wed, 16 Dec 2015 16:06:52 +0000	[thread overview]
Message-ID: <56718C1C.2040609@ramsayjones.plus.com> (raw)


Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
---

Hi Christian,

If you need to re-roll your 'cc/untracked' branch, could you
please squash the relevant parts of this into your patches.

Thanks!

Also, you may what to consider removing the emulation of uname()
on MinGW, since this is no longer required after your series.

ATB,
Ramsay Jones

 dir.c | 2 +-
 dir.h | 1 -
 2 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/dir.c b/dir.c
index 94fba2a..be27afa 100644
--- a/dir.c
+++ b/dir.c
@@ -1908,7 +1908,7 @@ static int treat_leading_path(struct dir_struct *dir,
  * We used to save the location of the work tree and the kernel version,
  * but it was not a good idea, so we now just save an empty string.
  */
-void add_untracked_ident(struct untracked_cache *uc)
+static void add_untracked_ident(struct untracked_cache *uc)
 {
 	strbuf_addstr(&uc->ident, "");
 	/* this strbuf contains a list of strings, save NUL too */
diff --git a/dir.h b/dir.h
index 1935b76..531c99a 100644
--- a/dir.h
+++ b/dir.h
@@ -307,7 +307,6 @@ void untracked_cache_add_to_index(struct index_state *, const char *);
 void free_untracked_cache(struct untracked_cache *);
 struct untracked_cache *read_untracked_extension(const void *data, unsigned long sz);
 void write_untracked_extension(struct strbuf *out, struct untracked_cache *untracked);
-void add_untracked_ident(struct untracked_cache *);
 void add_untracked_cache(void);
 void remove_untracked_cache(void);
 #endif
-- 
2.6.0

                 reply	other threads:[~2015-12-16 16:07 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56718C1C.2040609@ramsayjones.plus.com \
    --to=ramsay@ramsayjones.plus.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=christian.couder@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.