From: Jamal Hadi Salim <jhs@mojatatu.com>
To: Eric Dumazet <eric.dumazet@gmail.com>,
Stephen Hemminger <stephen@networkplumber.org>
Cc: Lorenzo Colitti <lorenzo@google.com>,
netdev@vger.kernel.org, davem@davemloft.net,
hannes@stressinduktion.org, ek@google.com, tom@herbertland.com,
zenczykowski@gmail.com
Subject: Re: [PATCH v7 0/4] Support administratively closing application sockets
Date: Wed, 16 Dec 2015 14:55:15 -0500 [thread overview]
Message-ID: <5671C1A3.30207@mojatatu.com> (raw)
In-Reply-To: <1450281013.8474.73.camel@edumazet-glaptop2.roam.corp.google.com>
On 15-12-16 10:50 AM, Eric Dumazet wrote:
> On Wed, 2015-12-16 at 07:43 -0800, Stephen Hemminger wrote:
>
>>
>> I see no security checks in the diag infrastructure.
>> Up until now diag has been read-only access and therefore has been
>> allowed for all users.
>
> It is still allowed to all users.
>
> Only the 'destroy' operation is restricted.
The question i had was the opposite when i saw this: why are
regular users allowed to read admin (and any other users) details?;->
On this specific feature: why, as a regular user, I cant close
connections attributed to me (and have to use CAP_NET_ADMIN)?
cheers,
jamal
next prev parent reply other threads:[~2015-12-16 19:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-16 3:30 [PATCH v7 0/4] Support administratively closing application sockets Lorenzo Colitti
2015-12-16 3:30 ` [PATCH v7 1/4] net: diag: split inet_diag_dump_one_icsk into two Lorenzo Colitti
2015-12-16 3:30 ` [PATCH v7 2/4] net: diag: Add the ability to destroy a socket Lorenzo Colitti
2015-12-16 3:30 ` [PATCH v7 3/4] net: diag: Support SOCK_DESTROY for inet sockets Lorenzo Colitti
2015-12-16 3:30 ` [PATCH v7 4/4] net: diag: Support destroying TCP sockets Lorenzo Colitti
2015-12-16 4:27 ` [PATCH v7 0/4] Support administratively closing application sockets David Miller
2015-12-16 15:43 ` Stephen Hemminger
2015-12-16 15:50 ` Eric Dumazet
2015-12-16 19:55 ` Jamal Hadi Salim [this message]
2015-12-16 23:24 ` David Miller
2015-12-16 23:35 ` Eric Dumazet
2015-12-17 0:15 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5671C1A3.30207@mojatatu.com \
--to=jhs@mojatatu.com \
--cc=davem@davemloft.net \
--cc=ek@google.com \
--cc=eric.dumazet@gmail.com \
--cc=hannes@stressinduktion.org \
--cc=lorenzo@google.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
--cc=tom@herbertland.com \
--cc=zenczykowski@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.