From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [119.145.14.65]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 297491A0327 for ; Thu, 17 Dec 2015 12:31:10 +1100 (AEDT) Message-ID: <56720FFB.5060407@huawei.com> Date: Thu, 17 Dec 2015 09:29:31 +0800 From: "Wangnan (F)" MIME-Version: 1.0 To: Arnaldo Carvalho de Melo , "Naveen N. Rao" CC: , , , Subject: Re: [PATCH v4] perf: bpf: Fix build breakage due to libbpf References: <1450150557-127942-4-git-send-email-wangnan0@huawei.com> <1450169473-137129-1-git-send-email-wangnan0@huawei.com> <20151215114046.GG23726@naverao1-tp.in.ibm.com> <20151216194234.GA19926@kernel.org> In-Reply-To: <20151216194234.GA19926@kernel.org> Content-Type: text/plain; charset="utf-8"; format=flowed List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 2015/12/17 3:42, Arnaldo Carvalho de Melo wrote: > Em Tue, Dec 15, 2015 at 05:10:46PM +0530, Naveen N. Rao escreveu: >> On 2015/12/15 08:51AM, Wang Nan wrote: >>> From: "Naveen N. Rao" >>> >>> perf build is currently (v4.4-rc5) broken on powerpc: >>> >>> bpf.c:28:4: error: #error __NR_bpf not defined. libbpf does not support >>> your arch. >>> # error __NR_bpf not defined. libbpf does not support your arch. >>> ^ >>> >>> Fix this by including tools/scripts/Makefile.arch for the proper >>> $ARCH macro. While at it, remove redundant LP64 macro definition. >>> >>> Also, since libbpf require $(srctree) now, detect the path of >>> srctree like perf. >>> >>> Signed-off-by: Naveen N. Rao >>> Signed-off-by: Wang Nan >>> Acked-by: Jiri Olsa >>> Cc: Arnaldo Carvalho de Melo >>> Cc: Sukadev Bhattiprolu >>> --- >>> >>> v3 -> v4: Add srctree detector code so directly run 'make' in libbpf >>> directory would not cause error. >> Good catch! >> >> Tested-by: Naveen N. Rao > Trying to apply the patchkit: > > [acme@zoo linux]$ make -C tools clean > /dev/null 2>&1 > [acme@zoo linux]$ make -C tools/perf build-test > make: Entering directory '/home/git/linux/tools/perf' > Testing Makefile > tests/make:15: /scripts/Makefile.arch: No such file or directory > make[2]: *** No rule to make target '/scripts/Makefile.arch'. Stop. > tests/make:5: recipe for target 'all' failed > make[1]: *** [all] Error 2 > Makefile:81: recipe for target 'build-test' failed > make: *** [build-test] Error 2 > make: Leaving directory '/home/git/linux/tools/perf' > [acme@zoo linux]$ > > What am I doing wrong? You need all 3 patches. This v4 patch is a fix for previous v3 3/3 and I send this patch by replying that one. I thought your email client is sorted by thread so you can easily find it but it seems I was wrong... The whole thread is: [PATCH v3 0/3] perf build: PowerPC: Fix build breakage due to libbpf: http://lkml.kernel.org/g/1450150557-127942-1-git-send-email-wangnan0@huawei.com [PATCH v3 1/3] perf tools: Fix PowerPC native building http://lkml.kernel.org/g/1450150557-127942-2-git-send-email-wangnan0@huawei.com [PATCH v3 2/3] tools: Move Makefile.arch from perf/config to tools/scripts http://lkml.kernel.org/g/1450150557-127942-3-git-send-email-wangnan0@huawei.com [PATCH v3 3/3] perf: bpf: Fix build breakage due to libbpf http://lkml.kernel.org/g/1450150557-127942-4-git-send-email-wangnan0@huawei.com and [PATCH v3 3/3] breaks local building because the usage of "srctree", and I fix it in this one. Thanks.