From: "Michel Dänzer" <michel@daenzer.net>
To: "Thierry Reding" <thierry.reding@gmail.com>,
"Alex Deucher" <alexander.deucher@amd.com>,
"Christian König" <christian.koenig@amd.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/radeon: Update radeon_get_vblank_counter_kms()
Date: Thu, 17 Dec 2015 15:35:50 +0900 [thread overview]
Message-ID: <567257C6.908@daenzer.net> (raw)
In-Reply-To: <1450276307-13032-1-git-send-email-thierry.reding@gmail.com>
On 16.12.2015 23:31, Thierry Reding wrote:
>
> - if (crtc < 0 || crtc >= rdev->num_crtc) {
> - DRM_ERROR("Invalid crtc %d\n", crtc);
> + if (pipe < 0 || pipe >= rdev->num_crtc) {
> + DRM_ERROR("Invalid crtc %u\n", pipe);
Does it still make sense to test for < 0? Doesn't that generate a
compiler warning?
Also, I don't really get the point of the crtc => pipe rename here...
--
Earthling Michel Dänzer | http://www.amd.com
Libre software enthusiast | Mesa and X developer
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2015-12-17 6:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-16 14:31 [PATCH] drm/radeon: Update radeon_get_vblank_counter_kms() Thierry Reding
2015-12-16 14:36 ` Christian König
2015-12-17 6:35 ` Michel Dänzer [this message]
2016-01-04 11:28 ` Thierry Reding
-- strict thread matches above, loose matches on Subject: below --
2016-01-04 15:44 Thierry Reding
2016-01-04 16:45 ` Alex Deucher
2016-01-04 17:19 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=567257C6.908@daenzer.net \
--to=michel@daenzer.net \
--cc=alexander.deucher@amd.com \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.