From: Hannes Reinecke <hare@suse.de>
To: James Smart <james.smart@avagotech.com>, linux-scsi@vger.kernel.org
Subject: Re: [PATCH 07/17] lpfc: Modularize and cleanup FDMI code in driver
Date: Thu, 17 Dec 2015 09:24:12 +0100 [thread overview]
Message-ID: <5672712C.6060206@suse.de> (raw)
In-Reply-To: <5671efbe.5Ald5TmUcgApALK6%james.smart@avagotech.com>
On 12/17/2015 12:11 AM, James Smart wrote:
>
> Modularize, cleanup, add comments - for FDMI code in driver
>
> Note: I don't like the comments with leading # - but as we have a lot if
> present, I'm deferring to handle it in one big fix later.
>
> Signed-off-by: Dick Kennedy <dick.kennedy@avagotech.com>
> Signed-off-by: James Smart <james.smart@avagotech.com>
> ---
> drivers/scsi/lpfc/lpfc.h | 16 +-
> drivers/scsi/lpfc/lpfc_attr.c | 46 +-
> drivers/scsi/lpfc/lpfc_crtn.h | 5 +-
> drivers/scsi/lpfc/lpfc_ct.c | 1794 ++++++++++++++++++++++++--------------
> drivers/scsi/lpfc/lpfc_els.c | 99 ++-
> drivers/scsi/lpfc/lpfc_hbadisc.c | 16 +-
> drivers/scsi/lpfc/lpfc_hw.h | 184 +++-
> drivers/scsi/lpfc/lpfc_init.c | 27 +-
> drivers/scsi/lpfc/lpfc_vport.c | 8 +
> 9 files changed, 1450 insertions(+), 745 deletions(-)
>
I would have loved to have all the attribute functions abstracted
away by using a generic one, but still a good improvement over the
existing code.
Reviewed-by: Hannes Reinecke <hare@suse.com>
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2015-12-17 8:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-16 23:11 [PATCH 07/17] lpfc: Modularize and cleanup FDMI code in driver James Smart
2015-12-17 8:24 ` Hannes Reinecke [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5672712C.6060206@suse.de \
--to=hare@suse.de \
--cc=james.smart@avagotech.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.