All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hannes Reinecke <hare@suse.de>
To: James Smart <james.smart@avagotech.com>, linux-scsi@vger.kernel.org
Subject: Re: [PATCH 08/17] lpfc: Fix RDP Speed reporting.
Date: Thu, 17 Dec 2015 09:25:15 +0100	[thread overview]
Message-ID: <5672716B.70203@suse.de> (raw)
In-Reply-To: <5671efbf.h8YAdmlPeIEJ3AcO%james.smart@avagotech.com>

On 12/17/2015 12:11 AM, James Smart wrote:
>
> Fix RDP Speed reporting.
>
> Signed-off-by: Dick Kennedy <dick.kennedy@avagotech.com>
> Signed-off-by: James Smart <james.smart@avagotech.com>
> ---
>   drivers/scsi/lpfc/lpfc_els.c | 17 +++++++----------
>   1 file changed, 7 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/scsi/lpfc/lpfc_els.c b/drivers/scsi/lpfc/lpfc_els.c
> index 3394648..f7a2967 100644
> --- a/drivers/scsi/lpfc/lpfc_els.c
> +++ b/drivers/scsi/lpfc/lpfc_els.c
> @@ -4730,28 +4730,25 @@ lpfc_rdp_res_speed(struct fc_rdp_port_speed_desc *desc, struct lpfc_hba *phba)
>
>   	desc->tag = cpu_to_be32(RDP_PORT_SPEED_DESC_TAG);
>
> -	switch (phba->sli4_hba.link_state.speed) {
> -	case LPFC_FC_LA_SPEED_1G:
> +	switch (phba->fc_linkspeed) {
> +	case LPFC_LINK_SPEED_1GHZ:
>   		rdp_speed = RDP_PS_1GB;
>   		break;
> -	case LPFC_FC_LA_SPEED_2G:
> +	case LPFC_LINK_SPEED_2GHZ:
>   		rdp_speed = RDP_PS_2GB;
>   		break;
> -	case LPFC_FC_LA_SPEED_4G:
> +	case LPFC_LINK_SPEED_4GHZ:
>   		rdp_speed = RDP_PS_4GB;
>   		break;
> -	case LPFC_FC_LA_SPEED_8G:
> +	case LPFC_LINK_SPEED_8GHZ:
>   		rdp_speed = RDP_PS_8GB;
>   		break;
> -	case LPFC_FC_LA_SPEED_10G:
> +	case LPFC_LINK_SPEED_10GHZ:
>   		rdp_speed = RDP_PS_10GB;
>   		break;
> -	case LPFC_FC_LA_SPEED_16G:
> +	case LPFC_LINK_SPEED_16GHZ:
>   		rdp_speed = RDP_PS_16GB;
>   		break;
> -	case LPFC_FC_LA_SPEED_32G:
> -		rdp_speed = RDP_PS_32GB;
> -		break;
>   	default:
>   		rdp_speed = RDP_PS_UNKNOWN;
>   		break;
>
What happened to 32G? Has development ceased on that?

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		               zSeries & Storage
hare@suse.de			               +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2015-12-17  8:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-16 23:11 [PATCH 08/17] lpfc: Fix RDP Speed reporting James Smart
2015-12-17  8:25 ` Hannes Reinecke [this message]
2015-12-17 15:47   ` James Smart
2015-12-17 16:04     ` Hannes Reinecke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5672716B.70203@suse.de \
    --to=hare@suse.de \
    --cc=james.smart@avagotech.com \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.