All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jacek Anaszewski <j.anaszewski@samsung.com>
To: "Álvaro Fernández Rojas" <noltari@gmail.com>
Cc: linux-leds@vger.kernel.org, jogo@openwrt.org,
	f.fainelli@gmail.com, simon@fire.lp0.eu, cernekee@gmail.com
Subject: Re: [PATCH 2/2] leds: bcm6358: remove unneeded busy status check
Date: Thu, 17 Dec 2015 09:42:41 +0100	[thread overview]
Message-ID: <56727581.1060907@samsung.com> (raw)
In-Reply-To: <1450296829-31817-2-git-send-email-noltari@gmail.com>

Hi Alvaro,

Thanks for the patch. Applied.

On 12/16/2015 09:13 PM, Álvaro Fernández Rojas wrote:
> The busy status checking isn't needed while reading initial LED status.
>
> Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
> ---
>   drivers/leds/leds-bcm6358.c | 3 ---
>   1 file changed, 3 deletions(-)
>
> diff --git a/drivers/leds/leds-bcm6358.c b/drivers/leds/leds-bcm6358.c
> index 7413e3e..b2cc066 100644
> --- a/drivers/leds/leds-bcm6358.c
> +++ b/drivers/leds/leds-bcm6358.c
> @@ -123,9 +123,6 @@ static int bcm6358_led(struct device *dev, struct device_node *nc, u32 reg,
>   			led->cdev.brightness = LED_FULL;
>   		} else if (!strcmp(state, "keep")) {
>   			unsigned long val;
> -
> -			bcm6358_led_busy(led->mem);
> -
>   			val = bcm6358_led_read(led->mem + BCM6358_REG_MODE);
>   			val &= BIT(led->pin);
>   			if ((led->active_low && !val) ||
>


-- 
Best Regards,
Jacek Anaszewski

      reply	other threads:[~2015-12-17  8:42 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-16 20:13 [PATCH 2/2] leds: bcm6358: remove unneeded busy status check Álvaro Fernández Rojas
2015-12-17  8:42 ` Jacek Anaszewski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56727581.1060907@samsung.com \
    --to=j.anaszewski@samsung.com \
    --cc=cernekee@gmail.com \
    --cc=f.fainelli@gmail.com \
    --cc=jogo@openwrt.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=noltari@gmail.com \
    --cc=simon@fire.lp0.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.