From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark yao Subject: Re: [PATCH v3 0/8] drm/rockchip: covert to support atomic API Date: Thu, 17 Dec 2015 18:32:31 +0800 Message-ID: <56728F3F.6060309@rock-chips.com> References: <1450321275-31154-1-git-send-email-mark.yao@rock-chips.com> <4029109.1DucZWNrFm@diego> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <4029109.1DucZWNrFm@diego> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: =?UTF-8?B?SGVpa28gU3TDvGJuZXI=?= Cc: linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org List-Id: linux-rockchip.vger.kernel.org T24gMjAxNeW5tDEy5pyIMTfml6UgMTg6MDAsIEhlaWtvIFN0w7xibmVyIHdyb3RlOgo+IEhpIE1h cmssCj4KPiBBbSBEb25uZXJzdGFnLCAxNy4gRGV6ZW1iZXIgMjAxNSwgMTE6MDE6MDcgc2Nocmll YiBNYXJrIFlhbzoKPj4gVGhlIHNlcmllcyBvZiBwYXRjaGVzIGNvdmVydGluZyBkcm0gcm9ja2No aXAgdG8gYXRvbWljIEFQSSwgZG8gc29tZQo+PiBjbGVhbnVwIGFuZCBzb21lIGZpeGVzIG9uIGF0 b21pYyBzaWRlLgo+Pgo+PiBUT0RPOiBmZW5jZSBpcyBub3Qgc3VwcG9ydCBvbiBjdXJyZW50IHZl cnNpb24uCj4+Cj4+IFRlc3RlZCBvbiByazMyODggcG9wbWV0YWwgYm9hcmQuCj4gSW4gZ2VuZXJh bCB0aGlzIHdvcmtzIG5pY2VseSBhbmQgaGRtaSBpcyBzdGlsbCB3b3JraW5nIG9uIG15IGZpcmVm bHksIHNvCj4KPiBUZXN0ZWQtYnk6IEhlaWtvIFN0dWVibmVyIDxoZWlrb0BzbnRlY2guZGU+CgpU aGFua3MuCgo+Cj4gSSBnZXQgb25lIHdhcm5pbmcgdGhvdWdoLCB3aGljaCBzZWVtcyB0byBiZSBy ZWxhdGVkIHRvIGZiY29uIGdyYWJiaW5nCj4gdGhlIGZyYW1lYnVmZmVyIGl0IHNlZW1zLgo+Cj4K PiBIRE1JIHBsdWdnZWQgaW4gb24gYm9vdDoKPgo+IFsgICAgNC4zNDUzMjldIC0tLS0tLS0tLS0t LVsgY3V0IGhlcmUgXS0tLS0tLS0tLS0tLQo+IFsgICAgNC4zNDUzNjBdIFdBUk5JTkc6IENQVTog MSBQSUQ6IDY2IGF0IGRyaXZlcnMvZ3B1L2RybS9kcm1fYXRvbWljX2hlbHBlci5jOjY4MiBkcm1f YXRvbWljX2hlbHBlcl91cGRhdGVfbGVnYWN5X21vZGVzZXRfc3RhdGUrMHg2Yy8weDIwMCgpCj4g WyAgICA0LjM0NTM3M10gTW9kdWxlcyBsaW5rZWQgaW46Cj4gWyAgICA0LjM0NTM4Nl0gQ1BVOiAx IFBJRDogNjYgQ29tbToga3dvcmtlci91ODoxIE5vdCB0YWludGVkIDQuNC4wLXJjNSsgIzI3ODcK PiBbICAgIDQuMzQ1MzkyXSBIYXJkd2FyZSBuYW1lOiBSb2NrY2hpcCAoRGV2aWNlIFRyZWUpCj4g WyAgICA0LjM0NTQxMV0gV29ya3F1ZXVlOiBkZWZlcndxIGRlZmVycmVkX3Byb2JlX3dvcmtfZnVu Ywo+IFsgICAgNC4zNDU0MzhdIFs8YzAwMTk5MTQ+XSAodW53aW5kX2JhY2t0cmFjZSkgZnJvbSBb PGMwMDE0YmNjPl0gKHNob3dfc3RhY2srMHgyMC8weDI0KQo+IFsgICAgNC4zNDU0NThdIFs8YzAw MTRiY2M+XSAoc2hvd19zdGFjaykgZnJvbSBbPGMwMmM0MzQ0Pl0gKGR1bXBfc3RhY2srMHg4NC8w eGI4KQo+IFsgICAgNC4zNDU0NzldIFs8YzAyYzQzNDQ+XSAoZHVtcF9zdGFjaykgZnJvbSBbPGMw MDI5YTIwPl0gKHdhcm5fc2xvd3BhdGhfY29tbW9uKzB4OTgvMHhjNCkKPiBbICAgIDQuMzQ1NDk2 XSBbPGMwMDI5YTIwPl0gKHdhcm5fc2xvd3BhdGhfY29tbW9uKSBmcm9tIFs8YzAwMjliMDg+XSAo d2Fybl9zbG93cGF0aF9udWxsKzB4MmMvMHgzNCkKPiBbICAgIDQuMzQ1NTE0XSBbPGMwMDI5YjA4 Pl0gKHdhcm5fc2xvd3BhdGhfbnVsbCkgZnJvbSBbPGMwMzYxMTQ0Pl0gKGRybV9hdG9taWNfaGVs cGVyX3VwZGF0ZV9sZWdhY3lfbW9kZXNldF9zdGF0ZSsweDZjLzB4MjAwKQo+IFsgICAgNC4zNDU1 MzRdIFs8YzAzNjExNDQ+XSAoZHJtX2F0b21pY19oZWxwZXJfdXBkYXRlX2xlZ2FjeV9tb2Rlc2V0 X3N0YXRlKSBmcm9tIFs8YzAzNjE2ODQ+XSAoZHJtX2F0b21pY19oZWxwZXJfY29tbWl0X21vZGVz ZXRfZGlzYWJsZXMrMHgxZTQvMHgzNWMpCj4gWyAgICA0LjM0NTU1N10gWzxjMDM2MTY4ND5dIChk cm1fYXRvbWljX2hlbHBlcl9jb21taXRfbW9kZXNldF9kaXNhYmxlcykgZnJvbSBbPGMwMzg3ODJj Pl0gKHJvY2tjaGlwX2F0b21pY19jb21taXRfY29tcGxldGUrMHgzNC8weDEwOCkKPiBbICAgIDQu MzQ1NTc2XSBbPGMwMzg3ODJjPl0gKHJvY2tjaGlwX2F0b21pY19jb21taXRfY29tcGxldGUpIGZy b20gWzxjMDM4Nzk4ND5dIChyb2NrY2hpcF9kcm1fYXRvbWljX2NvbW1pdCsweDg0LzB4YTApCj4g WyAgICA0LjM0NTU5NF0gWzxjMDM4Nzk4ND5dIChyb2NrY2hpcF9kcm1fYXRvbWljX2NvbW1pdCkg ZnJvbSBbPGMwMzg0YzU4Pl0gKGRybV9hdG9taWNfY29tbWl0KzB4NjAvMHg3MCkKPiBbICAgIDQu MzQ1NjA5XSBbPGMwMzg0YzU4Pl0gKGRybV9hdG9taWNfY29tbWl0KSBmcm9tIFs8YzAzNjNhYjA+ XSAocmVzdG9yZV9mYmRldl9tb2RlKzB4MTI4LzB4MjU4KQo+IFsgICAgNC4zNDU2MjVdIFs8YzAz NjNhYjA+XSAocmVzdG9yZV9mYmRldl9tb2RlKSBmcm9tIFs8YzAzNjUyMDg+XSAoZHJtX2ZiX2hl bHBlcl9yZXN0b3JlX2ZiZGV2X21vZGVfdW5sb2NrZWQrMHgzYy8weDgwKQo+IFsgICAgNC4zNDU2 NDBdIFs8YzAzNjUyMDg+XSAoZHJtX2ZiX2hlbHBlcl9yZXN0b3JlX2ZiZGV2X21vZGVfdW5sb2Nr ZWQpIGZyb20gWzxjMDM2NTI5Yz5dIChkcm1fZmJfaGVscGVyX3NldF9wYXIrMHg1MC8weDYwKQo+ IFsgICAgNC4zNDU2NTldIFs8YzAzNjUyOWM+XSAoZHJtX2ZiX2hlbHBlcl9zZXRfcGFyKSBmcm9t IFs8YzAzMDUyY2M+XSAoZmJjb25faW5pdCsweDMyOC8weDQ1OCkKPiBbICAgIDQuMzQ1Njc2XSBb PGMwMzA1MmNjPl0gKGZiY29uX2luaXQpIGZyb20gWzxjMDMzYTY2Yz5dICh2aXN1YWxfaW5pdCsw eGM0LzB4MTE0KQo+IFsgICAgNC4zNDU2OTJdIFs8YzAzM2E2NmM+XSAodmlzdWFsX2luaXQpIGZy b20gWzxjMDMzYzA5OD5dIChkb19iaW5kX2Nvbl9kcml2ZXIrMHgxZmMvMHgzMzApCj4gWyAgICA0 LjM0NTcwN10gWzxjMDMzYzA5OD5dIChkb19iaW5kX2Nvbl9kcml2ZXIpIGZyb20gWzxjMDMzYzU0 MD5dIChkb190YWtlX292ZXJfY29uc29sZSsweDE3NC8weDFiNCkKPiBbICAgIDQuMzQ1NzIyXSBb PGMwMzNjNTQwPl0gKGRvX3Rha2Vfb3Zlcl9jb25zb2xlKSBmcm9tIFs8YzAzMDU0NjQ+XSAoZG9f ZmJjb25fdGFrZW92ZXIrMHg2OC8weGQwKQo+IFsgICAgNC4zNDU3MzhdIFs8YzAzMDU0NjQ+XSAo ZG9fZmJjb25fdGFrZW92ZXIpIGZyb20gWzxjMDMwNWM2Yz5dIChmYmNvbl9ldmVudF9ub3RpZnkr MHgzZmMvMHg3ZDgpCj4gWyAgICA0LjM0NTc1Nl0gWzxjMDMwNWM2Yz5dIChmYmNvbl9ldmVudF9u b3RpZnkpIGZyb20gWzxjMDA0ZDE0ND5dIChub3RpZmllcl9jYWxsX2NoYWluKzB4NTgvMHg4MCkK PiBbICAgIDQuMzQ1NzcxXSBbPGMwMDRkMTQ0Pl0gKG5vdGlmaWVyX2NhbGxfY2hhaW4pIGZyb20g WzxjMDA0ZDRkND5dIChfX2Jsb2NraW5nX25vdGlmaWVyX2NhbGxfY2hhaW4rMHg1NC8weDZjKQo+ IFsgICAgNC4zNDU3ODVdIFs8YzAwNGQ0ZDQ+XSAoX19ibG9ja2luZ19ub3RpZmllcl9jYWxsX2No YWluKSBmcm9tIFs8YzAwNGQ1MTQ+XSAoYmxvY2tpbmdfbm90aWZpZXJfY2FsbF9jaGFpbisweDI4 LzB4MzApCj4gWyAgICA0LjM0NTgwNF0gWzxjMDA0ZDUxND5dIChibG9ja2luZ19ub3RpZmllcl9j YWxsX2NoYWluKSBmcm9tIFs8YzAzMDhjNjg+XSAoZmJfbm90aWZpZXJfY2FsbF9jaGFpbisweDI0 LzB4MmMpCj4gWyAgICA0LjM0NTgyMl0gWzxjMDMwOGM2OD5dIChmYl9ub3RpZmllcl9jYWxsX2No YWluKSBmcm9tIFs8YzAzMGFhN2M+XSAocmVnaXN0ZXJfZnJhbWVidWZmZXIrMHgyMTQvMHgyNjQp Cj4gWyAgICA0LjM0NTgzOV0gWzxjMDMwYWE3Yz5dIChyZWdpc3Rlcl9mcmFtZWJ1ZmZlcikgZnJv bSBbPGMwMzY1YTAwPl0gKGRybV9mYl9oZWxwZXJfaW5pdGlhbF9jb25maWcrMHgyZGMvMHgzNGMp Cj4gWyAgICA0LjM0NTg1Nl0gWzxjMDM2NWEwMD5dIChkcm1fZmJfaGVscGVyX2luaXRpYWxfY29u ZmlnKSBmcm9tIFs8YzAzODgyM2M+XSAocm9ja2NoaXBfZHJtX2ZiZGV2X2luaXQrMHg5Yy8weGU0 KQo+IFsgICAgNC4zNDU4NzNdIFs8YzAzODgyM2M+XSAocm9ja2NoaXBfZHJtX2ZiZGV2X2luaXQp IGZyb20gWzxjMDM4NzZiYz5dIChyb2NrY2hpcF9kcm1fbG9hZCsweDI1Yy8weDJiMCkKPiBbICAg IDQuMzQ1ODkyXSBbPGMwMzg3NmJjPl0gKHJvY2tjaGlwX2RybV9sb2FkKSBmcm9tIFs8YzAzNmVh ZTQ+XSAoZHJtX2Rldl9yZWdpc3RlcisweDgwLzB4YzQpCj4gWyAgICA0LjM0NTkxMF0gWzxjMDM2 ZWFlND5dIChkcm1fZGV2X3JlZ2lzdGVyKSBmcm9tIFs8YzAzODczZDQ+XSAocm9ja2NoaXBfZHJt X2JpbmQrMHg1OC8weDg0KQo+IFsgICAgNC4zNDU5MzJdIFs8YzAzODczZDQ+XSAocm9ja2NoaXBf ZHJtX2JpbmQpIGZyb20gWzxjMDNiNGI1ND5dICh0cnlfdG9fYnJpbmdfdXBfbWFzdGVyLnBhcnQu MCsweGJjLzB4MTE0KQo+IFsgICAgNC4zNDU5NTBdIFs8YzAzYjRiNTQ+XSAodHJ5X3RvX2JyaW5n X3VwX21hc3Rlci5wYXJ0LjApIGZyb20gWzxjMDNiNGRhMD5dIChjb21wb25lbnRfYWRkKzB4YjAv MHgxMTgpCj4gWyAgICA0LjM0NTk2N10gWzxjMDNiNGRhMD5dIChjb21wb25lbnRfYWRkKSBmcm9t IFs8YzAzOGEyZDg+XSAodm9wX3Byb2JlKzB4NDAvMHg0YykKPiBbICAgIDQuMzQ1OTg0XSBbPGMw MzhhMmQ4Pl0gKHZvcF9wcm9iZSkgZnJvbSBbPGMwM2JjMzUwPl0gKHBsYXRmb3JtX2Rydl9wcm9i ZSsweDYwLzB4YjApCj4gWyAgICA0LjM0NTk5OV0gWzxjMDNiYzM1MD5dIChwbGF0Zm9ybV9kcnZf cHJvYmUpIGZyb20gWzxjMDNiOWZmYz5dIChkcml2ZXJfcHJvYmVfZGV2aWNlKzB4MWEwLzB4NDE4 KQo+IFsgICAgNC4zNDYwMTRdIFs8YzAzYjlmZmM+XSAoZHJpdmVyX3Byb2JlX2RldmljZSkgZnJv bSBbPGMwM2JhM2Y4Pl0gKF9fZGV2aWNlX2F0dGFjaF9kcml2ZXIrMHg5NC8weGEwKQo+IFsgICAg NC4zNDYwMjhdIFs8YzAzYmEzZjg+XSAoX19kZXZpY2VfYXR0YWNoX2RyaXZlcikgZnJvbSBbPGMw M2I4MmEwPl0gKGJ1c19mb3JfZWFjaF9kcnYrMHg5NC8weGE0KQo+IFsgICAgNC4zNDYwNDJdIFs8 YzAzYjgyYTA+XSAoYnVzX2Zvcl9lYWNoX2RydikgZnJvbSBbPGMwM2I5ZDNjPl0gKF9fZGV2aWNl X2F0dGFjaCsweGE0LzB4MTQ0KQo+IFsgICAgNC4zNDYwNTVdIFs8YzAzYjlkM2M+XSAoX19kZXZp Y2VfYXR0YWNoKSBmcm9tIFs8YzAzYmE1NjQ+XSAoZGV2aWNlX2luaXRpYWxfcHJvYmUrMHgxYy8w eDIwKQo+IFsgICAgNC4zNDYwNjhdIFs8YzAzYmE1NjQ+XSAoZGV2aWNlX2luaXRpYWxfcHJvYmUp IGZyb20gWzxjMDNiOTFkND5dIChidXNfcHJvYmVfZGV2aWNlKzB4MzgvMHg5NCkKPiBbICAgIDQu MzQ2MDgyXSBbPGMwM2I5MWQ0Pl0gKGJ1c19wcm9iZV9kZXZpY2UpIGZyb20gWzxjMDNiOTcxND5d IChkZWZlcnJlZF9wcm9iZV93b3JrX2Z1bmMrMHg4Yy8weGJjKQo+IFsgICAgNC4zNDYwOThdIFs8 YzAzYjk3MTQ+XSAoZGVmZXJyZWRfcHJvYmVfd29ya19mdW5jKSBmcm9tIFs8YzAwNDUwOTQ+XSAo cHJvY2Vzc19vbmVfd29yaysweDMyOC8weDY2OCkKPiBbICAgIDQuMzQ2MTEyXSBbPGMwMDQ1MDk0 Pl0gKHByb2Nlc3Nfb25lX3dvcmspIGZyb20gWzxjMDA0NjMwND5dICh3b3JrZXJfdGhyZWFkKzB4 MmNjLzB4NDFjKQo+IFsgICAgNC4zNDYxMjhdIFs8YzAwNDYzMDQ+XSAod29ya2VyX3RocmVhZCkg ZnJvbSBbPGMwMDRiYmI4Pl0gKGt0aHJlYWQrMHhmNC8weDEwYykKPiBbICAgIDQuMzQ2MTQ2XSBb PGMwMDRiYmI4Pl0gKGt0aHJlYWQpIGZyb20gWzxjMDAxMDAxMD5dIChyZXRfZnJvbV9mb3JrKzB4 MTQvMHgyNCkKPiBbICAgIDQuMzQ2MTU1XSAtLS1bIGVuZCB0cmFjZSA4Y2Q3OGE5ZjZlZTBhNTdl IF0tLS0KPgo+Cj4gUGx1Z2dpbmcgaW4gSERNSSBhZnRlciBib290Ogo+Cj4gWyAgIDIwLjU1OTUz NF0gLS0tLS0tLS0tLS0tWyBjdXQgaGVyZSBdLS0tLS0tLS0tLS0tCj4gWyAgIDIwLjU2NDQxMl0g V0FSTklORzogQ1BVOiAzIFBJRDogNzQgYXQgZHJpdmVycy9ncHUvZHJtL2RybV9hdG9taWNfaGVs cGVyLmM6NjgyIGRybV9hdG9taWNfaGVscGVyX3VwZGF0ZV9sZWdhY3lfbW9kZXNldF9zdGF0ZSsw eDZjLzB4MjAwKCkKPiBbICAgMjAuNTc2OTkxXSBNb2R1bGVzIGxpbmtlZCBpbjoKPiBbICAgMjAu NTgwMTc1XSBDUFU6IDMgUElEOiA3NCBDb21tOiBpcnEvNTEtZmY5ODAwMDAgTm90IHRhaW50ZWQg NC40LjAtcmM1KyAjMjc4Nwo+IFsgICAyMC41ODc1MDJdIEhhcmR3YXJlIG5hbWU6IFJvY2tjaGlw IChEZXZpY2UgVHJlZSkKPiBbICAgMjAuNTkyMzQ3XSBbPGMwMDE5OTE0Pl0gKHVud2luZF9iYWNr dHJhY2UpIGZyb20gWzxjMDAxNGJjYz5dIChzaG93X3N0YWNrKzB4MjAvMHgyNCkKPiBbICAgMjAu NjAwMzE5XSBbPGMwMDE0YmNjPl0gKHNob3dfc3RhY2spIGZyb20gWzxjMDJjNDM0ND5dIChkdW1w X3N0YWNrKzB4ODQvMHhiOCkKPiBbICAgMjAuNjA3Nzc2XSBbPGMwMmM0MzQ0Pl0gKGR1bXBfc3Rh Y2spIGZyb20gWzxjMDAyOWEyMD5dICh3YXJuX3Nsb3dwYXRoX2NvbW1vbisweDk4LzB4YzQpCj4g WyAgIDIwLjYxNjA4N10gWzxjMDAyOWEyMD5dICh3YXJuX3Nsb3dwYXRoX2NvbW1vbikgZnJvbSBb PGMwMDI5YjA4Pl0gKHdhcm5fc2xvd3BhdGhfbnVsbCsweDJjLzB4MzQpCj4gWyAgIDIwLjYyNTEw Nl0gWzxjMDAyOWIwOD5dICh3YXJuX3Nsb3dwYXRoX251bGwpIGZyb20gWzxjMDM2MTE0ND5dIChk cm1fYXRvbWljX2hlbHBlcl91cGRhdGVfbGVnYWN5X21vZGVzZXRfc3RhdGUrMHg2Yy8weDIwMCkK PiBbICAgMjAuNjM2MzgyXSBbPGMwMzYxMTQ0Pl0gKGRybV9hdG9taWNfaGVscGVyX3VwZGF0ZV9s ZWdhY3lfbW9kZXNldF9zdGF0ZSkgZnJvbSBbPGMwMzYxNjg0Pl0gKGRybV9hdG9taWNfaGVscGVy X2NvbW1pdF9tb2Rlc2V0X2Rpc2FibGVzKzB4MWU0LzB4MzVjKQo+IFsgICAyMC42NDk3MzJdIFs8 YzAzNjE2ODQ+XSAoZHJtX2F0b21pY19oZWxwZXJfY29tbWl0X21vZGVzZXRfZGlzYWJsZXMpIGZy b20gWzxjMDM4NzgyYz5dIChyb2NrY2hpcF9hdG9taWNfY29tbWl0X2NvbXBsZXRlKzB4MzQvMHgx MDgpCj4gWyAgIDIwLjY2MTc4OV0gWzxjMDM4NzgyYz5dIChyb2NrY2hpcF9hdG9taWNfY29tbWl0 X2NvbXBsZXRlKSBmcm9tIFs8YzAzODc5ODQ+XSAocm9ja2NoaXBfZHJtX2F0b21pY19jb21taXQr MHg4NC8weGEwKQo+IFsgICAyMC42NzI0NDJdIFs8YzAzODc5ODQ+XSAocm9ja2NoaXBfZHJtX2F0 b21pY19jb21taXQpIGZyb20gWzxjMDM4NGM1OD5dIChkcm1fYXRvbWljX2NvbW1pdCsweDYwLzB4 NzApCj4gWyAgIDIwLjY4MTcxMV0gWzxjMDM4NGM1OD5dIChkcm1fYXRvbWljX2NvbW1pdCkgZnJv bSBbPGMwMzYzYWIwPl0gKHJlc3RvcmVfZmJkZXZfbW9kZSsweDEyOC8weDI1OCkKPiBbICAgMjAu NjkwNDE4XSBbPGMwMzYzYWIwPl0gKHJlc3RvcmVfZmJkZXZfbW9kZSkgZnJvbSBbPGMwMzY1MjA4 Pl0gKGRybV9mYl9oZWxwZXJfcmVzdG9yZV9mYmRldl9tb2RlX3VubG9ja2VkKzB4M2MvMHg4MCkK PiBbICAgMjAuNzAxMDMzXSBbPGMwMzY1MjA4Pl0gKGRybV9mYl9oZWxwZXJfcmVzdG9yZV9mYmRl dl9tb2RlX3VubG9ja2VkKSBmcm9tIFs8YzAzNjUyOWM+XSAoZHJtX2ZiX2hlbHBlcl9zZXRfcGFy KzB4NTAvMHg2MCkKPiBbICAgMjAuNzExOTA3XSBbPGMwMzY1MjljPl0gKGRybV9mYl9oZWxwZXJf c2V0X3BhcikgZnJvbSBbPGMwMzY1MWI0Pl0gKGRybV9mYl9oZWxwZXJfaG90cGx1Z19ldmVudCsw eGM4LzB4ZTApCj4gWyAgIDIwLjcyMTU2OV0gWzxjMDM2NTFiND5dIChkcm1fZmJfaGVscGVyX2hv dHBsdWdfZXZlbnQpIGZyb20gWzxjMDM4N2JkMD5dIChyb2NrY2hpcF9kcm1fb3V0cHV0X3BvbGxf Y2hhbmdlZCsweDI0LzB4MjgpCj4gWyAgIDIwLjczMjE4NV0gWzxjMDM4N2JkMD5dIChyb2NrY2hp cF9kcm1fb3V0cHV0X3BvbGxfY2hhbmdlZCkgZnJvbSBbPGMwMzVhYWY4Pl0gKGRybV9rbXNfaGVs cGVyX2hvdHBsdWdfZXZlbnQrMHgzNC8weDM4KQo+IFsgICAyMC43NDI4OTFdIFs8YzAzNWFhZjg+ XSAoZHJtX2ttc19oZWxwZXJfaG90cGx1Z19ldmVudCkgZnJvbSBbPGMwMzViNDM0Pl0gKGRybV9o ZWxwZXJfaHBkX2lycV9ldmVudCsweDEyMC8weDE1MCkKPiBbICAgMjAuNzUzMDc4XSBbPGMwMzVi NDM0Pl0gKGRybV9oZWxwZXJfaHBkX2lycV9ldmVudCkgZnJvbSBbPGMwMzhkZDFjPl0gKGR3X2hk bWlfaXJxKzB4MTRjLzB4MThjKQo+IFsgICAyMC43NjE3NzJdIFs8YzAzOGRkMWM+XSAoZHdfaGRt aV9pcnEpIGZyb20gWzxjMDA4ZDAzMD5dIChpcnFfdGhyZWFkX2ZuKzB4MmMvMHg0NCkKPiBbICAg MjAuNzY5MzUwXSBbPGMwMDhkMDMwPl0gKGlycV90aHJlYWRfZm4pIGZyb20gWzxjMDA4ZDMzYz5d IChpcnFfdGhyZWFkKzB4MTE4LzB4MjFjKQo+IFsgICAyMC43NzcwMTldIFs8YzAwOGQzM2M+XSAo aXJxX3RocmVhZCkgZnJvbSBbPGMwMDRiYmI4Pl0gKGt0aHJlYWQrMHhmNC8weDEwYykKPiBbICAg MjAuNzg0MDgzXSBbPGMwMDRiYmI4Pl0gKGt0aHJlYWQpIGZyb20gWzxjMDAxMDAxMD5dIChyZXRf ZnJvbV9mb3JrKzB4MTQvMHgyNCkKPiBbICAgMjAuNzkxMzAwXSAtLS1bIGVuZCB0cmFjZSAzZGVh YTUxZDI4ODA2N2EwIF0tLS0KPgo+Cj4KPgpIaSBIZWlrbwogICAgIFRoaXMgaXNzdWUgY2FuIGJl IGV4cGxhaW5lZCBmcm9tIGZvbGxvd2luZyB0aHJlYWQ6CiAgICAgICAgaHR0cHM6Ly9sa21sLm9y Zy9sa21sLzIwMTUvMTEvMTYvNDk4CgogICAgIFlvdSBjYW4gZml4IGl0IGJ5IGZvbGxvd2luZyBj aGFuZ2VzOgoKQEAgLTE2NjcsOCArMTY2Nyw2IEBAIHN0YXRpYyBpbnQgZHdfaGRtaV9yZWdpc3Rl cihzdHJ1Y3QgZHJtX2RldmljZSAKKmRybSwgc3RydWN0IGR3X2hkbWkgKmhkbWkpCiAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICZkd19oZG1pX2Nvbm5lY3Rvcl9mdW5jcywKICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgRFJNX01PREVfQ09OTkVDVE9SX0hETUlB KTsKCiAgICAgLSAgICAgICBoZG1pLT5jb25uZWN0b3IuZW5jb2RlciA9IGVuY29kZXI7CgoKVGhh bmtzLgoKLS0gCu+8rWFyayBZYW8KCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVl ZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZv L2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: mark.yao@rock-chips.com (Mark yao) Date: Thu, 17 Dec 2015 18:32:31 +0800 Subject: [PATCH v3 0/8] drm/rockchip: covert to support atomic API In-Reply-To: <4029109.1DucZWNrFm@diego> References: <1450321275-31154-1-git-send-email-mark.yao@rock-chips.com> <4029109.1DucZWNrFm@diego> Message-ID: <56728F3F.6060309@rock-chips.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 2015?12?17? 18:00, Heiko St?bner wrote: > Hi Mark, > > Am Donnerstag, 17. Dezember 2015, 11:01:07 schrieb Mark Yao: >> The series of patches coverting drm rockchip to atomic API, do some >> cleanup and some fixes on atomic side. >> >> TODO: fence is not support on current version. >> >> Tested on rk3288 popmetal board. > In general this works nicely and hdmi is still working on my firefly, so > > Tested-by: Heiko Stuebner Thanks. > > I get one warning though, which seems to be related to fbcon grabbing > the framebuffer it seems. > > > HDMI plugged in on boot: > > [ 4.345329] ------------[ cut here ]------------ > [ 4.345360] WARNING: CPU: 1 PID: 66 at drivers/gpu/drm/drm_atomic_helper.c:682 drm_atomic_helper_update_legacy_modeset_state+0x6c/0x200() > [ 4.345373] Modules linked in: > [ 4.345386] CPU: 1 PID: 66 Comm: kworker/u8:1 Not tainted 4.4.0-rc5+ #2787 > [ 4.345392] Hardware name: Rockchip (Device Tree) > [ 4.345411] Workqueue: deferwq deferred_probe_work_func > [ 4.345438] [] (unwind_backtrace) from [] (show_stack+0x20/0x24) > [ 4.345458] [] (show_stack) from [] (dump_stack+0x84/0xb8) > [ 4.345479] [] (dump_stack) from [] (warn_slowpath_common+0x98/0xc4) > [ 4.345496] [] (warn_slowpath_common) from [] (warn_slowpath_null+0x2c/0x34) > [ 4.345514] [] (warn_slowpath_null) from [] (drm_atomic_helper_update_legacy_modeset_state+0x6c/0x200) > [ 4.345534] [] (drm_atomic_helper_update_legacy_modeset_state) from [] (drm_atomic_helper_commit_modeset_disables+0x1e4/0x35c) > [ 4.345557] [] (drm_atomic_helper_commit_modeset_disables) from [] (rockchip_atomic_commit_complete+0x34/0x108) > [ 4.345576] [] (rockchip_atomic_commit_complete) from [] (rockchip_drm_atomic_commit+0x84/0xa0) > [ 4.345594] [] (rockchip_drm_atomic_commit) from [] (drm_atomic_commit+0x60/0x70) > [ 4.345609] [] (drm_atomic_commit) from [] (restore_fbdev_mode+0x128/0x258) > [ 4.345625] [] (restore_fbdev_mode) from [] (drm_fb_helper_restore_fbdev_mode_unlocked+0x3c/0x80) > [ 4.345640] [] (drm_fb_helper_restore_fbdev_mode_unlocked) from [] (drm_fb_helper_set_par+0x50/0x60) > [ 4.345659] [] (drm_fb_helper_set_par) from [] (fbcon_init+0x328/0x458) > [ 4.345676] [] (fbcon_init) from [] (visual_init+0xc4/0x114) > [ 4.345692] [] (visual_init) from [] (do_bind_con_driver+0x1fc/0x330) > [ 4.345707] [] (do_bind_con_driver) from [] (do_take_over_console+0x174/0x1b4) > [ 4.345722] [] (do_take_over_console) from [] (do_fbcon_takeover+0x68/0xd0) > [ 4.345738] [] (do_fbcon_takeover) from [] (fbcon_event_notify+0x3fc/0x7d8) > [ 4.345756] [] (fbcon_event_notify) from [] (notifier_call_chain+0x58/0x80) > [ 4.345771] [] (notifier_call_chain) from [] (__blocking_notifier_call_chain+0x54/0x6c) > [ 4.345785] [] (__blocking_notifier_call_chain) from [] (blocking_notifier_call_chain+0x28/0x30) > [ 4.345804] [] (blocking_notifier_call_chain) from [] (fb_notifier_call_chain+0x24/0x2c) > [ 4.345822] [] (fb_notifier_call_chain) from [] (register_framebuffer+0x214/0x264) > [ 4.345839] [] (register_framebuffer) from [] (drm_fb_helper_initial_config+0x2dc/0x34c) > [ 4.345856] [] (drm_fb_helper_initial_config) from [] (rockchip_drm_fbdev_init+0x9c/0xe4) > [ 4.345873] [] (rockchip_drm_fbdev_init) from [] (rockchip_drm_load+0x25c/0x2b0) > [ 4.345892] [] (rockchip_drm_load) from [] (drm_dev_register+0x80/0xc4) > [ 4.345910] [] (drm_dev_register) from [] (rockchip_drm_bind+0x58/0x84) > [ 4.345932] [] (rockchip_drm_bind) from [] (try_to_bring_up_master.part.0+0xbc/0x114) > [ 4.345950] [] (try_to_bring_up_master.part.0) from [] (component_add+0xb0/0x118) > [ 4.345967] [] (component_add) from [] (vop_probe+0x40/0x4c) > [ 4.345984] [] (vop_probe) from [] (platform_drv_probe+0x60/0xb0) > [ 4.345999] [] (platform_drv_probe) from [] (driver_probe_device+0x1a0/0x418) > [ 4.346014] [] (driver_probe_device) from [] (__device_attach_driver+0x94/0xa0) > [ 4.346028] [] (__device_attach_driver) from [] (bus_for_each_drv+0x94/0xa4) > [ 4.346042] [] (bus_for_each_drv) from [] (__device_attach+0xa4/0x144) > [ 4.346055] [] (__device_attach) from [] (device_initial_probe+0x1c/0x20) > [ 4.346068] [] (device_initial_probe) from [] (bus_probe_device+0x38/0x94) > [ 4.346082] [] (bus_probe_device) from [] (deferred_probe_work_func+0x8c/0xbc) > [ 4.346098] [] (deferred_probe_work_func) from [] (process_one_work+0x328/0x668) > [ 4.346112] [] (process_one_work) from [] (worker_thread+0x2cc/0x41c) > [ 4.346128] [] (worker_thread) from [] (kthread+0xf4/0x10c) > [ 4.346146] [] (kthread) from [] (ret_from_fork+0x14/0x24) > [ 4.346155] ---[ end trace 8cd78a9f6ee0a57e ]--- > > > Plugging in HDMI after boot: > > [ 20.559534] ------------[ cut here ]------------ > [ 20.564412] WARNING: CPU: 3 PID: 74 at drivers/gpu/drm/drm_atomic_helper.c:682 drm_atomic_helper_update_legacy_modeset_state+0x6c/0x200() > [ 20.576991] Modules linked in: > [ 20.580175] CPU: 3 PID: 74 Comm: irq/51-ff980000 Not tainted 4.4.0-rc5+ #2787 > [ 20.587502] Hardware name: Rockchip (Device Tree) > [ 20.592347] [] (unwind_backtrace) from [] (show_stack+0x20/0x24) > [ 20.600319] [] (show_stack) from [] (dump_stack+0x84/0xb8) > [ 20.607776] [] (dump_stack) from [] (warn_slowpath_common+0x98/0xc4) > [ 20.616087] [] (warn_slowpath_common) from [] (warn_slowpath_null+0x2c/0x34) > [ 20.625106] [] (warn_slowpath_null) from [] (drm_atomic_helper_update_legacy_modeset_state+0x6c/0x200) > [ 20.636382] [] (drm_atomic_helper_update_legacy_modeset_state) from [] (drm_atomic_helper_commit_modeset_disables+0x1e4/0x35c) > [ 20.649732] [] (drm_atomic_helper_commit_modeset_disables) from [] (rockchip_atomic_commit_complete+0x34/0x108) > [ 20.661789] [] (rockchip_atomic_commit_complete) from [] (rockchip_drm_atomic_commit+0x84/0xa0) > [ 20.672442] [] (rockchip_drm_atomic_commit) from [] (drm_atomic_commit+0x60/0x70) > [ 20.681711] [] (drm_atomic_commit) from [] (restore_fbdev_mode+0x128/0x258) > [ 20.690418] [] (restore_fbdev_mode) from [] (drm_fb_helper_restore_fbdev_mode_unlocked+0x3c/0x80) > [ 20.701033] [] (drm_fb_helper_restore_fbdev_mode_unlocked) from [] (drm_fb_helper_set_par+0x50/0x60) > [ 20.711907] [] (drm_fb_helper_set_par) from [] (drm_fb_helper_hotplug_event+0xc8/0xe0) > [ 20.721569] [] (drm_fb_helper_hotplug_event) from [] (rockchip_drm_output_poll_changed+0x24/0x28) > [ 20.732185] [] (rockchip_drm_output_poll_changed) from [] (drm_kms_helper_hotplug_event+0x34/0x38) > [ 20.742891] [] (drm_kms_helper_hotplug_event) from [] (drm_helper_hpd_irq_event+0x120/0x150) > [ 20.753078] [] (drm_helper_hpd_irq_event) from [] (dw_hdmi_irq+0x14c/0x18c) > [ 20.761772] [] (dw_hdmi_irq) from [] (irq_thread_fn+0x2c/0x44) > [ 20.769350] [] (irq_thread_fn) from [] (irq_thread+0x118/0x21c) > [ 20.777019] [] (irq_thread) from [] (kthread+0xf4/0x10c) > [ 20.784083] [] (kthread) from [] (ret_from_fork+0x14/0x24) > [ 20.791300] ---[ end trace 3deaa51d288067a0 ]--- > > > > Hi Heiko This issue can be explained from following thread: https://lkml.org/lkml/2015/11/16/498 You can fix it by following changes: @@ -1667,8 +1667,6 @@ static int dw_hdmi_register(struct drm_device *drm, struct dw_hdmi *hdmi) &dw_hdmi_connector_funcs, DRM_MODE_CONNECTOR_HDMIA); - hdmi->connector.encoder = encoder; Thanks. -- ?ark Yao From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755534AbbLQKcp (ORCPT ); Thu, 17 Dec 2015 05:32:45 -0500 Received: from regular1.263xmail.com ([211.150.99.134]:33539 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750846AbbLQKcm (ORCPT ); Thu, 17 Dec 2015 05:32:42 -0500 X-263anti-spam: KSV:0;BIG:0;ABS:1;DNS:0;ATT:0;SPF:S; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 1 X-SKE-CHECKED: 1 X-ADDR-CHECKED: 0 X-RL-SENDER: mark.yao@rock-chips.com X-FST-TO: linux-kernel@vger.kernel.org X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: mark.yao@rock-chips.com X-UNIQUE-TAG: <81d5e54b8d271f9f18d7647d88d86182> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Message-ID: <56728F3F.6060309@rock-chips.com> Date: Thu, 17 Dec 2015 18:32:31 +0800 From: Mark yao User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: =?UTF-8?B?SGVpa28gU3TDvGJuZXI=?= CC: David Airlie , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 0/8] drm/rockchip: covert to support atomic API References: <1450321275-31154-1-git-send-email-mark.yao@rock-chips.com> <4029109.1DucZWNrFm@diego> In-Reply-To: <4029109.1DucZWNrFm@diego> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2015年12月17日 18:00, Heiko Stübner wrote: > Hi Mark, > > Am Donnerstag, 17. Dezember 2015, 11:01:07 schrieb Mark Yao: >> The series of patches coverting drm rockchip to atomic API, do some >> cleanup and some fixes on atomic side. >> >> TODO: fence is not support on current version. >> >> Tested on rk3288 popmetal board. > In general this works nicely and hdmi is still working on my firefly, so > > Tested-by: Heiko Stuebner Thanks. > > I get one warning though, which seems to be related to fbcon grabbing > the framebuffer it seems. > > > HDMI plugged in on boot: > > [ 4.345329] ------------[ cut here ]------------ > [ 4.345360] WARNING: CPU: 1 PID: 66 at drivers/gpu/drm/drm_atomic_helper.c:682 drm_atomic_helper_update_legacy_modeset_state+0x6c/0x200() > [ 4.345373] Modules linked in: > [ 4.345386] CPU: 1 PID: 66 Comm: kworker/u8:1 Not tainted 4.4.0-rc5+ #2787 > [ 4.345392] Hardware name: Rockchip (Device Tree) > [ 4.345411] Workqueue: deferwq deferred_probe_work_func > [ 4.345438] [] (unwind_backtrace) from [] (show_stack+0x20/0x24) > [ 4.345458] [] (show_stack) from [] (dump_stack+0x84/0xb8) > [ 4.345479] [] (dump_stack) from [] (warn_slowpath_common+0x98/0xc4) > [ 4.345496] [] (warn_slowpath_common) from [] (warn_slowpath_null+0x2c/0x34) > [ 4.345514] [] (warn_slowpath_null) from [] (drm_atomic_helper_update_legacy_modeset_state+0x6c/0x200) > [ 4.345534] [] (drm_atomic_helper_update_legacy_modeset_state) from [] (drm_atomic_helper_commit_modeset_disables+0x1e4/0x35c) > [ 4.345557] [] (drm_atomic_helper_commit_modeset_disables) from [] (rockchip_atomic_commit_complete+0x34/0x108) > [ 4.345576] [] (rockchip_atomic_commit_complete) from [] (rockchip_drm_atomic_commit+0x84/0xa0) > [ 4.345594] [] (rockchip_drm_atomic_commit) from [] (drm_atomic_commit+0x60/0x70) > [ 4.345609] [] (drm_atomic_commit) from [] (restore_fbdev_mode+0x128/0x258) > [ 4.345625] [] (restore_fbdev_mode) from [] (drm_fb_helper_restore_fbdev_mode_unlocked+0x3c/0x80) > [ 4.345640] [] (drm_fb_helper_restore_fbdev_mode_unlocked) from [] (drm_fb_helper_set_par+0x50/0x60) > [ 4.345659] [] (drm_fb_helper_set_par) from [] (fbcon_init+0x328/0x458) > [ 4.345676] [] (fbcon_init) from [] (visual_init+0xc4/0x114) > [ 4.345692] [] (visual_init) from [] (do_bind_con_driver+0x1fc/0x330) > [ 4.345707] [] (do_bind_con_driver) from [] (do_take_over_console+0x174/0x1b4) > [ 4.345722] [] (do_take_over_console) from [] (do_fbcon_takeover+0x68/0xd0) > [ 4.345738] [] (do_fbcon_takeover) from [] (fbcon_event_notify+0x3fc/0x7d8) > [ 4.345756] [] (fbcon_event_notify) from [] (notifier_call_chain+0x58/0x80) > [ 4.345771] [] (notifier_call_chain) from [] (__blocking_notifier_call_chain+0x54/0x6c) > [ 4.345785] [] (__blocking_notifier_call_chain) from [] (blocking_notifier_call_chain+0x28/0x30) > [ 4.345804] [] (blocking_notifier_call_chain) from [] (fb_notifier_call_chain+0x24/0x2c) > [ 4.345822] [] (fb_notifier_call_chain) from [] (register_framebuffer+0x214/0x264) > [ 4.345839] [] (register_framebuffer) from [] (drm_fb_helper_initial_config+0x2dc/0x34c) > [ 4.345856] [] (drm_fb_helper_initial_config) from [] (rockchip_drm_fbdev_init+0x9c/0xe4) > [ 4.345873] [] (rockchip_drm_fbdev_init) from [] (rockchip_drm_load+0x25c/0x2b0) > [ 4.345892] [] (rockchip_drm_load) from [] (drm_dev_register+0x80/0xc4) > [ 4.345910] [] (drm_dev_register) from [] (rockchip_drm_bind+0x58/0x84) > [ 4.345932] [] (rockchip_drm_bind) from [] (try_to_bring_up_master.part.0+0xbc/0x114) > [ 4.345950] [] (try_to_bring_up_master.part.0) from [] (component_add+0xb0/0x118) > [ 4.345967] [] (component_add) from [] (vop_probe+0x40/0x4c) > [ 4.345984] [] (vop_probe) from [] (platform_drv_probe+0x60/0xb0) > [ 4.345999] [] (platform_drv_probe) from [] (driver_probe_device+0x1a0/0x418) > [ 4.346014] [] (driver_probe_device) from [] (__device_attach_driver+0x94/0xa0) > [ 4.346028] [] (__device_attach_driver) from [] (bus_for_each_drv+0x94/0xa4) > [ 4.346042] [] (bus_for_each_drv) from [] (__device_attach+0xa4/0x144) > [ 4.346055] [] (__device_attach) from [] (device_initial_probe+0x1c/0x20) > [ 4.346068] [] (device_initial_probe) from [] (bus_probe_device+0x38/0x94) > [ 4.346082] [] (bus_probe_device) from [] (deferred_probe_work_func+0x8c/0xbc) > [ 4.346098] [] (deferred_probe_work_func) from [] (process_one_work+0x328/0x668) > [ 4.346112] [] (process_one_work) from [] (worker_thread+0x2cc/0x41c) > [ 4.346128] [] (worker_thread) from [] (kthread+0xf4/0x10c) > [ 4.346146] [] (kthread) from [] (ret_from_fork+0x14/0x24) > [ 4.346155] ---[ end trace 8cd78a9f6ee0a57e ]--- > > > Plugging in HDMI after boot: > > [ 20.559534] ------------[ cut here ]------------ > [ 20.564412] WARNING: CPU: 3 PID: 74 at drivers/gpu/drm/drm_atomic_helper.c:682 drm_atomic_helper_update_legacy_modeset_state+0x6c/0x200() > [ 20.576991] Modules linked in: > [ 20.580175] CPU: 3 PID: 74 Comm: irq/51-ff980000 Not tainted 4.4.0-rc5+ #2787 > [ 20.587502] Hardware name: Rockchip (Device Tree) > [ 20.592347] [] (unwind_backtrace) from [] (show_stack+0x20/0x24) > [ 20.600319] [] (show_stack) from [] (dump_stack+0x84/0xb8) > [ 20.607776] [] (dump_stack) from [] (warn_slowpath_common+0x98/0xc4) > [ 20.616087] [] (warn_slowpath_common) from [] (warn_slowpath_null+0x2c/0x34) > [ 20.625106] [] (warn_slowpath_null) from [] (drm_atomic_helper_update_legacy_modeset_state+0x6c/0x200) > [ 20.636382] [] (drm_atomic_helper_update_legacy_modeset_state) from [] (drm_atomic_helper_commit_modeset_disables+0x1e4/0x35c) > [ 20.649732] [] (drm_atomic_helper_commit_modeset_disables) from [] (rockchip_atomic_commit_complete+0x34/0x108) > [ 20.661789] [] (rockchip_atomic_commit_complete) from [] (rockchip_drm_atomic_commit+0x84/0xa0) > [ 20.672442] [] (rockchip_drm_atomic_commit) from [] (drm_atomic_commit+0x60/0x70) > [ 20.681711] [] (drm_atomic_commit) from [] (restore_fbdev_mode+0x128/0x258) > [ 20.690418] [] (restore_fbdev_mode) from [] (drm_fb_helper_restore_fbdev_mode_unlocked+0x3c/0x80) > [ 20.701033] [] (drm_fb_helper_restore_fbdev_mode_unlocked) from [] (drm_fb_helper_set_par+0x50/0x60) > [ 20.711907] [] (drm_fb_helper_set_par) from [] (drm_fb_helper_hotplug_event+0xc8/0xe0) > [ 20.721569] [] (drm_fb_helper_hotplug_event) from [] (rockchip_drm_output_poll_changed+0x24/0x28) > [ 20.732185] [] (rockchip_drm_output_poll_changed) from [] (drm_kms_helper_hotplug_event+0x34/0x38) > [ 20.742891] [] (drm_kms_helper_hotplug_event) from [] (drm_helper_hpd_irq_event+0x120/0x150) > [ 20.753078] [] (drm_helper_hpd_irq_event) from [] (dw_hdmi_irq+0x14c/0x18c) > [ 20.761772] [] (dw_hdmi_irq) from [] (irq_thread_fn+0x2c/0x44) > [ 20.769350] [] (irq_thread_fn) from [] (irq_thread+0x118/0x21c) > [ 20.777019] [] (irq_thread) from [] (kthread+0xf4/0x10c) > [ 20.784083] [] (kthread) from [] (ret_from_fork+0x14/0x24) > [ 20.791300] ---[ end trace 3deaa51d288067a0 ]--- > > > > Hi Heiko This issue can be explained from following thread: https://lkml.org/lkml/2015/11/16/498 You can fix it by following changes: @@ -1667,8 +1667,6 @@ static int dw_hdmi_register(struct drm_device *drm, struct dw_hdmi *hdmi) &dw_hdmi_connector_funcs, DRM_MODE_CONNECTOR_HDMIA); - hdmi->connector.encoder = encoder; Thanks. -- Ｍark Yao