From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nick Hoath Subject: Re: [PATCH 4/4] drm/i915: tidy up initialisation failure paths (GEM & LRC) Date: Thu, 17 Dec 2015 11:37:57 +0000 Message-ID: <56729E95.5060706@intel.com> References: <1450291011-31486-1-git-send-email-david.s.gordon@intel.com> <1450291011-31486-5-git-send-email-david.s.gordon@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id E3F077A004 for ; Thu, 17 Dec 2015 03:37:58 -0800 (PST) In-Reply-To: <1450291011-31486-5-git-send-email-david.s.gordon@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: "Gordon, David S" , "intel-gfx@lists.freedesktop.org" List-Id: intel-gfx@lists.freedesktop.org T24gMTYvMTIvMjAxNSAxODozNiwgR29yZG9uLCBEYXZpZCBTIHdyb3RlOgo+IDEuIGFkZCBjYWxs IHRvIGk5MTVfZ2VtX2NvbnRleHRfZmluaSgpIHRvIGRlYWxsb2NhdGUgdGhlIGRlZmF1bHQKPiAg ICAgY29udGV4dChzKSBpZiB0aGUgY2FsbCB0byBpbml0X3JpbmdzKCkgZmFpbHMsIHNvIHRoYXQg d2UgZG9uJ3QKPiAgICAgbGVhayB0aGUgY29udGV4dCBpbiB0aGF0IHNpdHVhdGlvbi4KPgo+IDIu IHJlbW92ZSB1c2VsZXNzIGNvZGUgaW4gaW50ZWxfbG9naWNhbF9yaW5nX2NsZWFudXAoKSwgcHJl c3VtYWJseQo+ICAgICBjb3B5cGFzdGVkIGZyb20gbGVnYWN5IHJpbmdidWZmZXIgdmVyc2lvbiBh dCBjcmVhdGlvbi4KPgoKUmV2aWV3ZWQtYnk6IE5pY2sgSG9hdGggPG5pY2hvbGFzLmhvYXRoQGlu dGVsLmNvbT4KCj4gU2lnbmVkLW9mZi1ieTogRGF2ZSBHb3Jkb24gPGRhdmlkLnMuZ29yZG9uQGlu dGVsLmNvbT4KPiAtLS0KPiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtLmMgIHwgIDUg KysrKy0KPiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2xyYy5jIHwgMTAgKystLS0tLS0t LQo+ICAgMiBmaWxlcyBjaGFuZ2VkLCA2IGluc2VydGlvbnMoKyksIDkgZGVsZXRpb25zKC0pCj4K PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0uYyBiL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2k5MTVfZ2VtLmMKPiBpbmRleCA2NmIxNzA1Li4xNWY4OTg5IDEwMDY0NAo+ IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtLmMKPiArKysgYi9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pOTE1X2dlbS5jCj4gQEAgLTQ4OTAsOCArNDg5MCwxMSBAQCBpbnQgaTkxNV9n ZW1faW5pdChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2KQo+ICAgCQlnb3RvIG91dF91bmxvY2s7Cj4K PiAgIAlyZXQgPSBkZXZfcHJpdi0+Z3QuaW5pdF9yaW5ncyhkZXYpOwo+IC0JaWYgKHJldCkKPiAr CWlmIChyZXQpIHsKPiArCQlpOTE1X2dlbV9jb250ZXh0X2ZpbmkoZGV2KTsKPiArCQkvKiBYWFg6 IGFueXRoaW5nIGVsc2UgdG8gYmUgdW5kb25lIGhlcmU/ICovCj4gICAJCWdvdG8gb3V0X3VubG9j azsKPiArCX0KPgo+ICAgCXJldCA9IGk5MTVfZ2VtX2luaXRfaHcoZGV2KTsKPiAgIAlpZiAocmV0 ID09IC1FSU8pIHsKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfbHJj LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9scmMuYwo+IGluZGV4IDIzZjkwYjIuLmNk YjY1ZWIgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfbHJjLmMKPiAr KysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9scmMuYwo+IEBAIC0xODg3LDE3ICsxODg3 LDExIEBAIHN0YXRpYyBpbnQgZ2VuOF9pbml0X3Jjc19jb250ZXh0KHN0cnVjdCBkcm1faTkxNV9n ZW1fcmVxdWVzdCAqcmVxKQo+ICAgICovCj4gICB2b2lkIGludGVsX2xvZ2ljYWxfcmluZ19jbGVh bnVwKHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKnJpbmcpCj4gICB7Cj4gLQlzdHJ1Y3QgZHJtX2k5 MTVfcHJpdmF0ZSAqZGV2X3ByaXY7Cj4gLQo+ICAgCWlmICghaW50ZWxfcmluZ19pbml0aWFsaXpl ZChyaW5nKSkKPiAgIAkJcmV0dXJuOwo+Cj4gLQlkZXZfcHJpdiA9IHJpbmctPmRldi0+ZGV2X3By aXZhdGU7Cj4gLQo+IC0JaWYgKHJpbmctPmJ1ZmZlcikgewo+IC0JCWludGVsX2xvZ2ljYWxfcmlu Z19zdG9wKHJpbmcpOwo+IC0JCVdBUk5fT04oKEk5MTVfUkVBRF9NT0RFKHJpbmcpICYgTU9ERV9J RExFKSA9PSAwKTsKPiAtCX0KPiArCS8qIHNob3VsZCBub3QgYmUgc2V0IGluIExSQyBtb2RlICov Cj4gKwlXQVJOX09OKHJpbmctPmJ1ZmZlcik7Cj4KPiAgIAlpZiAocmluZy0+Y2xlYW51cCkKPiAg IAkJcmluZy0+Y2xlYW51cChyaW5nKTsKPgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMu ZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0 aW5mby9pbnRlbC1nZngK