From mboxrd@z Thu Jan 1 00:00:00 1970 From: James Smart Subject: Re: [PATCH 14/17] lpfc: Add logging for misconfigured optics. Date: Thu, 17 Dec 2015 07:51:36 -0800 Message-ID: <5672DA08.7000507@avagotech.com> References: <5671efc5.BjzS3MZMgzpO419g%james.smart@avagotech.com> <56727484.9070903@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mail-pa0-f49.google.com ([209.85.220.49]:35307 "EHLO mail-pa0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934742AbbLQPvj (ORCPT ); Thu, 17 Dec 2015 10:51:39 -0500 Received: by mail-pa0-f49.google.com with SMTP id jx14so15484081pad.2 for ; Thu, 17 Dec 2015 07:51:39 -0800 (PST) In-Reply-To: <56727484.9070903@suse.de> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Hannes Reinecke , linux-scsi@vger.kernel.org On 12/17/2015 12:38 AM, Hannes Reinecke wrote: > On 12/17/2015 12:12 AM, James Smart wrote: >> > Why isn't this special cased anymore? Is it now supported by all HBAs? Yes - if and when/where an async event is generated by the adapter is in the fw. The special casing wasn't needed in the first place. > > Hmm. How does this pan out on older cards? > Does every card sending out this event support the optic > misconfiguration detection? Or is there a chance that we lose the link > just because the event isn't properly implemented and we detect it as > non-operational? > Every card could - but whether it does is specific to the card and how it was built and the restrictions made on that card type. The adapter itself manages that. The event to the driver is solely for reporting. The driver can't influence optics behavior. -- james s