From: Richard Henderson <rth@twiddle.net>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: ehabkost@redhat.com
Subject: Re: [Qemu-devel] [PATCH] target-i386: do not duplicate page protection checks
Date: Thu, 17 Dec 2015 08:43:39 -0800 [thread overview]
Message-ID: <5672E63B.6050003@twiddle.net> (raw)
In-Reply-To: <1450360829-1955-1-git-send-email-pbonzini@redhat.com>
On 12/17/2015 06:00 AM, Paolo Bonzini wrote:
> x86_cpu_handle_mmu_fault is currently checking twice for writability
> and executability of pages; the first time to decide whether to
> trigger a page fault, the second time to compute the "prot" argument
> to tlb_set_page_with_attrs.
>
> Reorganize code so that first "prot" is computed, then it is used
> to check whether to raise a page fault, then finally PROT_WRITE is
> removed if the D bit will have to be set.
>
> Signed-off-by: Paolo Bonzini<pbonzini@redhat.com>
> ---
> target-i386/helper.c | 65 +++++++++++++++++++---------------------------------
> 1 file changed, 23 insertions(+), 42 deletions(-)
Reviewed-by: Richard Henderson <rth@twiddle.net>
r~
prev parent reply other threads:[~2015-12-17 16:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-17 14:00 [Qemu-devel] [PATCH] target-i386: do not duplicate page protection checks Paolo Bonzini
2015-12-17 16:43 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5672E63B.6050003@twiddle.net \
--to=rth@twiddle.net \
--cc=ehabkost@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.