From: Eric Blake <eblake@redhat.com>
To: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org
Cc: kwolf@redhat.com, stefanha@redhat.com, mdroth@linux.vnet.ibm.com,
qemu-block@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/4] scripts/qmp: Use Python 2.6 "except E as ..." syntax
Date: Thu, 17 Dec 2015 10:27:27 -0700 [thread overview]
Message-ID: <5672F07F.1040709@redhat.com> (raw)
In-Reply-To: <1450346791-25562-3-git-send-email-armbru@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 612 bytes --]
On 12/17/2015 03:06 AM, Markus Armbruster wrote:
> PEP 8 calls for it, because it's forward compatibile with Python 3.
Here, and also in 1/4,
s/compatibile/compatible/
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> scripts/qmp/qemu-ga-client | 2 +-
> scripts/qmp/qmp | 4 ++--
> scripts/qmp/qmp-shell | 2 +-
> scripts/qmp/qmp.py | 4 ++--
> 4 files changed, 6 insertions(+), 6 deletions(-)
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2015-12-17 17:27 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-17 10:06 [Qemu-devel] [PATCH 0/4] Use Python 2.6 "except E as ..." syntax Markus Armbruster
2015-12-17 10:06 ` [Qemu-devel] [PATCH 1/4] qapi: " Markus Armbruster
2015-12-17 17:26 ` Eric Blake
2015-12-17 18:35 ` Markus Armbruster
2015-12-17 19:58 ` Eric Blake
2015-12-17 20:00 ` Peter Maydell
2015-12-17 10:06 ` [Qemu-devel] [PATCH 2/4] scripts/qmp: " Markus Armbruster
2015-12-17 17:27 ` Eric Blake [this message]
2015-12-17 10:06 ` [Qemu-devel] [PATCH 3/4] Revert "tracetool: use Python 2.4-compatible exception handling syntax" Markus Armbruster
2015-12-17 17:28 ` Eric Blake
2015-12-17 18:37 ` Markus Armbruster
2015-12-17 19:59 ` Eric Blake
2015-12-17 10:06 ` [Qemu-devel] [PATCH 4/4] tests: Use Python 2.6 "except E as ..." syntax Markus Armbruster
2015-12-17 17:29 ` Eric Blake
2015-12-18 5:10 ` [Qemu-devel] [PATCH 0/4] " Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5672F07F.1040709@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=kwolf@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.