From: "Jason J. Herne" <jjherne@linux.vnet.ibm.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: blauwirbel@gmail.com, cornelia.huck@de.ibm.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2] checkpatch: Detect newlines in error_report and other error functions
Date: Thu, 17 Dec 2015 12:49:15 -0500 [thread overview]
Message-ID: <5672F59B.7020907@linux.vnet.ibm.com> (raw)
In-Reply-To: <87mvtdnim6.fsf@blackfin.pond.sub.org>
On 12/14/2015 10:40 AM, Markus Armbruster wrote:
> "Jason J. Herne" <jjherne@linux.vnet.ibm.com> writes:
>
>> On 12/14/2015 07:47 AM, Markus Armbruster wrote:
>>> "Jason J. Herne" <jjherne@linux.vnet.ibm.com> writes:
>>>
>>>> We don't want newlines embedded in error messages. This seems to be a common
>>>> problem with new code so let's try to catch it with checkpatch.
>>>>
>>>> This will not catch cases where newlines are inserted into the middle of an
>>>> existing multi-line statement. But those cases should be rare.
>>>>
>>>> Signed-off-by: Jason J. Herne <jjherne@linux.vnet.ibm.com>
>>>
...
>> But I will take a look at this series and see if we can do better :).
>
> Thanks! If we can't, then I'm for taking this imperfect patch, because
> flagging some of these mistakes is better than flagging none.
>
>
I won't get a chance to get back to this before the new year. So feel
free to push this (unless someone objects) and I'll see what I can do
about improving it in January.
Happy holidays! :)
--
-- Jason J. Herne (jjherne@linux.vnet.ibm.com)
next prev parent reply other threads:[~2015-12-17 17:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-11 18:30 [Qemu-devel] [PATCH v2] checkpatch: Detect newlines in error_report and other error functions Jason J. Herne
2015-12-14 12:47 ` Markus Armbruster
2015-12-14 14:45 ` Jason J. Herne
2015-12-14 15:40 ` Markus Armbruster
2015-12-17 17:49 ` Jason J. Herne [this message]
2015-12-17 18:28 ` Markus Armbruster
2015-12-18 15:06 ` Markus Armbruster
2016-01-11 21:37 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5672F59B.7020907@linux.vnet.ibm.com \
--to=jjherne@linux.vnet.ibm.com \
--cc=armbru@redhat.com \
--cc=blauwirbel@gmail.com \
--cc=cornelia.huck@de.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.