From: Paolo Bonzini <pbonzini@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>, Fam Zheng <famz@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/2] iotests: Don't mention bdrv_swap in comments
Date: Thu, 17 Dec 2015 20:07:12 +0100 [thread overview]
Message-ID: <567307E0.4040708@redhat.com> (raw)
In-Reply-To: <20151217082134.GA5874@noname.redhat.com>
On 17/12/2015 09:21, Kevin Wolf wrote:
>> > -# 'format': 'nbd' is not actually "correct", but this is probably the only way
>> > -# to test bdrv_swap() on an NBD BDS
>> > _send_qemu_cmd $QEMU_HANDLE \
>> > "{'execute': 'drive-mirror',
>> > 'arguments': {'device': 'src',
> Just completely removing the comment doesn't seem right to me if we
> leave the "bad" option around.
>
> The test seems to be a regression test for what was fixed in commit
> f53a829, i.e. a direct effect of bdrv_swap(). This effect can't exist
> any more, so we would keep the test just for some additional coverage
> for NBD. Do we still need 'format': 'nbd' (if so, with a comment why we
> do that) or should we make it 'raw' now?
Some coverage of no-format BDSes is nice to have, since raw is sometimes
measurably slower than no format at all.
Paolo
prev parent reply other threads:[~2015-12-17 19:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-17 5:09 [Qemu-devel] [PATCH 0/2] Clean up the remainders of bdrv_swap Fam Zheng
2015-12-17 5:09 ` [Qemu-devel] [PATCH 1/2] block: Remove prototype of bdrv_swap from header Fam Zheng
2015-12-17 5:09 ` [Qemu-devel] [PATCH 2/2] iotests: Don't mention bdrv_swap in comments Fam Zheng
2015-12-17 8:21 ` Kevin Wolf
2015-12-17 12:44 ` Fam Zheng
2015-12-17 12:48 ` Kevin Wolf
2015-12-17 19:07 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=567307E0.4040708@redhat.com \
--to=pbonzini@redhat.com \
--cc=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.