From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hal Rosenstock Subject: Re: [PATCH 3/3] IB core: Display 64 bit counters from the extended set Date: Thu, 17 Dec 2015 14:14:05 -0500 Message-ID: <5673097D.8050906@dev.mellanox.co.il> References: <20151211182532.332343651@linux.com> <20151211182543.329283794@linux.com> <20151211235630.GG7855@phlsvsds.ph.intel.com> <20151212000047.GA9961@obsidianresearch.com> <566EEE69.5080906@dev.mellanox.co.il> <20151215195554.GA28167@obsidianresearch.com> <5670717F.9090701@dev.mellanox.co.il> <20151215212035.GD28167@obsidianresearch.com> <5672F47F.9060806@dev.mellanox.co.il> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Christoph Lameter Cc: Jason Gunthorpe , "ira.weiny" , Doug Ledford , linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-rdma@vger.kernel.org On 12/17/2015 1:54 PM, Christoph Lameter wrote: > On Thu, 17 Dec 2015, Hal Rosenstock wrote: >> ClassPortInfo is per class not per class per port so need to indicate to >> get_mad whether a port is supplied or not or conditionalize based on >> attr ID. > > I thought a port is always supplied since we get the info for a particular > port and the directory only exists if there is a port? Yes, but there is no port (PortSelect) field in ClassPortInfo attribute unlike the PortCounters and PortExtendedCounters attributes. >>> - ret = sysfs_create_group(&p->kobj, &pma_group); >>> + ret = sysfs_create_group(&p->kobj, >>> + port_check_extended_counters(device, port_num) ? >>> + &pma_group_ext : >>> + &pma_group); >> >> PortExtendedCounters does not have all the error counters in >> PortCounters so this isn't an either or. When extended port counters are >> supported should still include the original port counters with the >> exception of the [xmit rcv] [pkts data] which should come from the >> extended counters. > > The original port counters are still included. The _ext table refers to > both extended and regular counters. Good; I missed that; sorry. -- Hal -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html