From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from wolverine01.qualcomm.com ([199.106.114.254]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1a9gXe-0000nB-3C for ath10k@lists.infradead.org; Thu, 17 Dec 2015 21:56:55 +0000 Message-ID: <56732F64.2020508@qca.qualcomm.com> Date: Thu, 17 Dec 2015 13:55:48 -0800 From: Peter Oh MIME-Version: 1.0 Subject: Re: [PATCH] ath10k: add modparam 'hw_csum' to make HW checksum configurable References: <1450290051-15593-1-git-send-email-poh@qca.qualcomm.com> <5671AD10.70004@openwrt.org> <5671C99A.703@codeaurora.org> <5671CAF5.6010606@openwrt.org> <5671CDBD.5060006@codeaurora.org> <5671CF63.9040308@openwrt.org> <5671D56F.8030903@codeaurora.org> <5671DDA1.5030709@openwrt.org> <5671F8B7.2060801@codeaurora.org> In-Reply-To: List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Michal Kazior , Peter Oh Cc: "nbd@openwrt.org" , linux-wireless , "ath10k@lists.infradead.org" Ck9uIDEyLzE2LzIwMTUgMTE6MjkgUE0sIE1pY2hhbCBLYXppb3Igd3JvdGU6Cj4gT24gMTcgRGVj ZW1iZXIgMjAxNSBhdCAwMDo1MCwgUGV0ZXIgT2ggPHBvaEBjb2RlYXVyb3JhLm9yZz4gd3JvdGU6 Cj4+IE9uIDEyLzE2LzIwMTUgMDE6NTQgUE0sIEZlbGl4IEZpZXRrYXUgd3JvdGU6Cj4+PiBPbiAy MDE1LTEyLTE2IDIyOjE5LCBQZXRlciBPaCB3cm90ZToKPiBbLi4uXQo+Pj4+IElmIG1lbnRpb25l ZCB0byB1c2UgdGhlIGZ1bmN0aW9uIHRvIG1lc2ggZnJhbWUgb25seSB3aXRob3V0IHRvdWNoaW5n Cj4+Pj4gbWFjODAyMTEsIHRoZW4gaG93IGRvIHlvdSBzdWdnZXN0IGl0IHRvIGFwcGx5IGl0IG9u bHkgdG8gbWVzaCBmcmFtZQo+Pj4+IHdpdGhvdXQgaW50ZXJmZXJlIG90aGVyIGRhdGEgZnJhbWVz Pwo+Pj4+IENhbiB5b3Ugc2hhcmUgeW91ciBleGFtcGxlPwo+Pj4gSXQncyB0cml2aWFsIC0gaW4g YXRoMTBrX3R4IHlvdSBkbyB0aGlzOgo+Pj4KPj4+IGlmICh2aWYtPnR5cGUgPT0gTkw4MDIxMV9J RlRZUEVfTUVTSF9QT0lOVCAmJgo+Pj4gICAgICAgc2tiLT5pcF9zdW1tZWQgPT0gQ0hFQ0tTVU1f UEFSVElBTCkKPj4+ICAgICAgICAgIHNrYl9jaGVja3N1bV9oZWxwKHNrYik7Cgo+PiBUaGFuayB5 b3UgRmVsaXggZm9yIHRoZSBxdWljayByZXNwb25zZS4KPj4gSSBhZ3JlZSBvbiB5b3VyIHVzZXIg ZXhwZXJpZW5jZSBvcGluaW9uLAo+PiBidXQgd2hhdCBkbyB5b3UgdGhpbmsgd2hlbiBhdGgxMGsg aGFzIGEgbmV3IGNoaXAgc3VwcG9ydGluZyBIVyBjaGVja3N1bSBmb3IKPj4gTWVzaD8KPiBZb3Ug Y2FuIHNpbXBseSBpbnRyb2R1Y2UgYSBmdy1mZWF0dXJlIGZsYWcgc2F5aW5nCj4gInN1cHBvcnRz X21lc2hfY3N1bV9vZmZsb2FkIiBsYXRlciBhbmQgc2tpcCB0aGUgc2tiX2NoZWNrc3VtX2hlbHAo KSBpZgo+IGl0J3Mgc2V0LgpJZiB3ZSByZWx5IG9uIGZ3LWZlYXR1cmUgZmxhZywgdGhlbiB3ZSBh cmUgbm90IGFibGUgdG8gdXNlIEhXIGNoZWNrc3VtIAphdCBhbGwgZXZlbiBmb3IgQVAvU1RBIGlu dGVyZmFjZXMuCgo+Cj4gTWljaGHFggpUaGFua3MsClBldGVyCgpfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwphdGgxMGsgbWFpbGluZyBsaXN0CmF0aDEwa0Bs aXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlz dGluZm8vYXRoMTBrCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from sabertooth01.qualcomm.com ([65.197.215.72]:10781 "EHLO sabertooth01.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933137AbbLQV4d (ORCPT ); Thu, 17 Dec 2015 16:56:33 -0500 Message-ID: <56732F64.2020508@qca.qualcomm.com> (sfid-20151217_225637_600717_C4EE6B28) Date: Thu, 17 Dec 2015 13:55:48 -0800 From: Peter Oh MIME-Version: 1.0 To: Michal Kazior , Peter Oh CC: "nbd@openwrt.org" , "ath10k@lists.infradead.org" , linux-wireless Subject: Re: [PATCH] ath10k: add modparam 'hw_csum' to make HW checksum configurable References: <1450290051-15593-1-git-send-email-poh@qca.qualcomm.com> <5671AD10.70004@openwrt.org> <5671C99A.703@codeaurora.org> <5671CAF5.6010606@openwrt.org> <5671CDBD.5060006@codeaurora.org> <5671CF63.9040308@openwrt.org> <5671D56F.8030903@codeaurora.org> <5671DDA1.5030709@openwrt.org> <5671F8B7.2060801@codeaurora.org> In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: On 12/16/2015 11:29 PM, Michal Kazior wrote: > On 17 December 2015 at 00:50, Peter Oh wrote: >> On 12/16/2015 01:54 PM, Felix Fietkau wrote: >>> On 2015-12-16 22:19, Peter Oh wrote: > [...] >>>> If mentioned to use the function to mesh frame only without touching >>>> mac80211, then how do you suggest it to apply it only to mesh frame >>>> without interfere other data frames? >>>> Can you share your example? >>> It's trivial - in ath10k_tx you do this: >>> >>> if (vif->type == NL80211_IFTYPE_MESH_POINT && >>> skb->ip_summed == CHECKSUM_PARTIAL) >>> skb_checksum_help(skb); >> Thank you Felix for the quick response. >> I agree on your user experience opinion, >> but what do you think when ath10k has a new chip supporting HW checksum for >> Mesh? > You can simply introduce a fw-feature flag saying > "supports_mesh_csum_offload" later and skip the skb_checksum_help() if > it's set. If we rely on fw-feature flag, then we are not able to use HW checksum at all even for AP/STA interfaces. > > Michał Thanks, Peter