From: Guenter Roeck <linux@roeck-us.net>
To: Li RongQing <roy.qing.li@gmail.com>
Cc: linux-watchdog@vger.kernel.org, wim@iguana.be
Subject: Re: [PATCH] watchdog: refuse to unload softdog module when its timer is running
Date: Thu, 17 Dec 2015 17:42:23 -0800 [thread overview]
Message-ID: <5673647F.5040707@roeck-us.net> (raw)
In-Reply-To: <CAJFZqHxvRX8ZW--VCx+N7zA-kOTXVt1tsQ2Ob1otMNJP6BREJw@mail.gmail.com>
On 12/17/2015 04:55 PM, Li RongQing wrote:
> On Thu, Dec 17, 2015 at 10:50 PM, Guenter Roeck <linux@roeck-us.net> wrote:
>> Don't bother with module_put() here.
>
>
> I think this is needed;
>
> the softdog supported soft_noreboot "Softdog action, set to 1 to
> ignore reboots, 0 to reboot (default=0)"
> if soft_noreboot is 1, and not call module_put(THIS_MODULE) in watchdog_fire,
> softdog module ref count is leaked, and softdog will not be unload
>
Good point.
Guenter
> -Roy
> --
> To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2015-12-18 1:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-17 13:30 [PATCH] watchdog: refuse to unload softdog module when its timer is running roy.qing.li
2015-12-17 14:50 ` Guenter Roeck
2015-12-18 0:55 ` Li RongQing
2015-12-18 1:42 ` Guenter Roeck [this message]
2015-12-18 2:03 ` Guenter Roeck
2015-12-27 20:03 ` Wim Van Sebroeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5673647F.5040707@roeck-us.net \
--to=linux@roeck-us.net \
--cc=linux-watchdog@vger.kernel.org \
--cc=roy.qing.li@gmail.com \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.