From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ilya Maximets <i.maximets@samsung.com>
Subject: Re: [PATCH] Unlink existing unused sockets at start up
Date: Fri, 18 Dec 2015 09:17:56 +0300
Message-ID: <5673A514.10004@samsung.com>
References: <1450326062-105574-1-git-send-email-zhihong.wang@intel.com>
 <5672A0E5.4040904@samsung.com>
 <8F6C2BD409508844A0EFC19955BE0941856F7D@SHSMSX103.ccr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Cc: "s.dyasly@samsung.com" <s.dyasly@samsung.com>
To: "Wang, Zhihong" <zhihong.wang@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Return-path: <dev-bounces@dpdk.org>
Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com
 [210.118.77.12]) by dpdk.org (Postfix) with ESMTP id A37738D8C
 for <dev@dpdk.org>; Fri, 18 Dec 2015 07:17:59 +0100 (CET)
Received: from eucpsbgm2.samsung.com (unknown [203.254.199.245])
 by mailout2.w1.samsung.com
 (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014))
 with ESMTP id <0NZJ003RWITX8Y70@mailout2.w1.samsung.com> for dev@dpdk.org;
 Fri, 18 Dec 2015 06:17:57 +0000 (GMT)
In-reply-to: <8F6C2BD409508844A0EFC19955BE0941856F7D@SHSMSX103.ccr.corp.intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 18.12.2015 05:39, Wang, Zhihong wrote:

> Yes ideally the underneath lib shouldn't meddle with the recovery logic.
> But I do think we should at least put a warning in the lib function said the app should make the path available. This is another topic though :-)
> Like we did in memcpy:
> /**
>  * Copy 16 bytes from one location to another,
>  * locations should not overlap.
>  */
> 

Isn't it enough to have an error in the log?

lib/librte_vhost/vhost_user/vhost-net-user.c:130:
RTE_LOG(ERR, VHOST_CONFIG, "fail to bind fd:%d, remove file:%s and try again.\n",

Best regards, Ilya Maximets.