From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH 1/4] build: Hook the schedulers into Kconfig
Date: Fri, 18 Dec 2015 08:57:23 +0000
Message-ID: <5673CA73.3030007@citrix.com>
References: <1450385974-12732-1-git-send-email-jonathan.creekmore@gmail.com>
	<1450385974-12732-2-git-send-email-jonathan.creekmore@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta14.messagelabs.com ([193.109.254.103])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <amc96@hermes.cam.ac.uk>) id 1a9qqt-0006EH-A0
	for xen-devel@lists.xenproject.org; Fri, 18 Dec 2015 08:57:27 +0000
In-Reply-To: <1450385974-12732-2-git-send-email-jonathan.creekmore@gmail.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jonathan Creekmore <jonathan.creekmore@gmail.com>, xen-devel@lists.xenproject.org
Cc: George Dunlap <george.dunlap@eu.citrix.com>, Dario Faggioli <dario.faggioli@citrix.com>
List-Id: xen-devel@lists.xenproject.org

On 17/12/2015 20:59, Jonathan Creekmore wrote:
> Allow the schedulers to be independently enabled or disabled at
> compile-time instead of just allowing the scheduler to be selected on
> the command line. To match existing behavior, all four schedulers are
> compiled in by default, although the RTDS and ARINC653 are marked
> EXPERIMENTAL to match their not currently supported status.
>
> CC: George Dunlap <george.dunlap@eu.citrix.com>
> CC: Dario Faggioli <dario.faggioli@citrix.com>
> Signed-off-by: Jonathan Creekmore <jonathan.creekmore@gmail.com>

With the suggestions Dario made, and one minor nit below,

Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>

> diff --git a/xen/common/Makefile b/xen/common/Makefile
> index 8ab15ba..3a2026a 100644
> --- a/xen/common/Makefile
> +++ b/xen/common/Makefile
> @@ -30,10 +30,10 @@ obj-y += rangeset.o
>  obj-y += radix-tree.o
>  obj-y += rbtree.o
>  obj-y += rcupdate.o
> -obj-y += sched_credit.o
> -obj-y += sched_credit2.o
> -obj-y += sched_arinc653.o
> -obj-y += sched_rt.o
> +obj-$(CONFIG_SCHED_CREDIT) += sched_credit.o
> +obj-$(CONFIG_SCHED_CREDIT2) += sched_credit2.o
> +obj-$(CONFIG_SCHED_ARINC653) += sched_arinc653.o
> +obj-$(CONFIG_SCHED_RTDS) += sched_rt.o

I know it was wrong before, but please reorder