From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Zhong Subject: Re: [PATCH v6 0/6] Add mipi dsi support for rk3288 Date: Fri, 18 Dec 2015 17:54:03 +0800 Message-ID: <5673D7BB.50000@rock-chips.com> References: <1450260616-21160-1-git-send-email-zyw@rock-chips.com> <3523259.ZRgH1Shd9Y@diego> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <3523259.ZRgH1Shd9Y@diego> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: =?UTF-8?Q?Heiko_St=c3=bcbner?= Cc: Mark Rutland , devicetree@vger.kernel.org, Russell King , Pawel Moll , Ian Campbell , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, Rob Herring , Kumar Gala , treding@nvidia.com, linux-arm-kernel@lists.infradead.org List-Id: linux-rockchip.vger.kernel.org SGkgSGVpa28KClRoYW5rcyBmb3IgeW91ciByZW1pbmRlci4KSSBoYXZlIHBvc3QgdGhlIHY2LjEg bWlwaSBwYXRjaCB3aXRoIHRoZSBhdG9taWMgc3VwcG9ydC4KPGh0dHBzOi8vcGF0Y2h3b3JrLmtl cm5lbC5vcmcvcGF0Y2gvNzg4MTc4MS8+CgpPbiAxMi8xNy8yMDE1IDA1OjI5IFBNLCBIZWlrbyBT dMO8Ym5lciB3cm90ZToKPiBIaSBDaHJpcywKPgo+IEFtIE1pdHR3b2NoLCAxNi4gRGV6ZW1iZXIg MjAxNSwgMTg6MTA6MTAgc2NocmllYiBDaHJpcyBaaG9uZzoKPj4gVGhlIHJrMzI4OCBNSVBJIERT SSBpcyBhIFN5bm9wc3lzIERlc2lnbldhcmUgTUlQSSBEU0kgaG9zdCBjb250cm9sbGVyCj4+IElQ LiBUaGlzIHNlcmllcyBhZGRzIHN1cHBvcnQgZm9yIGEgU3lub3BzeXMgRGVzaWduV2FyZSBNSVBJ IERTSSBob3N0Cj4+IGNvbnRyb2xsZXIgRFJNIGRyaXZlci4KPj4KPj4gVGhlIE1JUEkgRFNJIGZl YXR1cmUgaXMgdGVzdGVkIG9uIHJrMzI4OCBldmIgYm9hcmQsIGJhY2twb3J0IHRoZW0gdG8KPj4g Y2hyb21lIG9zIGtlcm5lbCBjaHJvbWVfdjMuMTQsIGFuZCBpdCBjYW4gZGlzcGxheSBub3JtYWxs eS4KPj4KPj4gVGhpcyBwYXRjaHNldCBpcyBiYXNlIG9uIHRoZSBwYXRjaHNldCBmcm9tIFlpbmcu bGl1QGZyZWVzY2FsZS5jb20uCj4+IDxodHRwOi8vd3d3LnNwaW5pY3MubmV0L2xpc3RzL2RyaS1k ZXZlbC9tc2c3NzE4MS5odG1sPgo+Pgo+PiBBY2NvcmRpbmcgdG8gdGhlIHN1Z2dlc3Rpb24gZnJv bSBUaGllcnJ5LCBJIGhhdmUgZ2V0IHJpZCBvZiB0aGUgYnJpZGdlLAo+PiBhbmQgcmVnaXN0ZXIg dGhlIGVuY29kZXIgJiBjb25uZWN0ZXIgaW4gZHJtL3JvY2tjaGlwL2R3LW1pcGktZHNpLmMuCj4g ZnJvbSBteSBwb2ludCBpdCBsb29rcyBnb29kIChhbHRob3VnaCBJIGNhbm5vdCByZWFsbHkgc3Bl YWsgb24gdGhlIGRybS1yZWxhdGVkCj4gaW50ZXJuYWxzKS4KPgo+IEJ1dCBJIGRvIHRoaW5rIHdl J2xsIGJlIGRvaW5nIGF0b21pYyBtb2Rlc2V0dGluZyBjb252ZXJzaW9uIGZpcnN0IChsYXN0Cj4g dmVyc2lvbiBwb3N0ZWQgZnJvbSBNYXJrIHRvZGF5KSwgc28geW91IHNob3VsZCBwcm9iYWJseSBt YWtlIHN1cmUgeW91ciBkc2kKPiBkcml2ZXIgc3RpbGwgd29ya3MgYWZ0ZXIgdGhhdCBjb252ZXJz aW9uIGFuZCBtYWtlIGNoYW5nZXMgaWYgbmVlZGVkLgo+Cj4KPiBIZWlrbwo+Cj4+Cj4+IENoYW5n ZXMgaW4gdjY6Cj4+IC0gdXBkYXRlIHRoZSBkb2N1bWVudCwgc2luY2UgdGhlIGJyaWRnZSBkZXZp Y2UgaGFzIGJlZW4gZGVsZXRlZC4KPj4gLSBEbyBub3QgdXNlIGJyaWRnZSBkcml2ZXIgKFRoaWVy cnkgUmVkaW5nKQo+PiAtIE9wdGltaXphdGlvbiB0aGUgcGh5IGluaXQgc2VxdWVuY2UKPj4KPj4g Q2hhbmdlcyBpbiB2NToKPj4gLSBtb2RpZnkgdGhlIGNsayBuYW1lIHRvIFNDTEtfTUlQSURTSV8y NE0KPj4gLSBhZGQgYSBibGFuayBsaW5lIGJlZm9yIGxjZF9lbgo+Pgo+PiBDaGFuZ2VzIGluIHY0 Ogo+PiAtIHVzZSBjbGtfcm91bmRfcmF0ZSB0byBjaGVjayB0aGUgY2xvY2sgcmF0ZSBpbiB2b3Bf Y3J0Y19tb2RlX2ZpeHVwCj4+Cj4+IENoYW5nZXMgaW4gdjM6Cj4+IC0gbW92ZSBkd19taXBpX2Rz aV9yb2NrY2hpcC50eHQgdG8gYmluZGluZ3MvZGlzcGxheS9yb2NrY2hpcC8KPj4KPj4gQ2hyaXMg WmhvbmcgKDUpOgo+PiAgICBkcm0vcm9ja2NoaXA6IHJldHVybiBhIHRydWUgY2xvY2sgcmF0ZSB0 byBhZGp1c3RlZF9tb2RlCj4+ICAgIERvY3VtZW50YXRpb246IGR0LWJpbmRpbmdzOiBBZGQgYmlu ZGluZ3MgZm9yIHJrMzI4OCBEVyBNSVBJIERTSSBkcml2ZXIKPj4gICAgZHJtOiByb2NrY2hpcDog U3VwcG9ydCBTeW5vcHN5cyBEVyBNSVBJIERTSQo+PiAgICBBUk06IGR0czogcm9ja2NoaXA6IGFk ZCByazMyODggbWlwaV9kc2kgbm9kZXMKPj4gICAgQVJNOiBkdHM6IHJvY2tjaGlwOiBhZGQgc3Vw cG9ydCBtaXBpIHBhbmVsIHR2MDgwd3VtLW5sMAo+Pgo+PiBMaXUgWWluZyAoMSk6Cj4+ICAgIGRy bS9kc2k6IEFkZCBhIGhlbHBlciB0byBnZXQgYml0cyBwZXIgcGl4ZWwgb2YgTUlQSSBEU0kgcGl4 ZWwgZm9ybWF0Cj4+Cj4+ICAgLi4uL2Rpc3BsYXkvcm9ja2NoaXAvZHdfbWlwaV9kc2lfcm9ja2No aXAudHh0ICAgICAgfCAgIDYwICsKPj4gICBhcmNoL2FybS9ib290L2R0cy9yazMyODgtZXZiLmR0 c2kgICAgICAgICAgICAgICAgICB8ICAgMjAgKy0KPj4gICBhcmNoL2FybS9ib290L2R0cy9yazMy ODguZHRzaSAgICAgICAgICAgICAgICAgICAgICB8ICAgMzkgKwo+PiAgIGRyaXZlcnMvZ3B1L2Ry bS9yb2NrY2hpcC9LY29uZmlnICAgICAgICAgICAgICAgICAgIHwgICAxMCArCj4+ICAgZHJpdmVy cy9ncHUvZHJtL3JvY2tjaGlwL01ha2VmaWxlICAgICAgICAgICAgICAgICAgfCAgICAxICsKPj4g ICBkcml2ZXJzL2dwdS9kcm0vcm9ja2NoaXAvZHctbWlwaS1kc2kuYyAgICAgICAgICAgICB8IDEy MDAKPj4gKysrKysrKysrKysrKysrKysrKysgZHJpdmVycy9ncHUvZHJtL3JvY2tjaGlwL3JvY2tj aGlwX2RybV92b3AuYyAgICAgICAgfAo+PiAgIDggKwo+PiAgIGluY2x1ZGUvZHJtL2RybV9taXBp X2RzaS5oICAgICAgICAgICAgICAgICAgICAgICAgIHwgICAxNCArCj4+ICAgOCBmaWxlcyBjaGFu Z2VkLCAxMzUxIGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkKPj4gICBjcmVhdGUgbW9kZSAx MDA2NDQKPj4gRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL2Rpc3BsYXkvcm9ja2No aXAvZHdfbWlwaV9kc2lfcm9ja2NoaXAudHh0Cj4+IGNyZWF0ZSBtb2RlIDEwMDY0NCBkcml2ZXJz L2dwdS9kcm0vcm9ja2NoaXAvZHctbWlwaS1kc2kuYwo+Cj4KPgoKCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJp LWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3Jn L21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: zyw@rock-chips.com (Chris Zhong) Date: Fri, 18 Dec 2015 17:54:03 +0800 Subject: [PATCH v6 0/6] Add mipi dsi support for rk3288 In-Reply-To: <3523259.ZRgH1Shd9Y@diego> References: <1450260616-21160-1-git-send-email-zyw@rock-chips.com> <3523259.ZRgH1Shd9Y@diego> Message-ID: <5673D7BB.50000@rock-chips.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Heiko Thanks for your reminder. I have post the v6.1 mipi patch with the atomic support. On 12/17/2015 05:29 PM, Heiko St?bner wrote: > Hi Chris, > > Am Mittwoch, 16. Dezember 2015, 18:10:10 schrieb Chris Zhong: >> The rk3288 MIPI DSI is a Synopsys DesignWare MIPI DSI host controller >> IP. This series adds support for a Synopsys DesignWare MIPI DSI host >> controller DRM driver. >> >> The MIPI DSI feature is tested on rk3288 evb board, backport them to >> chrome os kernel chrome_v3.14, and it can display normally. >> >> This patchset is base on the patchset from Ying.liu at freescale.com. >> >> >> According to the suggestion from Thierry, I have get rid of the bridge, >> and register the encoder & connecter in drm/rockchip/dw-mipi-dsi.c. > from my point it looks good (although I cannot really speak on the drm-related > internals). > > But I do think we'll be doing atomic modesetting conversion first (last > version posted from Mark today), so you should probably make sure your dsi > driver still works after that conversion and make changes if needed. > > > Heiko > >> >> Changes in v6: >> - update the document, since the bridge device has been deleted. >> - Do not use bridge driver (Thierry Reding) >> - Optimization the phy init sequence >> >> Changes in v5: >> - modify the clk name to SCLK_MIPIDSI_24M >> - add a blank line befor lcd_en >> >> Changes in v4: >> - use clk_round_rate to check the clock rate in vop_crtc_mode_fixup >> >> Changes in v3: >> - move dw_mipi_dsi_rockchip.txt to bindings/display/rockchip/ >> >> Chris Zhong (5): >> drm/rockchip: return a true clock rate to adjusted_mode >> Documentation: dt-bindings: Add bindings for rk3288 DW MIPI DSI driver >> drm: rockchip: Support Synopsys DW MIPI DSI >> ARM: dts: rockchip: add rk3288 mipi_dsi nodes >> ARM: dts: rockchip: add support mipi panel tv080wum-nl0 >> >> Liu Ying (1): >> drm/dsi: Add a helper to get bits per pixel of MIPI DSI pixel format >> >> .../display/rockchip/dw_mipi_dsi_rockchip.txt | 60 + >> arch/arm/boot/dts/rk3288-evb.dtsi | 20 +- >> arch/arm/boot/dts/rk3288.dtsi | 39 + >> drivers/gpu/drm/rockchip/Kconfig | 10 + >> drivers/gpu/drm/rockchip/Makefile | 1 + >> drivers/gpu/drm/rockchip/dw-mipi-dsi.c | 1200 >> ++++++++++++++++++++ drivers/gpu/drm/rockchip/rockchip_drm_vop.c | >> 8 + >> include/drm/drm_mipi_dsi.h | 14 + >> 8 files changed, 1351 insertions(+), 1 deletion(-) >> create mode 100644 >> Documentation/devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip.txt >> create mode 100644 drivers/gpu/drm/rockchip/dw-mipi-dsi.c > > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752459AbbLRJyd (ORCPT ); Fri, 18 Dec 2015 04:54:33 -0500 Received: from regular1.263xmail.com ([211.150.99.130]:50491 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751009AbbLRJy3 (ORCPT ); Fri, 18 Dec 2015 04:54:29 -0500 X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 X-RL-SENDER: zyw@rock-chips.com X-FST-TO: linux-arm-kernel@lists.infradead.org X-SENDER-IP: 103.29.142.67 X-LOGIN-NAME: zyw@rock-chips.com X-UNIQUE-TAG: <755eab05db21d6a520e1518ac523e148> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH v6 0/6] Add mipi dsi support for rk3288 To: =?UTF-8?Q?Heiko_St=c3=bcbner?= References: <1450260616-21160-1-git-send-email-zyw@rock-chips.com> <3523259.ZRgH1Shd9Y@diego> Cc: linux-rockchip@lists.infradead.org, mark.yao@rock-chips.com, treding@nvidia.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Kumar Gala , Ian Campbell , Rob Herring , David Airlie , Pawel Moll , Mark Rutland , Russell King , linux-arm-kernel@lists.infradead.org From: Chris Zhong Message-ID: <5673D7BB.50000@rock-chips.com> Date: Fri, 18 Dec 2015 17:54:03 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <3523259.ZRgH1Shd9Y@diego> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Heiko Thanks for your reminder. I have post the v6.1 mipi patch with the atomic support. On 12/17/2015 05:29 PM, Heiko Stübner wrote: > Hi Chris, > > Am Mittwoch, 16. Dezember 2015, 18:10:10 schrieb Chris Zhong: >> The rk3288 MIPI DSI is a Synopsys DesignWare MIPI DSI host controller >> IP. This series adds support for a Synopsys DesignWare MIPI DSI host >> controller DRM driver. >> >> The MIPI DSI feature is tested on rk3288 evb board, backport them to >> chrome os kernel chrome_v3.14, and it can display normally. >> >> This patchset is base on the patchset from Ying.liu@freescale.com. >> >> >> According to the suggestion from Thierry, I have get rid of the bridge, >> and register the encoder & connecter in drm/rockchip/dw-mipi-dsi.c. > from my point it looks good (although I cannot really speak on the drm-related > internals). > > But I do think we'll be doing atomic modesetting conversion first (last > version posted from Mark today), so you should probably make sure your dsi > driver still works after that conversion and make changes if needed. > > > Heiko > >> >> Changes in v6: >> - update the document, since the bridge device has been deleted. >> - Do not use bridge driver (Thierry Reding) >> - Optimization the phy init sequence >> >> Changes in v5: >> - modify the clk name to SCLK_MIPIDSI_24M >> - add a blank line befor lcd_en >> >> Changes in v4: >> - use clk_round_rate to check the clock rate in vop_crtc_mode_fixup >> >> Changes in v3: >> - move dw_mipi_dsi_rockchip.txt to bindings/display/rockchip/ >> >> Chris Zhong (5): >> drm/rockchip: return a true clock rate to adjusted_mode >> Documentation: dt-bindings: Add bindings for rk3288 DW MIPI DSI driver >> drm: rockchip: Support Synopsys DW MIPI DSI >> ARM: dts: rockchip: add rk3288 mipi_dsi nodes >> ARM: dts: rockchip: add support mipi panel tv080wum-nl0 >> >> Liu Ying (1): >> drm/dsi: Add a helper to get bits per pixel of MIPI DSI pixel format >> >> .../display/rockchip/dw_mipi_dsi_rockchip.txt | 60 + >> arch/arm/boot/dts/rk3288-evb.dtsi | 20 +- >> arch/arm/boot/dts/rk3288.dtsi | 39 + >> drivers/gpu/drm/rockchip/Kconfig | 10 + >> drivers/gpu/drm/rockchip/Makefile | 1 + >> drivers/gpu/drm/rockchip/dw-mipi-dsi.c | 1200 >> ++++++++++++++++++++ drivers/gpu/drm/rockchip/rockchip_drm_vop.c | >> 8 + >> include/drm/drm_mipi_dsi.h | 14 + >> 8 files changed, 1351 insertions(+), 1 deletion(-) >> create mode 100644 >> Documentation/devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip.txt >> create mode 100644 drivers/gpu/drm/rockchip/dw-mipi-dsi.c > > >