From mboxrd@z Thu Jan 1 00:00:00 1970 From: George Dunlap Subject: Re: [V3 PATCH 7/9] x86/hvm: pkeys, add pkeys support for guest_walk_tables Date: Fri, 18 Dec 2015 10:03:32 +0000 Message-ID: <5673D9F4.5050400@citrix.com> References: <1449479780-19146-1-git-send-email-huaitong.han@intel.com> <1449479780-19146-8-git-send-email-huaitong.han@intel.com> <5669C23F.6080203@citrix.com> <567184FF.9030702@citrix.com> <1450426913.4557.20.camel@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1450426913.4557.20.camel@intel.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: "Han, Huaitong" , "Wu, Feng" Cc: "tim@xen.org" , "Tian, Kevin" , "wei.liu2@citrix.com" , "ian.campbell@citrix.com" , "stefano.stabellini@eu.citrix.com" , "george.dunlap@eu.citrix.com" , "andrew.cooper3@citrix.com" , "Dong, Eddie" , "xen-devel@lists.xen.org" , "jbeulich@suse.com" , "Nakajima, Jun" , "keir@xen.org" , "ian.jackson@eu.citrix.com" List-Id: xen-devel@lists.xenproject.org T24gMTgvMTIvMTUgMDg6MjEsIEhhbiwgSHVhaXRvbmcgd3JvdGU6Cj4gT24gV2VkLCAyMDE1LTEy LTE2IGF0IDE1OjM2ICswMDAwLCBHZW9yZ2UgRHVubGFwIHdyb3RlOgo+PiBbQWRkaW5nIFRpbSwg dGhlIHByZXZpb3VzIG1tIG1haW50YWluZXJdCj4+Cj4+IE9uIDExLzEyLzE1IDA5OjE2LCBXdSwg RmVuZyB3cm90ZToKPj4+Pj4gK3sKPj4+Pj4gKyAgICB2b2lkICp4c2F2ZV9hZGRyOwo+Pj4+PiAr ICAgIHVuc2lnbmVkIGludCBwa3J1ID0gMDsKPj4+Pj4gKyAgICBib29sX3QgcGtydV9hZCwgcGty dV93ZDsKPj4+Pj4gKwo+Pj4+PiArICAgIGJvb2xfdCB1ZiA9ICEhKHBmZWMgJiBQRkVDX3VzZXJf bW9kZSk7Cj4+Pj4+ICsgICAgYm9vbF90IHdmID0gISEocGZlYyAmIFBGRUNfd3JpdGVfYWNjZXNz KTsKPj4+Pj4gKyAgICBib29sX3QgZmYgPSAhIShwZmVjICYgUEZFQ19pbnNuX2ZldGNoKTsKPj4+ Pj4gKyAgICBib29sX3QgcnN2ZGYgPSAhIShwZmVjICYgUEZFQ19yZXNlcnZlZF9iaXQpOwo+Pj4+ PiArICAgIGJvb2xfdCBwa3VmICA9ICEhKHBmZWMgJiBQRkVDX3Byb3Rfa2V5KTsKPj4+Pgo+Pj4+ IFNvIEknbSBqdXN0IHdvbmRlcmluZyBvdXQgbG91ZCBoZXJlIC0tIGlzIHRoZXJlIGFjdHVhbGx5 IGFueQo+Pj4+IHNpdHVhdGlvbgo+Pj4+IGluIHdoaWNoIHdlIHdvdWxkIHdhbnQgZ3Vlc3Rfd2Fs a190YWJsZXMgdG8gYWN0IGRpZmZlcmVudGx5IHRoYW4KPj4+PiB0aGUKPj4+PiByZWFsIGhhcmR3 YXJlPwo+Pj4+Cj4+Pj4gVGhhdCBpcywgaXMgdGhlcmUgYWN0dWFsbHkgYW55IHNpdHVhdGlvbiB3 aGVyZSwgcGt1IGlzIGVuYWJsZWQsCj4+Pj4gdGhlIHZjcHUKPj4+PiBpcyBpbiBsb25nIG1vZGUs IFBGRUNfd3JpdGVfYWNjZXNzIGFuZC9vciBQRkVDX3BhZ2VfcHJlc2VudCBpcwo+Pj4+IHNldCwg YW5kCj4+Pj4gdGhlIHBrZXkgaXMgbm9uLXplcm8sIHRoYXQgd2Ugd2FudCBndWVzdF93YWxrX3Rh YmxlcygpIHRvIG9ubHkKPj4+PiBjaGVjayB0aGUKPj4+PiB3cml0ZS1wcm90ZWN0IGJpdCBmb3Ig dGhlIHB0ZSwgYW5kIG5vdCBhbHNvIGNoZWNrIHRoZSBwa3J1Pwo+Pj4+Cj4+Pj4gQmVjYXVzZSBp ZiBub3QsIGl0IHNlZW1zIGxpa2UgaXQgd291bGQgYmUgbXVjaCBtb3JlIHJvYnVzdCB0bwo+Pj4+ IHNpbXBseQo+Pj4+ICphbHdheXMqIGNoZWNrIGZvciBwa3J1X2FkIGlmIFBGRUNfcGFnZV9wcmVz ZW50IGlzIHNldCwgYW5kIGZvcgo+Pj4+IHBrcnVfd2QKPj4+PiBpZiBQRkVDX3dyaXRlX2FjY2Vz cyBpcyBzZXQuCj4+Pgo+Pj4gZ3Vlc3Rfd2Fsa190YWJsZXMoKSBpcyBhbHNvIHVzZWQgYnkgc2hh ZG93IGNvZGUsIHRob3VnaCB3ZSBkb24ndAo+Pj4gcGxhbiB0byBzdXBwb3J0IHBrZXlzIGZvciBz aGFkb3cgbm93LCBob3dldmVyLCBpbiB0aGF0IGNhc2UsIHRoZQo+Pj4gJ3BmZWMnCj4+PiBpcyBn ZW5lcmF0ZWQgYnkgaGFyZHdhcmUsIGFuZCB0aGUgcGt1ZiBiaXQgbWF5IGJlIDAgb3IgMSBkZXBl bmRpbmcKPj4+IG9uIHRoZSByZWFsIHBhZ2UgZmF1bHQuIElmIHdlIHVuY29uZGl0aW9uYWxseSBj aGVjayBwa2V5cyBpbgo+Pj4gZ3Vlc3Rfd2Fsa190YWJsZXMoKSwgaXQgaXMgbm90IGEgZ29vZCBp ZGVhcyBmb3Igc29tZW9uZSB3aG8gbWF5Cj4+PiB3YW50IHRvIGltcGxlbWVudCB0aGUgcGtleXMg Zm9yIHNoYWRvdyBpbiBmdXR1cmUsIHNpbmNlIHdlIG9ubHkKPj4+IG5lZWQgdG8gY2hlY2sgcGtl eXMgd2hlbiB0aGUgcGt1ZiBpcyBzZXQgaW4gcGZlYy4KPj4KPj4gU28geW91J2xsIGhhdmUgdG8g Zm9yZ2l2ZSBtZSBmb3IgYmVpbmcgYSBiaXQgc2xvdyBoZXJlIC0tIEkgc3RlcHBlZAo+PiBhd2F5 Cj4+IGZyb20gdGhlIG1tIGNvZGUgZm9yIGEgd2hpbGUsIGFuZCBhIGxvdCBoYXMgY2hhbmdlZCBz aW5jZSBJIGFncmVlZCB0bwo+PiBiZWNvbWUgbW0gbWFpbnRhaW5lciBlYXJsaWVyIHRoaXMgeWVh ci4KPj4KPj4gU28gaGVyZSBpcyB3aGF0IEkgc2VlIGluIHRoZSB0cmVlOyBwbGVhc2UgY29ycmVj dCBtZSBpZiBJIG1pc3NlZAo+PiBzb21ldGhpbmcgaW1wb3J0YW50Lgo+Pgo+PiBUaGUgZnVuY3Rp b24gZ3Vlc3Rfd2Fsa190YWJsZXMoKToKPj4gIDEuIEFjY2VwdHMgYSBwZmVjIGFyZ3VtZW50IHdo aWNoIGlzIG1lYW50IHRvIGRlc2NyaWJlIHRoZSAqYWNjZXNzCj4+IHR5cGUqCj4+IHRoYXQgaXMg aGFwcGVuaW5nCj4+ICAyLiBSZXR1cm5zIGEgdmFsdWUgd2l0aCB0aGUgIndyb25nIiBmbGFncyAo aS5lLiwgZmxhZ3Mgd2hpY2ggbmVlZGVkCj4+IHRvCj4+IGJlIHNldCB0aGF0IHdlcmUgbWlzc2lu Zywgb3IgZmxhZ3MgdGhhdCBuZWVkZWQgdG8gYmUgY2xlYXIgdGhhdCB3ZXJlCj4+IHNldCkuCj4+ ICAzLiBJdCBjaGVja3MgcmVzZXJ2ZWQgYml0cyBpbiB0aGUgcGFnZXRhYmxlIHJlZ2FyZGxlc3Mg b2Ygd2hldGhlcgo+PiBQRkVDX3Jlc2VydmVkX2JpdCBpcyBzZXQgaW4gdGhlIGNhbGxlciwgYW5k IHJldHVybnMKPj4gX1BBR0VfSU5WQUxJRF9CSVRTCj4+IGlmIHNvLgo+PiAgNC4gSWYgUEZFQ19p bnNuX2ZldGNoIGlzIHNldCwgaXQgd2lsbCBvbmx5IGNoZWNrIGZvciBueCBhbmQgc21lcCBpZgo+ PiB0aG9zZSBmZWF0dXJlcyBhcmUgZW5hYmxlZCBmb3IgdGhlIGd1ZXN0Lgo+Pgo+PiBUaGUgbWFp biBjYWxsZXJzIGFyZSB0aGUgdmFyaW91cyBndmFfdG9fZ2ZuKCksIHdoaWNoIGFjY2VwdCBhCj4+ ICpwb2ludGVyKgo+PiB0byBhIHBmZWMgYXJndW1lbnQuICBUaGlzIHBvaW50ZXIgaXMgYWN0dWFs bHkgYmlkaXJlY3Rpb25hbDogaXRzCj4+IHZhbHVlCj4+IHBhc3NlZCB0byBndWVzdF93YWxrX3Rh YmxlcygpIHRvIGRldGVybWluZSB3aGF0IGFjY2VzcyB0eXBlcyBhcmUKPj4gY2hlY2tlZDsgd2hh dCBpcyByZXR1cm5lZCBpcyBtZWFudCB0byBiZSBhIHBmZWMgdmFsdWUgd2hpY2ggY2FuIGJlCj4+ IHBhc3NlZCB0byBhIGd1ZXN0IGFzIHBhcnQgb2YgYSBmYXVsdCAoYW5kIGlzIGJ5IHNldmVyYWwg Y2FsbGVycykuIAo+PiAgQnV0Cj4+IGl0IG1heSBhbHNvIHJldHVybiB0aGUgWGVuLWludGVybmFs IGZsYWdzLCBQRkVDX3BhZ2Vfe3BhZ2VkLHNoYXJlZH0uCj4+IEFuZCwgaW1wb3J0YW50bHksIGl0 IG1vZGlmaWVzIHRoZSBwZmVjIHZhbHVlIGJhc2VkIG9uIHRoZSBiaXRzIHRoYXQKPj4gYXJlCj4+ IHJldHVybmVkIGZyb20gZ3Vlc3Rfd2Fsa190YWJsZXMoKTogSXQgd2lsbCBjbGVhciBQRkVDX3By ZXNlbnQgaWYKPj4gZ3Vlc3Rfd2Fsa190YWJsZXMoKSByZXR1cm5zIF9QQUdFX1BSRVNFTlQsIGFu ZCBpdCB3aWxsIHNldAo+PiBQRkVDX3Jlc2VydmVkX2JpdCBpZiBndWVzdF93YWxrX3RhYmxlcygp IHJldHVybnMgX1BBR0VfSU5WQUxJRF9CSVQuCj4+Cj4+IFRoZSBuZXh0IGxvZ2ljYWwgbGV2ZWwg dXAgYXJlIHRoZQo+PiBodm1fe2NvcHksZmV0Y2h9X3t0byxmcm9tfV9ndWVzdF92aXJ0KCksIHdo aWNoIGFsc28gdGFrZSBhIHBmZWMKPj4gYXJndW1lbnQ6IGJ1dCByZWFsbHkgdGhlIG9ubHkgcHVy cG9zZSBvZiB0aGUgcGZlYyBhcmd1bWVudCBpcyB0bwo+PiBhbGxvdwo+PiB0aGUgY2FsbGVyIHRv IGFkZCB0aGUgUEZFQ191c2VyX21vZGUgZmxhZzsgdGhlIG90aGVyIGFjY2Vzcy10eXBlCj4+IGZs YWdzCj4+IGFyZSBzZXQgYXV0b21hdGljYWxseSBieSB0aGUgZnVuY3Rpb25zIHRoZW1zZWx2ZXMg KGUuZy4sICJ0byIgc2V0cwo+PiBQRkVDX3dyaXRlX2FjY2VzcywgImZldGNoIiBzZXRzIFBGRUNf aW5zbl9mZXRjaCwgJmMpLiAgU2V2ZXJhbAo+PiBjYWxsZXJzCj4+IHNldCBQRkVDX3ByZXNlbnQg YXMgd2VsbCwgYnV0IGNhbGxlcnMgc2V0IGFueSBvdGhlciBiaXRzLgo+Pgo+PiAoaHZtX2ZldGNo X2Zyb21fZ3Vlc3RfdmlydCgpIHNlZW1zIHRvIG9ubHkgc2V0IFBGRUNfaW5zbl9mZXRjaCBpZiBu eAo+PiBvcgo+PiBzbWVwIGFyZSBlbmFibGVkIGluIHRoZSBndWVzdC4gIFRoaXMgc2VlbXMgaW5j b25zaXN0ZW50IHRvIG1lIHdpdGgKPj4gdGhlCj4+IHRyZWF0bWVudCBvZiBQRkVDX3Jlc2VydmVk X2JpdDogaXQgc2VlbXMgbGlrZQo+PiBodm1fZmV0Y2hfZnJvbV9ndWVzdF92aXJ0KCkgc2hvdWxk IGFsd2F5cyBwYXNzIGluIFBGRUNfaW5zbl9mZXRjaCwKPj4gcGFydGljdWxhcmx5IGFzIGd1ZXN0 X3dhbGtfdGFibGVzKCkgd2lsbCBhbHJlYWR5IGdhdGUgdGhlIGNoZWNrcwo+PiBiYXNlZAo+PiBv biB3aGV0aGVyIG54IG9yIHNtZXAgaXMgZW5hYmxlZCBpbiB0aGUgZ3Vlc3QuICBUaW0sIHlvdSBr bm93IG9mIGFueQo+PiByZWFzb24gZm9yIHRoaXM/KQo+Pgo+PiBTbyB0aGVyZSBzZWVtcyB0byBt ZSB0byBiZSBubyByZWFzb24gdG8gcGFzcyBQRkVDX3Byb3Rfa2V5IGludG8KPj4gZ3Vlc3Rfd2Fs a190YWJsZXMoKSBvciBndmFfdG9fZ2ZuKCkuICBUaGUgcGZlYyB2YWx1ZSBwYXNzZWQgKmludG8q Cj4+IHRob3NlCj4+IHNob3VsZCBzaW1wbHkgaW5kaWNhdGUgdGhlIHR5cGUgb2YgbWVtb3J5IGFj Y2VzcyBiZWluZyBkb25lOiBwcmVzZW50LAo+PiB3cml0ZSwgaW5zdHJ1Y3Rpb24gZmV0Y2gsIHVz ZXIuCj4+Cj4+IFdpdGggeW91ciBjdXJyZW50IHNlcmllcywgZ3Vlc3Rfd2Fsa190YWJsZXMoKSBh bHJlYWR5IGNoZWNrcyBmb3IKPj4gcGtleXMKPj4gYmVpbmcgZW5hYmxlZCBpbiB0aGUgZ3Vlc3Qg YmVmb3JlIGNoZWNraW5nIGZvciB0aGVtIGluIHRoZQo+PiBwYWdldGFibGVzLgo+PiBGb3Igc2hh ZG93IG1vZGUsIHRoZXNlIHdpbGwgYmUgZmFsc2UsIGFuZCBzbyBubyBjaGVja3Mgd2lsbCBiZSBk b25lLiAKPj4gIElmCj4+IGFueW9uZSBldmVyIGltcGxlbWVudHMgcGtleXMgZm9yIHNoYWRvdyBt b2RlLCB0aGVuIHRoZXNlIHdpbGwgYmUKPj4gZW5hYmxlZCwgYW5kIHRoZSBjaGVja3Mgd2lsbCBi ZSBkb25lLCB3aXRob3V0IGFueSBpbnRlcnZlbnRpb24gb24gdGhlCj4+IHBhcnQgb2YgdGhlIGNh bGxlci4KPiAKPiBJIGhhdmUgdW5kZXJzdG9vZCBpdCwgYnV0LCB0aGUgcHJvYmxlbSB3aXRoIHNo YWRvdyBtb2RlIGlzIHRoYXQgcGZlYwo+IG1heSBjb21lIGZyb20gcmVncy0+ZXJyb3JfY29kZe+8 iGhhcmR3YXJl77yJLCBqdXN0IGxpa2U6Cj4gcmMgPSBzaF93YWxrX2d1ZXN0X3RhYmxlcyh2LCB2 YSwgJmd3LCByZWdzLT5lcnJvcl9jb2RlKTsKPiBzbywgd2hlbiByZWdzLT5lcnJvcl9jb2RlIGRv ZXMgbm90IGhhdmUgUEZFQ19wcm90X2tleSwKPiBndWVzdF93YWxrX3RhYmxlcyBtYXkgc3RpbGwg Y2hlY2sgUEtFWSB3aGVuIGNvZGVzIGlzIHdyaXRlbiBhY2NvcmRpbmcKPiB0byB3aGF0IHlvdSBz YWlkLCBhbmQgaXQgbWF5YmUgcmV0dXJuIGEgZGlmZmVyZW50IHJlc3VsdC4KClVuZGVyIHdoYXQg c2l0dWF0aW9uIHdvdWxkIHRoZSAqaGFyZHdhcmUqIG5vdCBnZW5lcmF0ZSBQRkVDX3Byb3Rfa2V5 LApidXQgZ3Vlc3Rfd2Fsa190YWJsZXMoKSB3b3VsZCwgdW5kZXIgZXhhY3RseSB0aGUgc2FtZSBj b25kaXRpb25zLApnZW5lcmF0ZSBQRkVDX3Byb3Rfa2V5PyAgU2hvdWxkbid0IGd1ZXN0X3dhbGtf dGFibGVzKCkgYmUgbWFkZSB0byBiZWhhdmUKaWRlbnRpY2FsbHkgdG8gdGhlIGhhcmR3YXJlPwoK VGhlIG9ubHkgc2l0dWF0aW9uIHdoZXJlIHRoYXQgbWlnaHQgbGVnaXRpbWF0ZWx5IGhhcHBlbiBp cyB3aGVuIHRoZQpzaGFkb3cgcGFnZXRhYmxlcyBhbmQgdGhlIGd1ZXN0IHBhZ2V0YWJsZXMgZGl2 ZXJnZTsgZm9yIGluc3RhbmNlLCB3aGVuIGEKcGFnZSBoYWQgYmVlbiB3cml0ZS1wcm90ZWN0ZWQg YmVjYXVzZSBYZW4gdGhvdWdodCBpdCB3YXMgYSBwYWdldGFibGUuClRoZW4gdGhlIGd1ZXN0IHB0 ZSBtaWdodCBoYXZlIHdyaXRlIHBlcm1pc3Npb24sIGJ1dCB0aGUgcGtleSByZWFkLW9ubHkKcGVy bWlzc2lvbjsgYnV0IHRoZSBzaGFkb3cgcHRlIHdvdWxkIG5vdCBoYXZlIHdyaXRlIHBlcm1pc3Np b24uICBJbiB0aGF0CmNhc2UsIHRoZSBoYXJkd2FyZSBtaWdodCBnaXZlIFBGRUNfd3JpdGVfYWNj ZXNzIGJ1dCBub3QgUEZFQ19wcm90X2tleSwgSQpzdXBwb3NlIChoYXZlbid0IHJlYWQgdGhlIG1h bnVhbCB0byBiZSBzdXJlKTsgYnV0IGluIHRoYXQgY2FzZSwgd2UKKndhbnQqIGd1ZXN0X3dhbGtf dGFibGVzKCkgdG8gZGV0ZWN0IGFuZCBhZGQgUEZFQ19wcm90X2tleSwgZG9uJ3Qgd2U/CgogLUdl b3JnZQoKCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K WGVuLWRldmVsIG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwOi8vbGlz dHMueGVuLm9yZy94ZW4tZGV2ZWwK