Re: [xen-unstable test] 66454: regressions - FAIL

[Andrew Cooper <andrew.cooper3@citrix.com>]

On 18/12/15 11:02, Jan Beulich wrote:
>>>> On 18.12.15 at 09:03, <osstest-admin@xenproject.org> wrote:
>> flight 66454 xen-unstable real [real]
>> http://logs.test-lab.xenproject.org/osstest/logs/66454/ 
>>
>> Regressions :-(
>>
>> Tests which did not succeed and are blocking,
>> including tests which could not be run:
>>  build-i386                    5 xen-build                 fail REGR. vs. 66415
>>  build-i386-xsm                5 xen-build                 fail REGR. vs. 66415
> Doug,
>
> this needs fixing:
>
> ***
> *** Can't find default configuration "arch/x86/configs/x86_32_defconfig"!
> ***
> make[2]: Leaving directory `/home/osstest/build.66454.build-i386-xsm/xen/xen'
> make[1]: Leaving directory `/home/osstest/build.66454.build-i386-xsm/xen/xen'
> gcc  -O1 -fno-omit-frame-pointer -m32 -march=i686 -g -fno-strict-aliasing -std=gnu99 -Wall -Wstrict-prototypes -Wdeclaration-after-statement -Wno-unused-but-set-variable -Wno-unused-local-typedefs   -O0 -g3 -D__XEN_TOOLS__ -MMD -MF .xc_core.o.d -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -fno-optimize-sibling-calls -mno-tls-direct-seg-refs -D_GNU_SOURCE  -I../../xen/common/libelf -Werror -Wmissing-prototypes -I. -I./include -I/home/osstest/build.66454.build-i386-xsm/xen/tools/libxc/../../tools/include -pthread -include /home/osstest/build.66454.build-i386-xsm/xen/tools/libxc/../../tools/config.h  -c -o xc_core.o xc_core.c 
> make[2]: *** [defconfig] Error 1
> make[1]: *** [.config] Error 2
> make: *** [install-xen] Error 2
>
> Previously build attempts on ix86 resulted in no error, with just
>
> *** Xen x86/32 target no longer supported!

I realise this is a break from before and wants fixing on those grounds.

However, it is also wrong for OSSTest to be attempting to build a 32bit
hypervisor on any branch since 4.3.  It seems to me that there is a bug
there as well.

Independently of not falling over a missing defconfig, the following code

ifneq ($(XEN_TARGET_ARCH),x86_32)
        $(MAKE) -f Rules.mk _$@
else
        echo "*** Xen x86/32 target no longer supported!"
endif

Really needs to have an hard failure in it.  In fact, that is probably
the correct fix in this circumstance.

~Andrew