From: Bart Van Assche <bart.vanassche-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
To: Or Gerlitz <ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Sagi Grimberg <sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
Chuck Lever <chuck.lever-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>,
Anna Schumaker
<Anna.Schumaker-ZwjVKphTwtPQT0dZR+AlfA@public.gmane.org>,
santosh.shilimkar-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org
Subject: Re: [PATCH rdma-next V1 3/7] IB/ulps: Avoid calling ib_query_device
Date: Fri, 18 Dec 2015 15:10:15 +0100 [thread overview]
Message-ID: <567413C7.5040907@sandisk.com> (raw)
In-Reply-To: <1450429190-5898-4-git-send-email-ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
On 12/18/2015 09:59 AM, Or Gerlitz wrote:
> Instead, use the cached copy of the attributes present on the device.
>
> Signed-off-by: Or Gerlitz <ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> ---
> drivers/infiniband/ulp/ipoib/ipoib_cm.c | 19 ++++-------
> drivers/infiniband/ulp/ipoib/ipoib_ethtool.c | 14 +++------
> drivers/infiniband/ulp/ipoib/ipoib_main.c | 21 +------------
> drivers/infiniband/ulp/iser/iscsi_iser.c | 4 +--
> drivers/infiniband/ulp/iser/iscsi_iser.h | 2 --
> drivers/infiniband/ulp/iser/iser_memory.c | 9 +++---
> drivers/infiniband/ulp/iser/iser_verbs.c | 38 ++++++++++------------
> drivers/infiniband/ulp/isert/ib_isert.c | 47 +++++++++-------------------
> drivers/infiniband/ulp/isert/ib_isert.h | 1 -
> drivers/infiniband/ulp/srp/ib_srp.c | 32 ++++++-------------
> drivers/infiniband/ulp/srpt/ib_srpt.c | 15 ++++-----
> drivers/infiniband/ulp/srpt/ib_srpt.h | 3 --
> 12 files changed, 63 insertions(+), 142 deletions(-)
Shouldn't this patch be split per ULP driver to make review easier ?
If you have a look at the MAINTAINERS file then you will see that you
forgot to CC the SRP initiator maintainer.
Bart.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-12-18 14:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-18 8:59 [PATCH rdma-next V1 0/7] dev attr cleanup (less is more) Or Gerlitz
[not found] ` <1450429190-5898-1-git-send-email-ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2015-12-18 8:59 ` [PATCH rdma-next V1 1/7] IB/core: Save the device attributes on the device structure Or Gerlitz
2015-12-18 8:59 ` [PATCH rdma-next V1 2/7] IB/core: Avoid calling ib_query_device Or Gerlitz
2015-12-18 8:59 ` [PATCH rdma-next V1 3/7] IB/ulps: " Or Gerlitz
[not found] ` <1450429190-5898-4-git-send-email-ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2015-12-18 14:10 ` Bart Van Assche [this message]
[not found] ` <567413C7.5040907-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2015-12-20 16:58 ` Or Gerlitz
2015-12-18 8:59 ` [PATCH rdma-next V1 4/7] net/rds: " Or Gerlitz
2015-12-18 8:59 ` [PATCH rdma-next V1 5/7] xprtrdma: " Or Gerlitz
2015-12-18 8:59 ` [PATCH rdma-next V1 6/7] staging/o2iblnd: " Or Gerlitz
2015-12-18 8:59 ` [PATCH rdma-next V1 7/7] IB/core: Remove ib_query_device Or Gerlitz
2015-12-18 14:06 ` [PATCH rdma-next V1 0/7] dev attr cleanup (less is more) Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=567413C7.5040907@sandisk.com \
--to=bart.vanassche-xdaiopvojttbdgjk7y7tuq@public.gmane.org \
--cc=Anna.Schumaker-ZwjVKphTwtPQT0dZR+AlfA@public.gmane.org \
--cc=chuck.lever-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=santosh.shilimkar-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.