diff for duplicates of <567421FC.7080005@hurleysoftware.com> diff --git a/a/1.txt b/N1/1.txt index 79d8e1a..341cb62 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -2,8 +2,8 @@ Hi Anton, On 12/18/2015 04:32 AM, Andy Shevchenko wrote: > On Fri, 2015-12-18 at 12:22 +0100, Anton Wuerfel wrote: ->=20 ->=20 +> +> >> This comes with a slight change in behaviour as >> pr_debug is configurable via CONFIG_DYNAMIC_DEBUG, whereas >> printk(KERN_DEBUG ...) is not. @@ -23,25 +23,24 @@ Peter Hurley >> @@ -465,9 +465,9 @@ serial_pnp_probe(struct pnp_dev *dev, const >> struct pnp_device_id *dev_id) >> return -ENODEV; ->> =20 +>> >> #ifdef SERIAL_DEBUG_PNP >> - printk(KERN_DEBUG ->=20 +> > I think it's not okay. ->=20 -> The rationale to have printk(KERN_DEBUG =E2=80=A6) here is to allow a +> +> The rationale to have printk(KERN_DEBUG …) here is to allow a > compilation with support of those messages independently on > DYNAMIC_DEBUG. ->=20 -> If you want to switch to DYNAMIC_DEBUG you have to carefully check wh= -at +> +> If you want to switch to DYNAMIC_DEBUG you have to carefully check what > is done under SERIAL_DEBUG_PNP. ->=20 +> > git grep on current linux-next shows that SERIAL_DEBUG_PNP is an > orphan. ->=20 +> > So, I would suggest to remove #ifdef. ->=20 +> >> - "Setup PNP port: port %x, mem 0x%lx, irq %d, type >> %d\n", >> - uart.port.iobase, uart.port.mapbase, @@ -52,11 +51,10 @@ at >> + uart.port.irq, uart.port.iotype); >> #endif >> ->=20 ->=20 +> +> -- -To unsubscribe from this list: send the line "unsubscribe linux-parisc"= - in +To unsubscribe from this list: send the line "unsubscribe linux-parisc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/a/content_digest b/N1/content_digest index 637773f..a260faa 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -27,15 +27,15 @@ linux-kernel@vger.kernel.org linux-parisc@vger.kernel.org linux-kernel@i4.cs.fau.de - " Phillip Raffeck <phillip.raffe\0" + " Phillip Raffeck <phillip.raffe>\0" "\00:1\0" "b\0" "Hi Anton,\n" "\n" "On 12/18/2015 04:32 AM, Andy Shevchenko wrote:\n" "> On Fri, 2015-12-18 at 12:22 +0100, Anton Wuerfel wrote:\n" - ">=20\n" - ">=20\n" + "> \n" + "> \n" ">> This comes with a slight change in behaviour as\n" ">> pr_debug is configurable via CONFIG_DYNAMIC_DEBUG, whereas\n" ">> printk(KERN_DEBUG ...) is not.\n" @@ -55,25 +55,24 @@ ">> @@ -465,9 +465,9 @@ serial_pnp_probe(struct pnp_dev *dev, const\n" ">> struct pnp_device_id *dev_id)\n" ">> \t\treturn -ENODEV;\n" - ">> =20\n" + ">> \n" ">> #ifdef SERIAL_DEBUG_PNP\n" ">> -\tprintk(KERN_DEBUG\n" - ">=20\n" + "> \n" "> I think it's not okay.\n" - ">=20\n" - "> The rationale to have printk(KERN_DEBUG =E2=80=A6) here is to allow a\n" + "> \n" + "> The rationale to have printk(KERN_DEBUG \342\200\246) here is to allow a\n" "> compilation with support of those messages independently on\n" "> DYNAMIC_DEBUG.\n" - ">=20\n" - "> If you want to switch to DYNAMIC_DEBUG you have to carefully check wh=\n" - "at\n" + "> \n" + "> If you want to switch to DYNAMIC_DEBUG you have to carefully check what\n" "> is done under SERIAL_DEBUG_PNP.\n" - ">=20\n" + "> \n" "> git grep on current linux-next shows that SERIAL_DEBUG_PNP is an\n" "> orphan.\n" - ">=20\n" + "> \n" "> So, I would suggest to remove #ifdef.\n" - ">=20\n" + "> \n" ">> -\t\t\"Setup PNP port: port %x, mem 0x%lx, irq %d, type\n" ">> %d\\n\",\n" ">> -\t\t uart.port.iobase, uart.port.mapbase,\n" @@ -84,13 +83,12 @@ ">> +\t\t uart.port.irq, uart.port.iotype);\n" ">> #endif\n" ">>\n" - ">=20\n" - ">=20\n" + "> \n" + "> \n" "\n" "--\n" - "To unsubscribe from this list: send the line \"unsubscribe linux-parisc\"=\n" - " in\n" + "To unsubscribe from this list: send the line \"unsubscribe linux-parisc\" in\n" "the body of a message to majordomo@vger.kernel.org\n" More majordomo info at http://vger.kernel.org/majordomo-info.html -6825927ed1676feff25269adb08b2e64f5356dd32c003471d7a74766cc09c677 +a18205af9e51ceaf1d9acb31633db56740f6971af1df6c5d9a16fee29e18c6da
diff --git a/a/1.txt b/N2/1.txt index 79d8e1a..26ab0c9 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -2,8 +2,8 @@ Hi Anton, On 12/18/2015 04:32 AM, Andy Shevchenko wrote: > On Fri, 2015-12-18 at 12:22 +0100, Anton Wuerfel wrote: ->=20 ->=20 +> +> >> This comes with a slight change in behaviour as >> pr_debug is configurable via CONFIG_DYNAMIC_DEBUG, whereas >> printk(KERN_DEBUG ...) is not. @@ -23,25 +23,24 @@ Peter Hurley >> @@ -465,9 +465,9 @@ serial_pnp_probe(struct pnp_dev *dev, const >> struct pnp_device_id *dev_id) >> return -ENODEV; ->> =20 +>> >> #ifdef SERIAL_DEBUG_PNP >> - printk(KERN_DEBUG ->=20 +> > I think it's not okay. ->=20 -> The rationale to have printk(KERN_DEBUG =E2=80=A6) here is to allow a +> +> The rationale to have printk(KERN_DEBUG …) here is to allow a > compilation with support of those messages independently on > DYNAMIC_DEBUG. ->=20 -> If you want to switch to DYNAMIC_DEBUG you have to carefully check wh= -at +> +> If you want to switch to DYNAMIC_DEBUG you have to carefully check what > is done under SERIAL_DEBUG_PNP. ->=20 +> > git grep on current linux-next shows that SERIAL_DEBUG_PNP is an > orphan. ->=20 +> > So, I would suggest to remove #ifdef. ->=20 +> >> - "Setup PNP port: port %x, mem 0x%lx, irq %d, type >> %d\n", >> - uart.port.iobase, uart.port.mapbase, @@ -52,11 +51,5 @@ at >> + uart.port.irq, uart.port.iotype); >> #endif >> ->=20 ->=20 - --- -To unsubscribe from this list: send the line "unsubscribe linux-parisc"= - in -the body of a message to majordomo@vger.kernel.org -More majordomo info at http://vger.kernel.org/majordomo-info.html +> +> diff --git a/a/content_digest b/N2/content_digest index 637773f..92174d2 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -27,15 +27,15 @@ linux-kernel@vger.kernel.org linux-parisc@vger.kernel.org linux-kernel@i4.cs.fau.de - " Phillip Raffeck <phillip.raffe\0" + " Phillip Raffeck <phillip.raffeck@fau.de>\0" "\00:1\0" "b\0" "Hi Anton,\n" "\n" "On 12/18/2015 04:32 AM, Andy Shevchenko wrote:\n" "> On Fri, 2015-12-18 at 12:22 +0100, Anton Wuerfel wrote:\n" - ">=20\n" - ">=20\n" + "> \n" + "> \n" ">> This comes with a slight change in behaviour as\n" ">> pr_debug is configurable via CONFIG_DYNAMIC_DEBUG, whereas\n" ">> printk(KERN_DEBUG ...) is not.\n" @@ -55,25 +55,24 @@ ">> @@ -465,9 +465,9 @@ serial_pnp_probe(struct pnp_dev *dev, const\n" ">> struct pnp_device_id *dev_id)\n" ">> \t\treturn -ENODEV;\n" - ">> =20\n" + ">> \n" ">> #ifdef SERIAL_DEBUG_PNP\n" ">> -\tprintk(KERN_DEBUG\n" - ">=20\n" + "> \n" "> I think it's not okay.\n" - ">=20\n" - "> The rationale to have printk(KERN_DEBUG =E2=80=A6) here is to allow a\n" + "> \n" + "> The rationale to have printk(KERN_DEBUG \342\200\246) here is to allow a\n" "> compilation with support of those messages independently on\n" "> DYNAMIC_DEBUG.\n" - ">=20\n" - "> If you want to switch to DYNAMIC_DEBUG you have to carefully check wh=\n" - "at\n" + "> \n" + "> If you want to switch to DYNAMIC_DEBUG you have to carefully check what\n" "> is done under SERIAL_DEBUG_PNP.\n" - ">=20\n" + "> \n" "> git grep on current linux-next shows that SERIAL_DEBUG_PNP is an\n" "> orphan.\n" - ">=20\n" + "> \n" "> So, I would suggest to remove #ifdef.\n" - ">=20\n" + "> \n" ">> -\t\t\"Setup PNP port: port %x, mem 0x%lx, irq %d, type\n" ">> %d\\n\",\n" ">> -\t\t uart.port.iobase, uart.port.mapbase,\n" @@ -84,13 +83,7 @@ ">> +\t\t uart.port.irq, uart.port.iotype);\n" ">> #endif\n" ">>\n" - ">=20\n" - ">=20\n" - "\n" - "--\n" - "To unsubscribe from this list: send the line \"unsubscribe linux-parisc\"=\n" - " in\n" - "the body of a message to majordomo@vger.kernel.org\n" - More majordomo info at http://vger.kernel.org/majordomo-info.html + "> \n" + > -6825927ed1676feff25269adb08b2e64f5356dd32c003471d7a74766cc09c677 +5609f6ba41cddb52e7efb13d6444820372fff760325b674b3a184691a8fc433e
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.