From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH V2] x86/xsaves: get_xsave_addr,
 check xsave header and support uncompressed format
Date: Fri, 18 Dec 2015 15:13:09 +0000
Message-ID: <56742285.9040503@citrix.com>
References: <1450450983-6095-1-git-send-email-huaitong.han@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1450450983-6095-1-git-send-email-huaitong.han@intel.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Huaitong Han <huaitong.han@intel.com>, jbeulich@suse.com, keir@xen.org
Cc: shuai.ruan@linux.intel.com, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On 18/12/15 15:03, Huaitong Han wrote:
> The check needs to be against the xsave header in the area, rather than Xen's
> maximum xfeature_mask. A guest might easily have a smaller xcr0 than the
> maximum Xen is willing to allow, causing the pointer below to be bogus.
>
> The get_xsave_addr() is modified to support uncompressed xstate areas.
>
> Signed-off-by: Huaitong Han <huaitong.han@intel.com>

Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>