From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH v2] VMX: allocate APIC access page from domain heap Date: Fri, 18 Dec 2015 15:18:45 +0000 Message-ID: <567423D5.50408@citrix.com> References: <5673C8BB02000078000C0FEB@prv-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1a9wny-0006PC-Fr for xen-devel@lists.xenproject.org; Fri, 18 Dec 2015 15:18:50 +0000 In-Reply-To: <5673C8BB02000078000C0FEB@prv-mh.provo.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich , xen-devel Cc: Kevin Tian , Keir Fraser , Jun Nakajima List-Id: xen-devel@lists.xenproject.org On 18/12/15 07:50, Jan Beulich wrote: > ... since we don't need its virtual address anywhere (it's a > placeholder page only after all). For this to work (and possibly be > done elsewhere too) share_xen_page_with_guest() needs to mark pages > handed to it as Xen heap ones. > > To be on the safe side, also explicitly clear the page (not having done > so was okay due to the XSA-100 fix, but is still a latent bug since we > don't formally guarantee allocations to come out zeroed, and in fact > this property may disappear again as soon as the asynchronous runtime > scrubbing patches arrive). > > Signed-off-by: Jan Beulich > --- > v2: Introduce free_shared_domheap_page(). Thanks. This is much clearer. Reviewed-by: Andrew Cooper