Re: [Qemu-devel] [PATCH 00/10] iotests: Clean up "mv $TEST_IMG $TEST_IMG.XXX"

[Max Reitz <mreitz@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 2138 bytes --]

On 16.12.2015 10:54, Fam Zheng wrote:
> Commit 794d00f71d fixed two "mv" commands into the TEST_IMG override approach.
> There are still more occasions of "mv", this series fixes them.
> 
> The benefit is it drops the assumption that the created image is a single file,
> which is not true for VMDK or the coming QBM format.  On top of this, those
> formats can be added to these cases later.
> 
> The patches stems from QBM work, but I will also take a look at adding
> applicable VMDK subformats once merged.
> 
> Please review.

Patches 1 to 9:

Reviewed-by: Max Reitz <mreitz@redhat.com>

> 
> Fam
> 
> 
> Fam Zheng (10):
>   iotests: 018: Use TEST_IMG override instead of "mv"
>   iotests: 019: Use TEST_IMG override instead of "mv"
>   iotests: 020: Use TEST_IMG override instead of "mv"
>   iotests: 024: Use TEST_IMG override instead of "mv"
>   iotests: 028: Use TEST_IMG override instead of "mv"
>   iotests: 034: Use TEST_IMG override instead of "mv"
>   iotests: 037: Use TEST_IMG override instead of "mv"
>   iotests: 038: Use TEST_IMG override instead of "mv"
>   iotests: 050: Use TEST_IMG override instead of "mv"
>   iotests: 095: Use TEST_IMG override instead of "mv"
> 
>  tests/qemu-iotests/018     |  8 ++++----
>  tests/qemu-iotests/018.out |  2 +-
>  tests/qemu-iotests/019     | 13 +++++++------
>  tests/qemu-iotests/019.out |  4 ++--
>  tests/qemu-iotests/020     |  7 +++++--
>  tests/qemu-iotests/020.out |  2 +-
>  tests/qemu-iotests/024     | 10 ++++++++--
>  tests/qemu-iotests/024.out |  4 ++--
>  tests/qemu-iotests/028     |  5 ++++-
>  tests/qemu-iotests/028.out |  2 +-
>  tests/qemu-iotests/034     |  6 +++++-
>  tests/qemu-iotests/034.out |  2 +-
>  tests/qemu-iotests/037     |  5 ++++-
>  tests/qemu-iotests/037.out |  2 +-
>  tests/qemu-iotests/038     |  5 ++++-
>  tests/qemu-iotests/038.out |  2 +-
>  tests/qemu-iotests/050     |  9 +++++++--
>  tests/qemu-iotests/050.out |  4 ++--
>  tests/qemu-iotests/095     | 12 ++++++------
>  tests/qemu-iotests/095.out |  8 ++++----
>  20 files changed, 70 insertions(+), 42 deletions(-)
> 



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]