From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41540)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <marcel@redhat.com>) id 1aA08C-0002CD-8U
	for qemu-devel@nongnu.org; Fri, 18 Dec 2015 13:51:58 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <marcel@redhat.com>) id 1aA086-000692-EJ
	for qemu-devel@nongnu.org; Fri, 18 Dec 2015 13:51:56 -0500
Received: from mx1.redhat.com ([209.132.183.28]:37512)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <marcel@redhat.com>) id 1aA086-00068L-65
	for qemu-devel@nongnu.org; Fri, 18 Dec 2015 13:51:50 -0500
Received: from int-mx11.intmail.prod.int.phx2.redhat.com
	(int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24])
	by mx1.redhat.com (Postfix) with ESMTPS id 03690C0A802A
	for <qemu-devel@nongnu.org>; Fri, 18 Dec 2015 18:51:48 +0000 (UTC)
References: <1449859353-1574-1-git-send-email-ehabkost@redhat.com>
	<1449859353-1574-8-git-send-email-ehabkost@redhat.com>
	<5670093A.1010600@redhat.com>
	<20151218180805.GW3774@thinpad.lan.raisama.net>
From: Marcel Apfelbaum <marcel@redhat.com>
Message-ID: <567455C1.70607@redhat.com>
Date: Fri, 18 Dec 2015 20:51:45 +0200
MIME-Version: 1.0
In-Reply-To: <20151218180805.GW3774@thinpad.lan.raisama.net>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 07/14] acpi: Remove guest_info
 parameters from functions
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: Igor Mammedov <imammedo@redhat.com>, Marcel Apfelbaum <marcel.a@redhat.com>, qemu-devel@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>

On 12/18/2015 08:08 PM, Eduardo Habkost wrote:
> On Tue, Dec 15, 2015 at 02:36:10PM +0200, Marcel Apfelbaum wrote:
>> On 12/11/2015 08:42 PM, Eduardo Habkost wrote:
>>> We can use PC_MACHINE(qdev_get_machine())->acpi_guest_info to get
>>> guest_info.
>>
>> Hi Eduardo,
>>
>> I like the idea of using qdev_get_machine() to get the machine instead of
>> keeping the reference around, however only in places we cannot get a reference
>> to it otherwise.
>
> I was unsure if I should go to the extreme of removing all the
> guest_info parameters, when doing that. I agree with your
> suggestions, but v3 will have to wait until I get back from
> vacations in Jan 18th. At least we will have less conflicts with
> Igor's AML series. :)

Sure, and have fun in your vacation! :)
Marcel

>
> Thanks!
>