From mboxrd@z Thu Jan 1 00:00:00 1970 From: Doug Goldstein Subject: Re: [PATCH] build: convert CONFIG_COMPAT to Kconfig Date: Fri, 18 Dec 2015 15:49:58 -0600 Message-ID: <56747F86.3030602@cardoe.com> References: <1450469218-24860-1-git-send-email-cardoe@cardoe.com> <56747C2C.5020408@citrix.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8600843566260129763==" Return-path: In-Reply-To: <56747C2C.5020408@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Andrew Cooper , xen-devel@lists.xen.org Cc: Keir Fraser , Jan Beulich List-Id: xen-devel@lists.xenproject.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============8600843566260129763== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="4Qr8jSDoiVf3MO3ucWbDl8JhWkHPgKG1K" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --4Qr8jSDoiVf3MO3ucWbDl8JhWkHPgKG1K Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 12/18/15 3:35 PM, Andrew Cooper wrote: > On 18/12/2015 20:06, Doug Goldstein wrote: >> Use the Kconfig generated CONFIG_COMPAT defines in the code base. >> >> CC: Keir Fraser >> CC: Jan Beulich >> CC: Andrew Cooper >> Signed-off-by: Doug Goldstein >=20 > Reviewed-by: Andrew Cooper , although I have= > a slight quibble. >=20 >> --- >> This was previously Acked-by: Jan Beulich but then= >> there was a request to change it to xen/common/Kconfig from >> xen/arch/x86/Kconfig. Unfortunately a small typo ('def_bool y' instead= of >> 'bool') caused it to break on ARM. This resolves the issue and should = be >> ready to merge. >> --- >> config/x86_64.mk | 1 - >> xen/arch/x86/Kconfig | 1 + >> xen/common/Kconfig | 7 +++++++ >> 3 files changed, 8 insertions(+), 1 deletion(-) >> >> diff --git a/config/x86_64.mk b/config/x86_64.mk >> index f12d549..85fa27c 100644 >> --- a/config/x86_64.mk >> +++ b/config/x86_64.mk >> @@ -2,7 +2,6 @@ CONFIG_X86 :=3D y >> CONFIG_X86_64 :=3D y >> CONFIG_X86_$(XEN_OS) :=3D y >> =20 >> -CONFIG_COMPAT :=3D y >> CONFIG_MIGRATE :=3D y >> CONFIG_XCUTILS :=3D y >> =20 >> diff --git a/xen/arch/x86/Kconfig b/xen/arch/x86/Kconfig >> index 07e366d..7d2ed96 100644 >> --- a/xen/arch/x86/Kconfig >> +++ b/xen/arch/x86/Kconfig >> @@ -3,6 +3,7 @@ config X86_64 >> =20 >> config X86 >> def_bool y >> + select COMPAT >> select HAS_ACPI >> select HAS_CPUFREQ >> select HAS_EHCI >> diff --git a/xen/common/Kconfig b/xen/common/Kconfig >> index 7d0e9a9..046e257 100644 >> --- a/xen/common/Kconfig >> +++ b/xen/common/Kconfig >> @@ -1,6 +1,13 @@ >> =20 >> menu "Common Features" >> =20 >> +config COMPAT >> + bool >> + help >> + 32-bit interface support on 64-bit Xen which is used for both >> + HVM and PV guests. HVMLoader makes 32-bit hypercalls irrespective >> + of the destination runmode of the guest. >=20 > As this is now common, probably want to specify x86 HVM and PV guests. = > Arm guests are technically HVM, although the term is rather less common= > on their side. >=20 > ~Andrew >=20 How about: 32-bit interface support on 64-bit Xen which is used by x86 HVM and PV guests and ARM HVM guests. The reason this is used for HVM guests is that HVMLoader makes 32-bit hypercalls irrespective of the destination run mode of the guest. --=20 Doug Goldstein --4Qr8jSDoiVf3MO3ucWbDl8JhWkHPgKG1K Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0 iQJ8BAEBCgBmBQJWdH+JXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRBNTM5MEQ2RTNFMTkyNzlCNzVDMzIwOTVB MkJDMDNEQzg3RUQxQkQ0AAoJEKK8A9yH7RvUqwYP/itTSbkL/pAoCZY5OCMFtyak t49AeeOGskQrI/KSuLmDZPCPOoG1kfZHVOlAMP6mg0K2Dd5oNpdzWEOvCzHhlEFT h2qaw8kvLM7b9F+uy18IO6afLK9eQsQL3g3e27JpHuvsFItci8mbHDVnp6DmkhyQ DQAPTjN2Uja6dF7r9o+5jxaTdLy/B7YZ13xXaExS95s+JhpjmO05p9DdO8kVX2VQ uVLic+lCVBLtsXTTkfnUw6gx89XRSF6tgctJ+9rwGi2fUeToh6ScRWfLYZocY0vb Z3KnUBikuVZk7ywRCp0LbftHkWLkH2U0bWxKMMkP51vkrMcBnPEkSveEsLmbBk1h EaZUWXq3OcNRkMZ9WYGejongGiDer6GCD76fBUBICE5HwmCn9m6kzl19uhAzmuy2 29mQnbe9zvdpOzk8eA2qMA/vAoGAHp8j5k6hy44pzyFf7hWv779hQRwD10nZim2C R/BwG4JbIb2vYGds9rL/tFLSwqSStKUBGgTOIruITVOPXFtk1Pnmzl18W0WSHTAy 3NKQhuAvE8OdTlSULyxRAGy4ZiS42G5fBhFuOu6jU/uaAnYKXwE3mAA9sWN5nuOe 3OWL4147n5WnYPEGLq5nHihrqltI4O9GsjMj3WrMLeDGZVuRoCx7Ag0yI5JYGQZ2 Vj/bAhnKk+kKRAWxKEjx =IOyE -----END PGP SIGNATURE----- --4Qr8jSDoiVf3MO3ucWbDl8JhWkHPgKG1K-- --===============8600843566260129763== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============8600843566260129763==--