From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Date: Sat, 19 Dec 2015 11:56:54 +0000 Subject: [PATCH] GPU-host1x: Use a signed return type for do_relocs() Message-Id: <56754606.6060201@users.sourceforge.net> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-tegra@vger.kernel.org, dri-devel@lists.freedesktop.org, =?UTF-8?Q?Terje_Bergstr=c3=b6m?= , Thierry Reding Cc: Julia Lawall , kernel-janitors@vger.kernel.org, LKML From: Markus Elfring Date: Sat, 19 Dec 2015 12:48:31 +0100 The return type "unsigned int" was used by the do_relocs() function despite of the aspect that it will eventually return a negative error code. Improve this implementation detail by deletion of the type qualifier then. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/gpu/host1x/job.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/host1x/job.c b/drivers/gpu/host1x/job.c index 63bd63f..1919aab 100644 --- a/drivers/gpu/host1x/job.c +++ b/drivers/gpu/host1x/job.c @@ -225,7 +225,7 @@ unpin: return 0; } -static unsigned int do_relocs(struct host1x_job *job, struct host1x_bo *cmdbuf) +static int do_relocs(struct host1x_job *job, struct host1x_bo *cmdbuf) { int i = 0; u32 last_page = ~0; -- 2.6.3 From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Subject: [PATCH] GPU-host1x: Use a signed return type for do_relocs() Date: Sat, 19 Dec 2015 12:56:54 +0100 Message-ID: <56754606.6060201@users.sourceforge.net> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: linux-tegra@vger.kernel.org, dri-devel@lists.freedesktop.org, =?UTF-8?Q?Terje_Bergstr=c3=b6m?= , Thierry Reding Cc: Julia Lawall , kernel-janitors@vger.kernel.org, LKML List-Id: linux-tegra@vger.kernel.org RnJvbTogTWFya3VzIEVsZnJpbmcgPGVsZnJpbmdAdXNlcnMuc291cmNlZm9yZ2UubmV0PgpEYXRl OiBTYXQsIDE5IERlYyAyMDE1IDEyOjQ4OjMxICswMTAwCgpUaGUgcmV0dXJuIHR5cGUgInVuc2ln bmVkIGludCIgd2FzIHVzZWQgYnkgdGhlIGRvX3JlbG9jcygpIGZ1bmN0aW9uCmRlc3BpdGUgb2Yg dGhlIGFzcGVjdCB0aGF0IGl0IHdpbGwgZXZlbnR1YWxseSByZXR1cm4gYSBuZWdhdGl2ZSBlcnJv ciBjb2RlLgpJbXByb3ZlIHRoaXMgaW1wbGVtZW50YXRpb24gZGV0YWlsIGJ5IGRlbGV0aW9uIG9m IHRoZSB0eXBlIHF1YWxpZmllciB0aGVuLgoKVGhpcyBpc3N1ZSB3YXMgZGV0ZWN0ZWQgYnkgdXNp bmcgdGhlIENvY2NpbmVsbGUgc29mdHdhcmUuCgpTaWduZWQtb2ZmLWJ5OiBNYXJrdXMgRWxmcmlu ZyA8ZWxmcmluZ0B1c2Vycy5zb3VyY2Vmb3JnZS5uZXQ+Ci0tLQogZHJpdmVycy9ncHUvaG9zdDF4 L2pvYi5jIHwgMiArLQogMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAxIGRlbGV0aW9u KC0pCgpkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvaG9zdDF4L2pvYi5jIGIvZHJpdmVycy9ncHUv aG9zdDF4L2pvYi5jCmluZGV4IDYzYmQ2M2YuLjE5MTlhYWIgMTAwNjQ0Ci0tLSBhL2RyaXZlcnMv Z3B1L2hvc3QxeC9qb2IuYworKysgYi9kcml2ZXJzL2dwdS9ob3N0MXgvam9iLmMKQEAgLTIyNSw3 ICsyMjUsNyBAQCB1bnBpbjoKIAlyZXR1cm4gMDsKIH0KIAotc3RhdGljIHVuc2lnbmVkIGludCBk b19yZWxvY3Moc3RydWN0IGhvc3QxeF9qb2IgKmpvYiwgc3RydWN0IGhvc3QxeF9ibyAqY21kYnVm KQorc3RhdGljIGludCBkb19yZWxvY3Moc3RydWN0IGhvc3QxeF9qb2IgKmpvYiwgc3RydWN0IGhv c3QxeF9ibyAqY21kYnVmKQogewogCWludCBpID0gMDsKIAl1MzIgbGFzdF9wYWdlID0gfjA7Ci0t IAoyLjYuMwoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K ZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0 dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933130AbbLSL5M (ORCPT ); Sat, 19 Dec 2015 06:57:12 -0500 Received: from mout.web.de ([212.227.17.12]:56638 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932252AbbLSL5K (ORCPT ); Sat, 19 Dec 2015 06:57:10 -0500 To: linux-tegra@vger.kernel.org, dri-devel@lists.freedesktop.org, =?UTF-8?Q?Terje_Bergstr=c3=b6m?= , Thierry Reding Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall From: SF Markus Elfring Subject: [PATCH] GPU-host1x: Use a signed return type for do_relocs() Message-ID: <56754606.6060201@users.sourceforge.net> Date: Sat, 19 Dec 2015 12:56:54 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:vSSsmrewTuIfwriNdgXlQthZr71/0t/yXYxL48Qv6KkIY/wr8ZB oTTORKxardd+8VAvKaWprMtXoU/QVjnCdfJmUNQN4wr6nSsq5O43BGIWz1n/20LMj1hRWyn qpXLakA9GgWBhcm+lTIHVsbh3lI1hGDzeatDNEwlqIbk39P/v4o9cVUgNDNyhlzNiXLtvm8 UAHe9HhkTjvlbqjbenclw== X-UI-Out-Filterresults: notjunk:1;V01:K0:sMGivfOasGg=:hrY/xZZ18FIpnmEVu5IWld 3FkteLt0JiBiV0H/CSAnlQJDocq+COprHZnUqfOzpouwrW6khgog1vAJ6/nzPGrZmyRM1jdND 7pQwebLkzIOze0Ge8na7ho7j9dJpO615Q55CjzROfT+PUubfH5AvexR+9VHc6JBfx3tfIFKQk FaLi2AVWNynr8AOoNO0hH2h/UmeD88rSKCSmAPJcWhvRo8QmUrUqUQnOrPYJrzTgfJpSTy3MI 4uPs5Z5XwUJbZnIDUzb9XkpVg59m5ms1rBloWfAbOWw+Gzg8skLYbMu+sFXudOZuSd6umUkfj 0aH+pFyWmP8RniavEziVyM9zW61RLsVGv3ND5FZw1QhQ6gOL5icbeNR1du3evvOJM8sjUPaie +jo9c+t1F582L2Aq7DHbPw/iiWspXcSLS3et3YE8Ocp+9+DIF+RI9yjPnPv57Yi7tIugUE4iA kPGLd5a/dDlmEbTOjf8uZKTYzx2RyysTDHMawCJMmb9PYumdn/0lG1Ljvbb9QCRYersLujHHf raVoZ+QA8bFJ+++zE6bC44vSsNjDKpIVXus+wMBzKfcoNw+c1uwhHX715AyebtibXZUqdE/DZ DSQZUU/HTVZxIgqhOcarbcrvZyCTMIoBmq/EG7feNhl0b9MgIky8JccCHsDtQus91GXTU+ILr /JFz/N8FmDlbYWegEozbe5PMYWHZO/ACSDR4Tv3wSs27ihHMMGEvjKu90Xksh88Ic2K3GuXv4 voRnUWz/79un2LI1U6RXNmvkbXSfPNtbGgVac14OQoyHpA/y5YseNrz6m4wZSI79+RcIjbWas x+sv4lA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Sat, 19 Dec 2015 12:48:31 +0100 The return type "unsigned int" was used by the do_relocs() function despite of the aspect that it will eventually return a negative error code. Improve this implementation detail by deletion of the type qualifier then. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/gpu/host1x/job.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/host1x/job.c b/drivers/gpu/host1x/job.c index 63bd63f..1919aab 100644 --- a/drivers/gpu/host1x/job.c +++ b/drivers/gpu/host1x/job.c @@ -225,7 +225,7 @@ unpin: return 0; } -static unsigned int do_relocs(struct host1x_job *job, struct host1x_bo *cmdbuf) +static int do_relocs(struct host1x_job *job, struct host1x_bo *cmdbuf) { int i = 0; u32 last_page = ~0; -- 2.6.3