From: SF Markus Elfring <elfring@users.sourceforge.net>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: linux-gpio@vger.kernel.org,
Linus Walleij <linus.walleij@linaro.org>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org,
Julia Lawall <julia.lawall@lip6.fr>
Subject: Re: pinctrl-adi2: Use a signed return type for adi_gpio_irq_startup()
Date: Sat, 19 Dec 2015 22:20:33 +0000 [thread overview]
Message-ID: <5675D831.2070307@users.sourceforge.net> (raw)
In-Reply-To: <20151219204501.GV5284@mwanda>
>>> This introduces a compile warning.
>>
>> How do you think about to show the exact message you get?
>
> I can't actually compile it myself.
It seems that I can understand your feedback also a bit better
since I received the information from a background process
like "kbuild test robot".
Will it become acceptable to adjust the data structure "irq_chip"
for the variable "adi_gpio_irqchip"?
Should I just skip my update suggestion for this specific source
code area?
http://lxr.free-electrons.com/source/include/linux/irq.h?v=4.3#L320
Regards,
Markus
WARNING: multiple messages have this Message-ID (diff)
From: SF Markus Elfring <elfring@users.sourceforge.net>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: linux-gpio@vger.kernel.org,
Linus Walleij <linus.walleij@linaro.org>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org,
Julia Lawall <julia.lawall@lip6.fr>
Subject: Re: pinctrl-adi2: Use a signed return type for adi_gpio_irq_startup()
Date: Sat, 19 Dec 2015 23:20:33 +0100 [thread overview]
Message-ID: <5675D831.2070307@users.sourceforge.net> (raw)
In-Reply-To: <20151219204501.GV5284@mwanda>
>>> This introduces a compile warning.
>>
>> How do you think about to show the exact message you get?
>
> I can't actually compile it myself.
It seems that I can understand your feedback also a bit better
since I received the information from a background process
like "kbuild test robot".
Will it become acceptable to adjust the data structure "irq_chip"
for the variable "adi_gpio_irqchip"?
Should I just skip my update suggestion for this specific source
code area?
http://lxr.free-electrons.com/source/include/linux/irq.h?v=4.3#L320
Regards,
Markus
next prev parent reply other threads:[~2015-12-19 22:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-19 17:00 [PATCH] pinctrl-adi2: Use a signed return type for adi_gpio_irq_startup() SF Markus Elfring
2015-12-19 17:00 ` SF Markus Elfring
2015-12-19 20:12 ` Dan Carpenter
2015-12-19 20:12 ` Dan Carpenter
2015-12-19 20:40 ` SF Markus Elfring
2015-12-19 20:40 ` SF Markus Elfring
2015-12-19 20:45 ` Dan Carpenter
2015-12-19 20:45 ` Dan Carpenter
2015-12-19 22:20 ` SF Markus Elfring [this message]
2015-12-19 22:20 ` SF Markus Elfring
2015-12-19 21:54 ` [PATCH] " kbuild test robot
2015-12-19 21:54 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5675D831.2070307@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=dan.carpenter@oracle.com \
--cc=julia.lawall@lip6.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.