From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kishon Vijay Abraham I Subject: Re: [PATCH v3 7/8] clk: rockchip: fix usbphy-related clocks Date: Sun, 20 Dec 2015 14:39:15 +0530 Message-ID: <5676703B.90300@ti.com> References: <1447968149-10979-1-git-send-email-heiko@sntech.de> <1447968149-10979-8-git-send-email-heiko@sntech.de> <566FF0F0.6080803@ti.com> <80597401.Y78Rj8FshV@diego> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <80597401.Y78Rj8FshV@diego> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+glpar-linux-rockchip=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: =?UTF-8?Q?Heiko_St=c3=bcbner?= , mturquette-rdvid1DuHRBWk0Htik3J/w@public.gmane.org Cc: hl-TNX95d0MmH7DzftRWevZcw@public.gmane.org, arnd-r2nGTMty4D4@public.gmane.org, sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, romain.perier-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: linux-rockchip.vger.kernel.org Hi, On Saturday 19 December 2015 10:51 PM, Heiko St=FCbner wrote: > Hi Kishon, > = > Am Dienstag, 15. Dezember 2015, 16:22:32 schrieb Kishon Vijay Abraham I: >> On Friday 20 November 2015 02:52 AM, Heiko Stuebner wrote: >>> The otgphy clocks really only drive the phy blocks. These in turn >>> contain plls that then generate the 480m clocks the clock controller >>> uses to supply some other clocks like uart0, gpu or the video-codec. >>> >>> So fix this structure to actually respect that hirarchy and removed >>> that usb480m fixed-rate clock working as a placeholder till now, as >>> this wouldn't even work if the supplying phy gets turned off while >>> its pll-output gets used elsewhere. >>> >>> Signed-off-by: Heiko Stuebner >>> Reviewed-by: Douglas Anderson >> >> I saw you've given your Acked-by in a previous version of this patch. >> Do you want me to take this in linux-phy tree? > = > from my POV, this series should probably go through your tree in one go, = as = > this patch depends on the newly exposed clocks from the previous patch. S= o to = > keep bisectability, it should most likely stay together. I agree. But I can't take another subsystem patch without getting a clear n= od from the maintainer. I'll wait till tomorrow for Turquette to give his Acke= d-by. Thanks Kishon From mboxrd@z Thu Jan 1 00:00:00 1970 From: kishon@ti.com (Kishon Vijay Abraham I) Date: Sun, 20 Dec 2015 14:39:15 +0530 Subject: [PATCH v3 7/8] clk: rockchip: fix usbphy-related clocks In-Reply-To: <80597401.Y78Rj8FshV@diego> References: <1447968149-10979-1-git-send-email-heiko@sntech.de> <1447968149-10979-8-git-send-email-heiko@sntech.de> <566FF0F0.6080803@ti.com> <80597401.Y78Rj8FshV@diego> Message-ID: <5676703B.90300@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi, On Saturday 19 December 2015 10:51 PM, Heiko St?bner wrote: > Hi Kishon, > > Am Dienstag, 15. Dezember 2015, 16:22:32 schrieb Kishon Vijay Abraham I: >> On Friday 20 November 2015 02:52 AM, Heiko Stuebner wrote: >>> The otgphy clocks really only drive the phy blocks. These in turn >>> contain plls that then generate the 480m clocks the clock controller >>> uses to supply some other clocks like uart0, gpu or the video-codec. >>> >>> So fix this structure to actually respect that hirarchy and removed >>> that usb480m fixed-rate clock working as a placeholder till now, as >>> this wouldn't even work if the supplying phy gets turned off while >>> its pll-output gets used elsewhere. >>> >>> Signed-off-by: Heiko Stuebner >>> Reviewed-by: Douglas Anderson >> >> I saw you've given your Acked-by in a previous version of this patch. >> Do you want me to take this in linux-phy tree? > > from my POV, this series should probably go through your tree in one go, as > this patch depends on the newly exposed clocks from the previous patch. So to > keep bisectability, it should most likely stay together. I agree. But I can't take another subsystem patch without getting a clear nod from the maintainer. I'll wait till tomorrow for Turquette to give his Acked-by. Thanks Kishon From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754248AbbLTJKN (ORCPT ); Sun, 20 Dec 2015 04:10:13 -0500 Received: from comal.ext.ti.com ([198.47.26.152]:34944 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754212AbbLTJKD (ORCPT ); Sun, 20 Dec 2015 04:10:03 -0500 Subject: Re: [PATCH v3 7/8] clk: rockchip: fix usbphy-related clocks To: =?UTF-8?Q?Heiko_St=c3=bcbner?= , References: <1447968149-10979-1-git-send-email-heiko@sntech.de> <1447968149-10979-8-git-send-email-heiko@sntech.de> <566FF0F0.6080803@ti.com> <80597401.Y78Rj8FshV@diego> CC: , , , , , , , From: Kishon Vijay Abraham I Message-ID: <5676703B.90300@ti.com> Date: Sun, 20 Dec 2015 14:39:15 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <80597401.Y78Rj8FshV@diego> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Saturday 19 December 2015 10:51 PM, Heiko Stübner wrote: > Hi Kishon, > > Am Dienstag, 15. Dezember 2015, 16:22:32 schrieb Kishon Vijay Abraham I: >> On Friday 20 November 2015 02:52 AM, Heiko Stuebner wrote: >>> The otgphy clocks really only drive the phy blocks. These in turn >>> contain plls that then generate the 480m clocks the clock controller >>> uses to supply some other clocks like uart0, gpu or the video-codec. >>> >>> So fix this structure to actually respect that hirarchy and removed >>> that usb480m fixed-rate clock working as a placeholder till now, as >>> this wouldn't even work if the supplying phy gets turned off while >>> its pll-output gets used elsewhere. >>> >>> Signed-off-by: Heiko Stuebner >>> Reviewed-by: Douglas Anderson >> >> I saw you've given your Acked-by in a previous version of this patch. >> Do you want me to take this in linux-phy tree? > > from my POV, this series should probably go through your tree in one go, as > this patch depends on the newly exposed clocks from the previous patch. So to > keep bisectability, it should most likely stay together. I agree. But I can't take another subsystem patch without getting a clear nod from the maintainer. I'll wait till tomorrow for Turquette to give his Acked-by. Thanks Kishon