From mboxrd@z Thu Jan 1 00:00:00 1970 From: Doug Goldstein Subject: Re: [PATCH] build: convert CONFIG_COMPAT to Kconfig Date: Sun, 20 Dec 2015 07:42:15 -0600 Message-ID: <5676B037.1070405@cardoe.com> References: <1450469218-24860-1-git-send-email-cardoe@cardoe.com> <56747C2C.5020408@citrix.com> <56747F86.3030602@cardoe.com> <5674840E.4020101@citrix.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6953526200808015257==" Return-path: In-Reply-To: <5674840E.4020101@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Andrew Cooper , xen-devel@lists.xen.org Cc: Keir Fraser , Jan Beulich List-Id: xen-devel@lists.xenproject.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============6953526200808015257== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="bWFrIHVC5RTLD8HVumpXMxFxhwDdGhQbH" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --bWFrIHVC5RTLD8HVumpXMxFxhwDdGhQbH Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 12/18/15 4:09 PM, Andrew Cooper wrote: > On 18/12/2015 21:49, Doug Goldstein wrote: >> On 12/18/15 3:35 PM, Andrew Cooper wrote: >>> On 18/12/2015 20:06, Doug Goldstein wrote: >>>> Use the Kconfig generated CONFIG_COMPAT defines in the code base. >>>> >>>> CC: Keir Fraser >>>> CC: Jan Beulich >>>> CC: Andrew Cooper >>>> Signed-off-by: Doug Goldstein >>> Reviewed-by: Andrew Cooper , although I ha= ve >>> a slight quibble. >>> >>>> --- >>>> This was previously Acked-by: Jan Beulich but th= en >>>> there was a request to change it to xen/common/Kconfig from >>>> xen/arch/x86/Kconfig. Unfortunately a small typo ('def_bool y' inste= ad of >>>> 'bool') caused it to break on ARM. This resolves the issue and shoul= d be >>>> ready to merge. >>>> --- >>>> config/x86_64.mk | 1 - >>>> xen/arch/x86/Kconfig | 1 + >>>> xen/common/Kconfig | 7 +++++++ >>>> 3 files changed, 8 insertions(+), 1 deletion(-) >>>> >>>> diff --git a/config/x86_64.mk b/config/x86_64.mk >>>> index f12d549..85fa27c 100644 >>>> --- a/config/x86_64.mk >>>> +++ b/config/x86_64.mk >>>> @@ -2,7 +2,6 @@ CONFIG_X86 :=3D y >>>> CONFIG_X86_64 :=3D y >>>> CONFIG_X86_$(XEN_OS) :=3D y >>>> =20 >>>> -CONFIG_COMPAT :=3D y >>>> CONFIG_MIGRATE :=3D y >>>> CONFIG_XCUTILS :=3D y >>>> =20 >>>> diff --git a/xen/arch/x86/Kconfig b/xen/arch/x86/Kconfig >>>> index 07e366d..7d2ed96 100644 >>>> --- a/xen/arch/x86/Kconfig >>>> +++ b/xen/arch/x86/Kconfig >>>> @@ -3,6 +3,7 @@ config X86_64 >>>> =20 >>>> config X86 >>>> def_bool y >>>> + select COMPAT >>>> select HAS_ACPI >>>> select HAS_CPUFREQ >>>> select HAS_EHCI >>>> diff --git a/xen/common/Kconfig b/xen/common/Kconfig >>>> index 7d0e9a9..046e257 100644 >>>> --- a/xen/common/Kconfig >>>> +++ b/xen/common/Kconfig >>>> @@ -1,6 +1,13 @@ >>>> =20 >>>> menu "Common Features" >>>> =20 >>>> +config COMPAT >>>> + bool >>>> + help >>>> + 32-bit interface support on 64-bit Xen which is used for both >>>> + HVM and PV guests. HVMLoader makes 32-bit hypercalls irrespectiv= e >>>> + of the destination runmode of the guest. >>> As this is now common, probably want to specify x86 HVM and PV guests= =2E=20 >>> Arm guests are technically HVM, although the term is rather less comm= on >>> on their side. >>> >>> ~Andrew >>> >> How about: >> >> 32-bit interface support on 64-bit Xen which is used by x86 HVM and PV= >> guests and ARM HVM guests. The reason this is used for HVM guests is >> that HVMLoader makes 32-bit hypercalls irrespective of the destination= >> run mode of the guest. >> >=20 > The complication here is that arm doesn't yet support compat. There is= > a hope to (which is, I guess, why Jan asked for it to be common), but i= t > shouldn't give any implication that it is available on ARM yet. So maybe just drop the "and ARM HVM guests" part of that statement and when that gets added we can expand the language? >=20 > I am not overly familiar with the kconfig grammar. Is there a sensible= > way to limit the option to being visible only on x86, and only on 64bit= > builds? (even if arm supported compat, it wouldn't make sense to offer= > it to arm32). >=20 > Or am I just talking my way back around to suggesting that it be an arc= h > specific option? >=20 > ~Andrew >=20 Not necessarily. Currently its not visible to users at all and x86 just enables it. Should it be made to be visible we could keep it in the common place and add depends like "depends on X86_64" or "depends on 64BIT" (both x86_64 and arm64). --=20 Doug Goldstein --bWFrIHVC5RTLD8HVumpXMxFxhwDdGhQbH Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0 iQJ8BAEBCgBmBQJWdrA7XxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRBNTM5MEQ2RTNFMTkyNzlCNzVDMzIwOTVB MkJDMDNEQzg3RUQxQkQ0AAoJEKK8A9yH7RvU0KIP/jKjPzKCFe7rV1S9JF3z4zdU KhItCOBHhX3WLr83ss8qZFKJjLsgn1XLaTlG3mQmuHgsl2AS8I4QGV1gGtuDm3xj wQaF3nxsvMK2FR5CXIu9Tso16qYsexrTPdjxzcB5lhSFvqGbd91rqqrqoVEEEIgn 5ILYTjWTmyupQeMddENNmjZm+fSmV9oH/NLPjDy5jPJqUf74nSIxMg4SmbUQUemP qIeyptTyG5b84ELORB6PGe7M9MaPqMeNk7EQ8tr+Ktlsk0F1dFvs6j3rwLfHvjvv TKO8Da4NESgrafhwIE8BXh4z3oUnaqZJ6Cb9ccdiz/+58iv2/rzc8id975bugpWz DcUfEvB/yNqwJmxV3006ILfQT9rO4oD3W8Vy6zj2QBzqHl7hztv1EVFHrI/LLpXF RakGm+OU4pk2/vLGwZXVRdiORWztP2NP33xhnN5+oSXYLXE2d3YClrgPdGrK6G45 C1NVvjZu8UvekrKrK7CsZjshI6mDXLOYmZpK0kkyRZMjs3qJYzgOjMn9mzrSWjgY m3KrNUYNdMf3j1GmhrV6zSAa191h14Klowv0zReeXDIRgH7gtL8Gl9BO+ixX9quf TH9/ux5BA9Qa7WnPwNLA/l87da2TzCeToLQ4KZ7XKRVRn+q+TcE52pCzi0J2ICBs +VQX8S5Eh5R22F2DOcKL =FLt1 -----END PGP SIGNATURE----- --bWFrIHVC5RTLD8HVumpXMxFxhwDdGhQbH-- --===============6953526200808015257== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============6953526200808015257==--