From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Date: Sun, 20 Dec 2015 17:15:00 +0000 Subject: Re: [PATCH v5] extcon: add Maxim MAX3355 driver Message-Id: <5676E214.2040009@cogentembedded.com> List-Id: References: <5948633.my3nAG6hRz@wasted.cogentembedded.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: cw00.choi-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org Cc: Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , "myungjoo.ham-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org" , devicetree , linux-kernel , linux-sh-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Hello. On 12/20/2015 05:31 PM, Chanwoo Choi wrote: > This patch depend on GPIOLIB configuration as following: > I modified it with following diff and applied it. > > diff --git a/drivers/extcon/Kconfig b/drivers/extcon/Kconfig > index ba4db7d..3d89e60 100644 > --- a/drivers/extcon/Kconfig > +++ b/drivers/extcon/Kconfig > @@ -54,6 +54,7 @@ config EXTCON_MAX14577 > > config EXTCON_MAX3355 > tristate "Maxim MAX3355 USB OTG EXTCON Support" > + depends on GPIOLIB || COMPILE_TEST If it won't compile w/o gpiolib, what's the use of COMIPLE_TEST? And no, it shouldn't depend on gpiolib. It has empty stubs for the case of CONFIG_GPIOLIB=n. Obviously something is wrong with the GPIO headers, I'll look into it. [...] > Thanks, > Chanwoo Choi MBR, Sergei From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH v5] extcon: add Maxim MAX3355 driver Date: Sun, 20 Dec 2015 20:15:00 +0300 Message-ID: <5676E214.2040009@cogentembedded.com> References: <5948633.my3nAG6hRz@wasted.cogentembedded.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: cw00.choi-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org Cc: Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , "myungjoo.ham-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org" , devicetree , linux-kernel , linux-sh-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org Hello. On 12/20/2015 05:31 PM, Chanwoo Choi wrote: > This patch depend on GPIOLIB configuration as following: > I modified it with following diff and applied it. > > diff --git a/drivers/extcon/Kconfig b/drivers/extcon/Kconfig > index ba4db7d..3d89e60 100644 > --- a/drivers/extcon/Kconfig > +++ b/drivers/extcon/Kconfig > @@ -54,6 +54,7 @@ config EXTCON_MAX14577 > > config EXTCON_MAX3355 > tristate "Maxim MAX3355 USB OTG EXTCON Support" > + depends on GPIOLIB || COMPILE_TEST If it won't compile w/o gpiolib, what's the use of COMIPLE_TEST? And no, it shouldn't depend on gpiolib. It has empty stubs for the case of CONFIG_GPIOLIB=n. Obviously something is wrong with the GPIO headers, I'll look into it. [...] > Thanks, > Chanwoo Choi MBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933402AbbLTRPN (ORCPT ); Sun, 20 Dec 2015 12:15:13 -0500 Received: from mail-lf0-f41.google.com ([209.85.215.41]:35305 "EHLO mail-lf0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754350AbbLTRPK (ORCPT ); Sun, 20 Dec 2015 12:15:10 -0500 Subject: Re: [PATCH v5] extcon: add Maxim MAX3355 driver To: cw00.choi@samsung.com References: <5948633.my3nAG6hRz@wasted.cogentembedded.com> Cc: Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , "myungjoo.ham@samsung.com" , devicetree , linux-kernel , linux-sh@vger.kernel.org, linux-usb@vger.kernel.org From: Sergei Shtylyov Organization: Cogent Embedded Message-ID: <5676E214.2040009@cogentembedded.com> Date: Sun, 20 Dec 2015 20:15:00 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello. On 12/20/2015 05:31 PM, Chanwoo Choi wrote: > This patch depend on GPIOLIB configuration as following: > I modified it with following diff and applied it. > > diff --git a/drivers/extcon/Kconfig b/drivers/extcon/Kconfig > index ba4db7d..3d89e60 100644 > --- a/drivers/extcon/Kconfig > +++ b/drivers/extcon/Kconfig > @@ -54,6 +54,7 @@ config EXTCON_MAX14577 > > config EXTCON_MAX3355 > tristate "Maxim MAX3355 USB OTG EXTCON Support" > + depends on GPIOLIB || COMPILE_TEST If it won't compile w/o gpiolib, what's the use of COMIPLE_TEST? And no, it shouldn't depend on gpiolib. It has empty stubs for the case of CONFIG_GPIOLIB=n. Obviously something is wrong with the GPIO headers, I'll look into it. [...] > Thanks, > Chanwoo Choi MBR, Sergei