From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark yao Subject: Re: [PATCH 4/6] drm/rockchip: vop: spilt scale regsters Date: Mon, 21 Dec 2015 08:53:53 +0800 Message-ID: <56774DA1.6040800@rock-chips.com> References: <1450323426-32109-1-git-send-email-mark.yao@rock-chips.com> <1450323426-32109-5-git-send-email-mark.yao@rock-chips.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1668249934==" Return-path: In-Reply-To: <1450323426-32109-5-git-send-email-mark.yao@rock-chips.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: David Airlie , Heiko Stuebner , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org List-Id: linux-rockchip.vger.kernel.org --===============1668249934== Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable
On 2015=E5=B9=B412=E6=9C=8817=E6=97=A5= 11:37, Mark Yao wrote:
@@ -242,6 +247,11 @@ static inline uint16_t scl_cal_=
scale(int src, int dst, int shift)
 	return ((src * 2 - 3) << (shift - 1)) / (dst - 1);
 }
=20
+static inline uint16_t scl_cal_scale2(int src, int dst)
+{
+	return (src - 1) << 12 / (dst - 1);
+}
+

Sorry, There is a mistake here, lose a parenthesis after code formating, it should be:
+static inline uint16_t scl_cal_scale2(int src, int ds=
t)
+{
+	return ((src - 1) << 12) / (dst - 1);
+}
+
Without the parenthesis would cause rk3036 scale abnormal.
I would send v1.1 patch to fix it.

Thanks.
--=20
=EF=BC=ADark Yao
--===============1668249934== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK --===============1668249934==--