From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yakir Yang Subject: Re: [RFC PATCH v1 1/2] drm: rockchip/hdmi: add Innosilicon HDMI support Date: Mon, 21 Dec 2015 15:44:56 +0800 Message-ID: <5677ADF8.60305@rock-chips.com> References: <1447227952-4787-1-git-send-email-ykk@rock-chips.com> <1447227999-4842-1-git-send-email-ykk@rock-chips.com> <5677AAC4.1010405@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <5677AAC4.1010405@rock-chips.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Mark yao , Heiko Stuebner Cc: Mark Rutland , devicetree@vger.kernel.org, Pawel Moll , Ian Campbell , Ben Chan , Ken Mixte , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, Rob Herring , Kumar Gala , Thierry Reding , linux-arm-kernel@lists.infradead.org, Zheng Yang List-Id: linux-rockchip.vger.kernel.org SGkgTWFyaywKCk9uIDEyLzIxLzIwMTUgMDM6MzEgUE0sIE1hcmsgeWFvIHdyb3RlOgo+IE9uIDIw MTXlubQxMeaciDEx5pelIDE1OjQ2LCBZYWtpciBZYW5nIHdyb3RlOgo+PiArICAgIGhkbWktPmNv bm5lY3Rvci5wb2xsZWQgPSBEUk1fQ09OTkVDVE9SX1BPTExfSFBEOwo+PiArCj4+ICsgICAgZHJt X2Nvbm5lY3Rvcl9oZWxwZXJfYWRkKCZoZG1pLT5jb25uZWN0b3IsCj4+ICsgICAgICAgICAgICAg ICAgICZpbm5vX2hkbWlfY29ubmVjdG9yX2hlbHBlcl9mdW5jcyk7Cj4+ICsgICAgZHJtX2Nvbm5l Y3Rvcl9pbml0KGRybSwgJmhkbWktPmNvbm5lY3RvciwgCj4+ICZpbm5vX2hkbWlfY29ubmVjdG9y X2Z1bmNzLAo+PiArICAgICAgICAgICAgICAgRFJNX01PREVfQ09OTkVDVE9SX0hETUlBKTsKPj4g Kwo+PiArICAgIGhkbWktPmNvbm5lY3Rvci5lbmNvZGVyID0gZW5jb2RlcjsKPgo+IFBscyByZW1v dmUgImhkbWktPmNvbm5lY3Rvci5lbmNvZGVyID0gZW5jb2RlcjsiCj4KPiBJdCB3b3VsZCBjYXVz ZSBhIGVycm9yIGR1bXAgb24gYXRvbWljIGRybSBydW50aW1lOgo+Cj4gV0FSTklORzogQ1BVOiAz IFBJRDogNzQgYXQgZHJpdmVycy9ncHUvZHJtL2RybV9hdG9taWNfaGVscGVyLmM6NjgyIAo+IGRy bV9hdG9taWNfaGVscGVyX3VwZGF0ZV9sZWdhY3lfbW9kZXNldF9zdGF0ZSsweDZjLzB4MjAwKCkK Pgo+IFRoaXMgaXNzdWUgY2FuIGJlIGV4cGxhaW5lZCBmcm9tIGZvbGxvd2luZyB0aHJlYWQ6Cj4g aHR0cHM6Ly9sa21sLm9yZy9sa21sLzIwMTUvMTEvMTYvNDk4Cj4KCkRvbmUsIHRoYW5rcwoKLSBZ YWtpcgoKPiBUaGFua3MuCj4KCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVz a3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2Ry aS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: ykk@rock-chips.com (Yakir Yang) Date: Mon, 21 Dec 2015 15:44:56 +0800 Subject: [RFC PATCH v1 1/2] drm: rockchip/hdmi: add Innosilicon HDMI support In-Reply-To: <5677AAC4.1010405@rock-chips.com> References: <1447227952-4787-1-git-send-email-ykk@rock-chips.com> <1447227999-4842-1-git-send-email-ykk@rock-chips.com> <5677AAC4.1010405@rock-chips.com> Message-ID: <5677ADF8.60305@rock-chips.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Mark, On 12/21/2015 03:31 PM, Mark yao wrote: > On 2015?11?11? 15:46, Yakir Yang wrote: >> + hdmi->connector.polled = DRM_CONNECTOR_POLL_HPD; >> + >> + drm_connector_helper_add(&hdmi->connector, >> + &inno_hdmi_connector_helper_funcs); >> + drm_connector_init(drm, &hdmi->connector, >> &inno_hdmi_connector_funcs, >> + DRM_MODE_CONNECTOR_HDMIA); >> + >> + hdmi->connector.encoder = encoder; > > Pls remove "hdmi->connector.encoder = encoder;" > > It would cause a error dump on atomic drm runtime: > > WARNING: CPU: 3 PID: 74 at drivers/gpu/drm/drm_atomic_helper.c:682 > drm_atomic_helper_update_legacy_modeset_state+0x6c/0x200() > > This issue can be explained from following thread: > https://lkml.org/lkml/2015/11/16/498 > Done, thanks - Yakir > Thanks. > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751451AbbLUHpL (ORCPT ); Mon, 21 Dec 2015 02:45:11 -0500 Received: from lucky1.263xmail.com ([211.157.147.132]:42040 "EHLO lucky1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750794AbbLUHpJ (ORCPT ); Mon, 21 Dec 2015 02:45:09 -0500 X-263anti-spam: KSV:0; X-MAIL-GRAY: 1 X-MAIL-DELIVERY: 0 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 X-RL-SENDER: ykk@rock-chips.com X-FST-TO: linux-arm-kernel@lists.infradead.org X-SENDER-IP: 103.29.142.67 X-LOGIN-NAME: ykk@rock-chips.com X-UNIQUE-TAG: <8b140dd8632eace0bfe67b207680e4df> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [RFC PATCH v1 1/2] drm: rockchip/hdmi: add Innosilicon HDMI support To: Mark yao , Heiko Stuebner References: <1447227952-4787-1-git-send-email-ykk@rock-chips.com> <1447227999-4842-1-git-send-email-ykk@rock-chips.com> <5677AAC4.1010405@rock-chips.com> Cc: David Airlie , Thierry Reding , Rob Herring , Ken Mixte , Ben Chan , Zheng Yang , Kumar Gala , Ian Campbell , Pawel Moll , Mark Rutland , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org From: Yakir Yang Message-ID: <5677ADF8.60305@rock-chips.com> Date: Mon, 21 Dec 2015 15:44:56 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <5677AAC4.1010405@rock-chips.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Mark, On 12/21/2015 03:31 PM, Mark yao wrote: > On 2015年11月11日 15:46, Yakir Yang wrote: >> + hdmi->connector.polled = DRM_CONNECTOR_POLL_HPD; >> + >> + drm_connector_helper_add(&hdmi->connector, >> + &inno_hdmi_connector_helper_funcs); >> + drm_connector_init(drm, &hdmi->connector, >> &inno_hdmi_connector_funcs, >> + DRM_MODE_CONNECTOR_HDMIA); >> + >> + hdmi->connector.encoder = encoder; > > Pls remove "hdmi->connector.encoder = encoder;" > > It would cause a error dump on atomic drm runtime: > > WARNING: CPU: 3 PID: 74 at drivers/gpu/drm/drm_atomic_helper.c:682 > drm_atomic_helper_update_legacy_modeset_state+0x6c/0x200() > > This issue can be explained from following thread: > https://lkml.org/lkml/2015/11/16/498 > Done, thanks - Yakir > Thanks. >