From mboxrd@z Thu Jan 1 00:00:00 1970 From: Doug Goldstein Subject: Re: [PATCH] build: save generated config in /boot Date: Mon, 21 Dec 2015 09:20:19 -0600 Message-ID: <567818B3.6060908@cardoe.com> References: <1450474548-26428-1-git-send-email-cardoe@cardoe.com> <5677FA9802000078000C1DA7@prv-mh.provo.novell.com> <56780E25.9090806@cardoe.com> <56781FFA02000078000C1F3D@prv-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8448491877647460051==" Return-path: In-Reply-To: <56781FFA02000078000C1F3D@prv-mh.provo.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: Keir Fraser , Tim Deegan , Ian Jackson , Ian Campbell , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============8448491877647460051== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Jiw5njbH48UuQplAUHwBrjiTpEBBHL0kp" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Jiw5njbH48UuQplAUHwBrjiTpEBBHL0kp Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 12/21/15 8:51 AM, Jan Beulich wrote: >>>> On 21.12.15 at 15:35, wrote: >> On 12/21/15 6:11 AM, Jan Beulich wrote: >>>>>> On 18.12.15 at 22:35, wrote: >>>> Since we now support changing Xen options with Kconfig, we should sa= ve >>>> the configuration that was used to build up Xen. This will save it i= n >>>> /boot alongside the installed xen.gz and call it >>>> xen-$(FULLVERSION).config >>>> >>>> Suggested-by: Ian Campbell >>>> Signed-off-by: Doug Goldstein >>>> --- >>>> xen/Makefile | 1 + >>>> 1 file changed, 1 insertion(+) >>>> >>>> diff --git a/xen/Makefile b/xen/Makefile >>>> index 9023863..460b977 100644 >>>> --- a/xen/Makefile >>>> +++ b/xen/Makefile >>>> @@ -58,6 +58,7 @@ _install: $(TARGET)$(CONFIG_XEN_INSTALL_SUFFIX) >>>> ln -f -s $(T)-$(XEN_FULLVERSION)$(Z) $(D)$(BOOT_DIR)/$(T)$(Z) >>>> [ -d "$(D)$(DEBUG_DIR)" ] || $(INSTALL_DIR) $(D)$(DEBUG_DIR) >>>> $(INSTALL_DATA) $(TARGET)-syms $(D)$(DEBUG_DIR)/$(T)-syms-$(XEN_FU= LLVERSION) >>>> + $(INSTALL_DATA) $(KCONFIG_CONFIG)=20 >> $(D)$(BOOT_DIR)/$(T)-$(XEN_FULLVERSION).config >>> >>> Was it really suggested to put this into /boot? It has no business >>> being there... >> >> Yes. By multiple people. Ian Campbell was the first person to suggest = it >> in that location. >=20 > Okay, so I've looked it up, and no, he didn't. He just gave this as one= > possibility: >=20 > "It occurred to me this morning that we probably ought to stash the .co= nfig > somewhere on install in such a way that it can be associated with the = Xen > binary (i.e. with the same full suffix as the binary itself, not the > abridged symlink names), maybe as $(BOOT_DIR)/$(T)- > $(XEN_FULLVERSION).config?" >=20 > But yes, I'm sorry for not noticing this as an undesirable place right > away. >=20 > Jan >=20 >=20 Ok well I'm at a loss here because the quote clearly shows him suggesting that location. Do you have a suggested location because so far I've just got a no from you on the only suggested location. --=20 Doug Goldstein --Jiw5njbH48UuQplAUHwBrjiTpEBBHL0kp Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0 iQJ8BAEBCgBmBQJWeBi2XxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRBNTM5MEQ2RTNFMTkyNzlCNzVDMzIwOTVB MkJDMDNEQzg3RUQxQkQ0AAoJEKK8A9yH7RvU60QP/Rxj4cCX6GP/rKWNSizxCxsW 0BjoZ5JMViK5vPpbz1XGQGiGqTjYimGadK8JhjY8esmErdlGmh00hIpspBkk2Ex+ R3yvvAn7FCjW5WVfoNO94CWiSPrfaXuuMfSXBdBbcnIhDMz7EPLCJdp93FtyCEW0 YxdCthke4DRtb+OTLS47D3467MaFhwwu1r6rsQInBNOtf0z13CZsQ8KB18laRhHs PNk+dheyQV21IcUfi7q1jgl63MjVRYqF4ePRr65YAFdPGtBRKcyCPj1Sdlq6OhM3 OZwkuflXp+bU9hh+bzKoWJeSD59LQejNOO5aINzQDHskEfdht53tmOXIkPGD1bAf Vsq+ipKkR6lx6HdErIoGeAt0Sr90vE/G8QmrW7ctwZUJ+Waz7hT12xhF4GPbk7GV drz7RktHeVuOXi2j2D+7hbjDUgR8/+n7B2yKDtABEU7eG5XMBkrSOlhlaXxLThXJ C4rjtihTSbwDXJp/e/n9yEbzYEe9Z/izCxPuJFPXMlTkIOAeMPJXq1BTJls77NAo uq3Y5d/MK1ULEMMuxmJvXgB0W6qQ1furX5dmt9M4aV1drnocGN4nuCUbklpw0loW 7+rHdFVU4hE8slcrLHbTIGjkK4tYviuyEduEVIa/sQItWnYU3xfIRQlg6QzR2Szs e9j107b9c8I+ifhgn3zW =mxWs -----END PGP SIGNATURE----- --Jiw5njbH48UuQplAUHwBrjiTpEBBHL0kp-- --===============8448491877647460051== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============8448491877647460051==--