From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vladimir Zapolskiy Subject: Re: [PATCH v4 2/5] Documentation: devicetree: Add DT bindings to eeprom_93xx46 driver. Date: Tue, 22 Dec 2015 02:01:51 +0200 Message-ID: <567892EF.6060508@mleia.com> References: <1449720055-25965-1-git-send-email-cory.tusar@pid1solutions.com> <1449720055-25965-3-git-send-email-cory.tusar@pid1solutions.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1449720055-25965-3-git-send-email-cory.tusar-J6Z/VSE8EyIAspv4Qr0y0gC/G2K4zDHf@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Cory Tusar , robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, pawel.moll-5wv7dgnIgG8@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org, galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org Cc: jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, afd-l0cyMroinI0@public.gmane.org, andrew-g2DYL2Zd6BY@public.gmane.org, Chris.Healy-c8ZVq/bFV1I@public.gmane.org, Keith.Vennel-c8ZVq/bFV1I@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org Hi Cory, On 10.12.2015 06:00, Cory Tusar wrote: > This commit documents bindings to be added to the eeprom_93xx46 driver > which will allow: > > - Device word size and read-only attributes to be specified. > - A device-specific compatible string for use with Atmel AT93C46D > EEPROMs. > - Specifying a GPIO line to function as a 'select' or 'enable' signal > prior to accessing the EEPROM. > > Signed-off-by: Cory Tusar > Acked-by: Rob Herring > Tested-by: Chris Healy > --- > .../devicetree/bindings/misc/eeprom-93xx46.txt | 25 ++++++++++++++++++++++ > 1 file changed, 25 insertions(+) > > diff --git a/Documentation/devicetree/bindings/misc/eeprom-93xx46.txt b/Documentation/devicetree/bindings/misc/eeprom-93xx46.txt > new file mode 100644 > index 0000000..a8ebb46 > --- /dev/null > +++ b/Documentation/devicetree/bindings/misc/eeprom-93xx46.txt > @@ -0,0 +1,25 @@ > +EEPROMs (SPI) compatible with Microchip Technology 93xx46 family. > + > +Required properties: > +- compatible : shall be one of: > + "atmel,at93c46d" > + "eeprom-93xx46" the second compatible property value is not recommended by ePAPR, I would suggest to remove it from here and from the example below. But I see that Rob acked this change though... > +- data-size : number of data bits per word (either 8 or 16) > + > +Optional properties: > +- read-only : parameter-less property which disables writes to the EEPROM > +- select-gpios : if present, specifies the GPIO that will be asserted prior to > + each access to the EEPROM (e.g. for SPI bus multiplexing) > + > +Property rules described in Documentation/devicetree/bindings/spi/spi-bus.txt > +apply. In particular, "reg" and "spi-max-frequency" properties must be given. > + > +Example: > + eeprom@0 { > + compatible = "eeprom-93xx46"; > + reg = <0>; > + spi-max-frequency = <1000000>; > + spi-cs-high; > + data-size = <8>; > + select-gpios = <&gpio4 4 GPIO_ACTIVE_HIGH>; > + }; > -- With best wishes, Vladimir -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753478AbbLVAES (ORCPT ); Mon, 21 Dec 2015 19:04:18 -0500 Received: from mleia.com ([178.79.152.223]:50724 "EHLO mail.mleia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752565AbbLVABy (ORCPT ); Mon, 21 Dec 2015 19:01:54 -0500 Message-ID: <567892EF.6060508@mleia.com> Date: Tue, 22 Dec 2015 02:01:51 +0200 From: Vladimir Zapolskiy User-Agent: Mozilla/5.0 (X11; Linux i686; rv:31.0) Gecko/20100101 Icedove/31.6.0 MIME-Version: 1.0 To: Cory Tusar , robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, gregkh@linuxfoundation.org CC: jic23@kernel.org, broonie@kernel.org, afd@ti.com, andrew@lunn.ch, Chris.Healy@zii.aero, Keith.Vennel@zii.aero, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 2/5] Documentation: devicetree: Add DT bindings to eeprom_93xx46 driver. References: <1449720055-25965-1-git-send-email-cory.tusar@pid1solutions.com> <1449720055-25965-3-git-send-email-cory.tusar@pid1solutions.com> In-Reply-To: <1449720055-25965-3-git-send-email-cory.tusar@pid1solutions.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-49551924 X-CRM114-CacheID: sfid-20151222_000206_676383_DB7DD402 X-CRM114-Status: GOOD ( 23.31 ) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Cory, On 10.12.2015 06:00, Cory Tusar wrote: > This commit documents bindings to be added to the eeprom_93xx46 driver > which will allow: > > - Device word size and read-only attributes to be specified. > - A device-specific compatible string for use with Atmel AT93C46D > EEPROMs. > - Specifying a GPIO line to function as a 'select' or 'enable' signal > prior to accessing the EEPROM. > > Signed-off-by: Cory Tusar > Acked-by: Rob Herring > Tested-by: Chris Healy > --- > .../devicetree/bindings/misc/eeprom-93xx46.txt | 25 ++++++++++++++++++++++ > 1 file changed, 25 insertions(+) > > diff --git a/Documentation/devicetree/bindings/misc/eeprom-93xx46.txt b/Documentation/devicetree/bindings/misc/eeprom-93xx46.txt > new file mode 100644 > index 0000000..a8ebb46 > --- /dev/null > +++ b/Documentation/devicetree/bindings/misc/eeprom-93xx46.txt > @@ -0,0 +1,25 @@ > +EEPROMs (SPI) compatible with Microchip Technology 93xx46 family. > + > +Required properties: > +- compatible : shall be one of: > + "atmel,at93c46d" > + "eeprom-93xx46" the second compatible property value is not recommended by ePAPR, I would suggest to remove it from here and from the example below. But I see that Rob acked this change though... > +- data-size : number of data bits per word (either 8 or 16) > + > +Optional properties: > +- read-only : parameter-less property which disables writes to the EEPROM > +- select-gpios : if present, specifies the GPIO that will be asserted prior to > + each access to the EEPROM (e.g. for SPI bus multiplexing) > + > +Property rules described in Documentation/devicetree/bindings/spi/spi-bus.txt > +apply. In particular, "reg" and "spi-max-frequency" properties must be given. > + > +Example: > + eeprom@0 { > + compatible = "eeprom-93xx46"; > + reg = <0>; > + spi-max-frequency = <1000000>; > + spi-cs-high; > + data-size = <8>; > + select-gpios = <&gpio4 4 GPIO_ACTIVE_HIGH>; > + }; > -- With best wishes, Vladimir