From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hannes Reinecke Subject: Re: [PATCH v3 60/77] ncr5380: Implement new eh_abort_handler Date: Tue, 22 Dec 2015 08:59:15 +0100 Message-ID: <567902D3.4020004@suse.de> References: <20151222011737.980475848@telegraphics.com.au> <20151222011754.345477083@telegraphics.com.au> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <20151222011754.345477083@telegraphics.com.au> Sender: linux-scsi-owner@vger.kernel.org To: Finn Thain , "James E.J. Bottomley" , Michael Schmitz , linux-m68k@vger.kernel.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, "Martin K. Petersen" List-Id: linux-m68k@vger.kernel.org On 12/22/2015 02:18 AM, Finn Thain wrote: > Introduce a new eh_abort_handler implementation. This one attempts to > follow all of the rules relating to EH handlers. There is still a kno= wn > bug: during selection, a command becomes invisible to the EH handlers > because it only appears in a pointer on the stack of a different thre= ad. > This bug is addressed in a subsequent patch. > > Signed-off-by: Finn Thain > > --- > drivers/scsi/NCR5380.c | 155 +++++++++++++++++++++++++++++++= +++++++---- > drivers/scsi/atari_NCR5380.c | 157 +++++++++++++++++++++++++++++++= +++++++----- > 2 files changed, 282 insertions(+), 30 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes --=20 Dr. Hannes Reinecke zSeries & Storage hare@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg GF: J. Hawn, J. Guild, F. Imend=F6rffer, HRB 16746 (AG N=FCrnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753413AbbLVH7T (ORCPT ); Tue, 22 Dec 2015 02:59:19 -0500 Received: from mx2.suse.de ([195.135.220.15]:44138 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751166AbbLVH7R (ORCPT ); Tue, 22 Dec 2015 02:59:17 -0500 Subject: Re: [PATCH v3 60/77] ncr5380: Implement new eh_abort_handler To: Finn Thain , "James E.J. Bottomley" , Michael Schmitz , linux-m68k@vger.kernel.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, "Martin K. Petersen" References: <20151222011737.980475848@telegraphics.com.au> <20151222011754.345477083@telegraphics.com.au> From: Hannes Reinecke Message-ID: <567902D3.4020004@suse.de> Date: Tue, 22 Dec 2015 08:59:15 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <20151222011754.345477083@telegraphics.com.au> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/22/2015 02:18 AM, Finn Thain wrote: > Introduce a new eh_abort_handler implementation. This one attempts to > follow all of the rules relating to EH handlers. There is still a known > bug: during selection, a command becomes invisible to the EH handlers > because it only appears in a pointer on the stack of a different thread. > This bug is addressed in a subsequent patch. > > Signed-off-by: Finn Thain > > --- > drivers/scsi/NCR5380.c | 155 ++++++++++++++++++++++++++++++++++++++---- > drivers/scsi/atari_NCR5380.c | 157 ++++++++++++++++++++++++++++++++++++++----- > 2 files changed, 282 insertions(+), 30 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage hare@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)