From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 4/8] axp: Fix debugging support in DDR3 write leveling
Date: Tue, 22 Dec 2015 09:08:45 +0100 [thread overview]
Message-ID: <5679050D.7070407@denx.de> (raw)
In-Reply-To: <20151221232445.A92BA6121B@mail.nwl.cc>
On 22.12.2015 00:25, Phil Sutter wrote:
> If MV_DEBUG_WL is defined, DEBUG_WL_S and DEBUG_WL_D macros are missing.
> In addition to that, get rid of debug output printing non-existent
> counter variable.
>
> Signed-off-by: Phil Sutter <phil@nwl.cc>
> ---
> drivers/ddr/marvell/axp/ddr3_write_leveling.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/ddr/marvell/axp/ddr3_write_leveling.c b/drivers/ddr/marvell/axp/ddr3_write_leveling.c
> index df3a3df..da384f3 100644
> --- a/drivers/ddr/marvell/axp/ddr3_write_leveling.c
> +++ b/drivers/ddr/marvell/axp/ddr3_write_leveling.c
> @@ -22,6 +22,8 @@
> DEBUG_WL_FULL_S(s); DEBUG_WL_FULL_D(d, l); DEBUG_WL_FULL_S("\n")
>
> #ifdef MV_DEBUG_WL
> +#define DEBUG_WL_S(s) puts(s)
> +#define DEBUG_WL_D(d, l) printf("%x", d)
> #define DEBUG_RL_S(s) \
> debug_cond(ddr3_get_log_level() >= MV_LOG_LEVEL_2, "%s", s)
> #define DEBUG_RL_D(d, l) \
> @@ -1229,8 +1231,6 @@ static int ddr3_write_leveling_single_cs(u32 cs, u32 freq, int ratio_2to1,
> DEBUG_WL_FULL_D((u32) phase, 1);
> DEBUG_WL_FULL_S(", Delay = ");
> DEBUG_WL_FULL_D((u32) delay, 1);
> - DEBUG_WL_FULL_S(", Counter = ");
> - DEBUG_WL_FULL_D((u32) i, 1);
> DEBUG_WL_FULL_S("\n");
>
> /* Drive DQS high for one cycle - All data PUPs */
>
Reviewed-by: Stefan Roese <sr@denx.de>
Thanks,
Stefan
next prev parent reply other threads:[~2015-12-22 8:08 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1450740358-5014-1-git-send-email-phil@nwl.cc>
2015-12-21 23:25 ` [U-Boot] [PATCH v2 1/8] drivers/pci: Fix for debug builds without CONFIG_PCI_ENUM_ONLY Phil Sutter
2015-12-22 8:06 ` Stefan Roese
2015-12-21 23:25 ` [U-Boot] [PATCH v2 2/8] mvebu: Fix for non-DM ehci-marvell support Phil Sutter
2015-12-22 8:02 ` Stefan Roese
2015-12-22 14:24 ` Phil Sutter
2015-12-22 14:27 ` Stefan Roese
2015-12-21 23:25 ` [U-Boot] [PATCH v2 3/8] README: Review the u-boot porting guide list Phil Sutter
2015-12-22 8:08 ` Stefan Roese
2015-12-21 23:25 ` [U-Boot] [PATCH v2 4/8] axp: Fix debugging support in DDR3 write leveling Phil Sutter
2015-12-22 8:08 ` Stefan Roese [this message]
2015-12-21 23:25 ` [U-Boot] [PATCH v2 5/8] drivers/pci/pci_mvebu: Fix for boards with X4 lanes Phil Sutter
2015-12-22 8:24 ` Stefan Roese
2015-12-21 23:25 ` [U-Boot] [PATCH v2 6/8] mvebu: Add rudimental MV78320 support Phil Sutter
2015-12-22 8:32 ` Stefan Roese
2015-12-21 23:25 ` [U-Boot] [PATCH v2 7/8] mvebu: Support Synology DS414 Phil Sutter
2015-12-22 9:05 ` Stefan Roese
2015-12-23 0:31 ` Phil Sutter
2015-12-23 7:56 ` Stefan Roese
2015-12-23 11:30 ` Phil Sutter
2015-12-23 11:43 ` Stefan Roese
2017-06-16 14:04 ` Bin Meng
2015-12-21 23:25 ` [U-Boot] [PATCH v2 8/8] common: Implement Synology specific command set Phil Sutter
2015-12-22 9:06 ` Stefan Roese
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5679050D.7070407@denx.de \
--to=sr@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.