From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Yan Subject: Re: [PATCH 5/6] ARM: dts: rockchip: add reboot mode node Date: Tue, 22 Dec 2015 17:04:42 +0800 Message-ID: <5679122A.2070700@rock-chips.com> References: <1450697249-29994-1-git-send-email-andy.yan@rock-chips.com> <1450698149-30260-1-git-send-email-andy.yan@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+glpar-linux-rockchip=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Naoki FUKAUMI Cc: mark.rutland-5wv7dgnIgG8@public.gmane.org, heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org, geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org, catalin.marinas-5wv7dgnIgG8@public.gmane.org, will.deacon-5wv7dgnIgG8@public.gmane.org, sre-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, alexandre.belloni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org, lorenzo.pieralisi-5wv7dgnIgG8@public.gmane.org, linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org, arnd-r2nGTMty4D4@public.gmane.org, dbaryshkov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, joel-U3u1mxZcP9KHXe+LvDLADg@public.gmane.org, treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, wxt-TNX95d0MmH7DzftRWevZcw@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, khilman-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, pawel.moll-5wv7dgnIgG8@public.gmane.org, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, john.stultz-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, jun.nie-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, moritz.fischer-+aYTwkv1SeIAvxtiuMwx3w@public.gmane.org, gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org, sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org, akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org List-Id: linux-rockchip.vger.kernel.org SGksCgpPbiAyMDE15bm0MTLmnIgyMuaXpSAxMTowNCwgTmFva2kgRlVLQVVNSSB3cm90ZToKPiBo aSwKPgo+IE9uIE1vbiwgRGVjIDIxLCAyMDE1IGF0IDg6NDIgUE0sIEFuZHkgWWFuPGFuZHkueWFu QHJvY2stY2hpcHMuY29tPiAgd3JvdGU6Cj4+IEFkZCByZWJvb3QgbW9kZSBkcml2ZXIgRFQgbm9k ZSBmb3IgcmszeHh4LHJrMzI4OCBwbGF0Zm9ybQo+Pgo+PiBTaWduZWQtb2ZmLWJ5OiBBbmR5IFlh bjxhbmR5LnlhbkByb2NrLWNoaXBzLmNvbT4KPj4gLS0tCj4+Cj4+ICAgYXJjaC9hcm0vYm9vdC9k dHMvcmszMjg4LmR0c2kgICAgICAgICAgICAgICAgfCAyNSArKysrKysrKysrKysrKysrKysrKysr Kwo+PiAgIGFyY2gvYXJtL2Jvb3QvZHRzL3JrM3h4eC5kdHNpICAgICAgICAgICAgICAgIHwgMjYg KysrKysrKysrKysrKysrKysrKysrKysrCj4+ICAgaW5jbHVkZS9kdC1iaW5kaW5ncy9zb2Mvcm9j a2NoaXBfYm9vdC1tb2RlLmggfCAzMCArKysrKysrKysrKysrKysrKysrKysrKysrKysrCj4+ICAg MyBmaWxlcyBjaGFuZ2VkLCA4MSBpbnNlcnRpb25zKCspCj4+ICAgY3JlYXRlIG1vZGUgMTAwNjQ0 IGluY2x1ZGUvZHQtYmluZGluZ3Mvc29jL3JvY2tjaGlwX2Jvb3QtbW9kZS5oCj4+Cj4+IGRpZmYg LS1naXQgYS9hcmNoL2FybS9ib290L2R0cy9yazMyODguZHRzaSBiL2FyY2gvYXJtL2Jvb3QvZHRz L3JrMzI4OC5kdHNpCj4+IGluZGV4IDA0ZWEyMDkuLjkzN2JhNGMgMTAwNjQ0Cj4+IC0tLSBhL2Fy Y2gvYXJtL2Jvb3QvZHRzL3JrMzI4OC5kdHNpCj4+ICsrKyBiL2FyY2gvYXJtL2Jvb3QvZHRzL3Jr MzI4OC5kdHNpCj4+IEBAIC0xNzAsNiArMTcwLDMxIEBACj4+ICAgICAgICAgICAgICAgICAgfTsK Pj4gICAgICAgICAgfTsKPj4KPj4gKyAgICAgICByZWJvb3RfbW9kZSB7Cj4+ICsgICAgICAgICAg ICAgICBjb21wYXRpYmxlID0gInJvY2tjaGlwLHJlYm9vdC1tb2RlIjsKPj4gKyAgICAgICAgICAg ICAgIHJvY2tjaGlwLHJlZ21hcCA9IDwmcG11PjsKPj4gKyAgICAgICAgICAgICAgIG9mZnNldCA9 IDwweDk0PjsKPj4gKyAgICAgICAgICAgICAgIGxvYWRlciB7Cj4+ICsgICAgICAgICAgICAgICAg ICAgICAgIGxpbnV4LG1vZGUgPSAibG9hZGVyIjsKPj4gKyAgICAgICAgICAgICAgICAgICAgICAg bGludXgsbWFnaWMgPSA8MHg1MjQyQzMwMT47Cj4+ICsgICAgICAgICAgICAgICB9Owo+PiArCj4+ ICsgICAgICAgICAgICAgICBtYXNrcm9tIHsKPj4gKyAgICAgICAgICAgICAgICAgICAgICAgbGlu dXgsbW9kZSA9ICJtYXNrcm9tIjsKPj4gKyAgICAgICAgICAgICAgICAgICAgICAgbGludXgsbWFn aWMgPSA8MHg1MjQyQzMwMj47Cj4+ICsgICAgICAgICAgICAgICB9Owo+PiArCj4+ICsgICAgICAg ICAgICAgICByZWNvdmVyeSB7Cj4+ICsgICAgICAgICAgICAgICAgICAgICAgIGxpbnV4LG1vZGUg PSAicmVjb3ZlcnkiOwo+PiArICAgICAgICAgICAgICAgICAgICAgICBsaW51eCxtYWdpYyA9IDww eDUyNDJDMzAzPjsKPj4gKyAgICAgICAgICAgICAgIH07Cj4+ICsKPj4gKyAgICAgICAgICAgICAg IGZhc3Rib290IHsKPj4gKyAgICAgICAgICAgICAgICAgICAgICAgbGludXgsbW9kZSA9ICJmYXN0 Ym9vdCI7Cj4+ICsgICAgICAgICAgICAgICAgICAgICAgIGxpbnV4LG1hZ2ljID0gPDB4NTI0MkMz MDk+Owo+PiArICAgICAgICAgICAgICAgfTsKPj4gKyAgICAgICB9Owo+PiArCj4gKHNuaXApCj4K PiBJIHNvbWV0aW1lcyB1c2UgMHhFRjA4QTUzQyB0byBsb2FkIGJvb3Rsb2FkZXIgZnJvbSBTRCBj YXJkIGluc3RlYWQgb2YKPiBvbi1ib2FyZCBmbGFzaCBtZW1vcnkgc3VjaCBhcyBlTU1DLgo+ICAg aHR0cHM6Ly9naXRodWIuY29tL2xpbnV4LXJvY2tjaGlwL3UtYm9vdC1yb2NrY2hpcC9ibG9iL3Ut Ym9vdC1yazMyODgvY29tbW9uL2NtZF9yb2NrdXNiLmMjTDg5Mwo+Cj4gSSBkb24ndCBrbm93IGFu eSBkZXRhaWwgYWJvdXQgdGhpcyBmdW5jdGlvbi4KPiAoYWJvdmUgY29kZSBzYXlzICJyZWJvb3Qg dG8gbWFza3JvbSIsIGJ1dCBpdCBzaG91bGQgYmUgd3JvbmcgZnJvbSBteSBleHBlcmllbmNlKQo+ Cj4gZG8geW91IGtub3cgc29tZXRoaW5nIGFib3V0IHRoaXMgZnVuY3Rpb24/IGNhbiB5b3UgaGFu ZGxlIHRoaXMgdG9vPwo+Cj4gUmVnYXJkcywKPgo+Cj4KICBIYXZlIHNvbWUgZGlzY3Vzc2lvbiB3 aXRoIHRoZSBib290bG9hZGVyIGVuZ2luZWVyLCB0aGUgY29ycmVjdCBtYWdpYyAgCm51bWJlciB0 bwogIHJlYm9vdCB0aGUgc3lzdGVtIHRvIG1hc2tyb20gbW9kZSBpcyAweEVGMDhBNTNDLiBJIHdp bGwgIGZpeCBpdCBpbiAKbmV4dCB2ZXJzaW9uLgoKCl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fCkxpbnV4LXJvY2tjaGlwIG1haWxpbmcgbGlzdApMaW51eC1y b2NrY2hpcEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21h aWxtYW4vbGlzdGluZm8vbGludXgtcm9ja2NoaXAK From mboxrd@z Thu Jan 1 00:00:00 1970 From: andy.yan@rock-chips.com (Andy Yan) Date: Tue, 22 Dec 2015 17:04:42 +0800 Subject: [PATCH 5/6] ARM: dts: rockchip: add reboot mode node In-Reply-To: References: <1450697249-29994-1-git-send-email-andy.yan@rock-chips.com> <1450698149-30260-1-git-send-email-andy.yan@rock-chips.com> Message-ID: <5679122A.2070700@rock-chips.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi, On 2015?12?22? 11:04, Naoki FUKAUMI wrote: > hi, > > On Mon, Dec 21, 2015 at 8:42 PM, Andy Yan wrote: >> Add reboot mode driver DT node for rk3xxx,rk3288 platform >> >> Signed-off-by: Andy Yan >> --- >> >> arch/arm/boot/dts/rk3288.dtsi | 25 +++++++++++++++++++++++ >> arch/arm/boot/dts/rk3xxx.dtsi | 26 ++++++++++++++++++++++++ >> include/dt-bindings/soc/rockchip_boot-mode.h | 30 ++++++++++++++++++++++++++++ >> 3 files changed, 81 insertions(+) >> create mode 100644 include/dt-bindings/soc/rockchip_boot-mode.h >> >> diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi >> index 04ea209..937ba4c 100644 >> --- a/arch/arm/boot/dts/rk3288.dtsi >> +++ b/arch/arm/boot/dts/rk3288.dtsi >> @@ -170,6 +170,31 @@ >> }; >> }; >> >> + reboot_mode { >> + compatible = "rockchip,reboot-mode"; >> + rockchip,regmap = <&pmu>; >> + offset = <0x94>; >> + loader { >> + linux,mode = "loader"; >> + linux,magic = <0x5242C301>; >> + }; >> + >> + maskrom { >> + linux,mode = "maskrom"; >> + linux,magic = <0x5242C302>; >> + }; >> + >> + recovery { >> + linux,mode = "recovery"; >> + linux,magic = <0x5242C303>; >> + }; >> + >> + fastboot { >> + linux,mode = "fastboot"; >> + linux,magic = <0x5242C309>; >> + }; >> + }; >> + > (snip) > > I sometimes use 0xEF08A53C to load bootloader from SD card instead of > on-board flash memory such as eMMC. > https://github.com/linux-rockchip/u-boot-rockchip/blob/u-boot-rk3288/common/cmd_rockusb.c#L893 > > I don't know any detail about this function. > (above code says "reboot to maskrom", but it should be wrong from my experience) > > do you know something about this function? can you handle this too? > > Regards, > > > Have some discussion with the bootloader engineer, the correct magic number to reboot the system to maskrom mode is 0xEF08A53C. I will fix it in next version. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753977AbbLVJGd (ORCPT ); Tue, 22 Dec 2015 04:06:33 -0500 Received: from regular1.263xmail.com ([211.150.99.130]:41221 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752972AbbLVJEw (ORCPT ); Tue, 22 Dec 2015 04:04:52 -0500 X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 X-RL-SENDER: andy.yan@rock-chips.com X-FST-TO: jun.nie@linaro.org X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: andy.yan@rock-chips.com X-UNIQUE-TAG: <2dcb05941cb737df602f9e574b607550> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 From: Andy Yan Subject: Re: [PATCH 5/6] ARM: dts: rockchip: add reboot mode node To: Naoki FUKAUMI References: <1450697249-29994-1-git-send-email-andy.yan@rock-chips.com> <1450698149-30260-1-git-send-email-andy.yan@rock-chips.com> Cc: robh+dt@kernel.org, heiko@sntech.de, arnd@arndb.de, john.stultz@linaro.org, mark.rutland@arm.com, geert+renesas@glider.be, catalin.marinas@arm.com, will.deacon@arm.com, linux-kernel@vger.kernel.org, alexandre.belloni@free-electrons.com, lorenzo.pieralisi@arm.com, linux@arm.linux.org.uk, dbaryshkov@gmail.com, linux-rockchip@lists.infradead.org, joel@jms.id.au, treding@nvidia.com, wxt@rock-chips.com, devicetree@vger.kernel.org, khilman@linaro.org, pawel.moll@arm.com, ijc+devicetree@hellion.org.uk, akpm@linux-foundation.org, linux-arm-kernel@lists.infradead.org, moritz.fischer@ettus.com, gregkh@linuxfoundation.org, sjg@chromium.org, sre@kernel.org, galak@codeaurora.org, olof@lixom.net, jun.nie@linaro.org Message-ID: <5679122A.2070700@rock-chips.com> Date: Tue, 22 Dec 2015 17:04:42 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 2015年12月22日 11:04, Naoki FUKAUMI wrote: > hi, > > On Mon, Dec 21, 2015 at 8:42 PM, Andy Yan wrote: >> Add reboot mode driver DT node for rk3xxx,rk3288 platform >> >> Signed-off-by: Andy Yan >> --- >> >> arch/arm/boot/dts/rk3288.dtsi | 25 +++++++++++++++++++++++ >> arch/arm/boot/dts/rk3xxx.dtsi | 26 ++++++++++++++++++++++++ >> include/dt-bindings/soc/rockchip_boot-mode.h | 30 ++++++++++++++++++++++++++++ >> 3 files changed, 81 insertions(+) >> create mode 100644 include/dt-bindings/soc/rockchip_boot-mode.h >> >> diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi >> index 04ea209..937ba4c 100644 >> --- a/arch/arm/boot/dts/rk3288.dtsi >> +++ b/arch/arm/boot/dts/rk3288.dtsi >> @@ -170,6 +170,31 @@ >> }; >> }; >> >> + reboot_mode { >> + compatible = "rockchip,reboot-mode"; >> + rockchip,regmap = <&pmu>; >> + offset = <0x94>; >> + loader { >> + linux,mode = "loader"; >> + linux,magic = <0x5242C301>; >> + }; >> + >> + maskrom { >> + linux,mode = "maskrom"; >> + linux,magic = <0x5242C302>; >> + }; >> + >> + recovery { >> + linux,mode = "recovery"; >> + linux,magic = <0x5242C303>; >> + }; >> + >> + fastboot { >> + linux,mode = "fastboot"; >> + linux,magic = <0x5242C309>; >> + }; >> + }; >> + > (snip) > > I sometimes use 0xEF08A53C to load bootloader from SD card instead of > on-board flash memory such as eMMC. > https://github.com/linux-rockchip/u-boot-rockchip/blob/u-boot-rk3288/common/cmd_rockusb.c#L893 > > I don't know any detail about this function. > (above code says "reboot to maskrom", but it should be wrong from my experience) > > do you know something about this function? can you handle this too? > > Regards, > > > Have some discussion with the bootloader engineer, the correct magic number to reboot the system to maskrom mode is 0xEF08A53C. I will fix it in next version.