From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dave Gordon <david.s.gordon@intel.com>
Subject: Re: [PATCH 3/6] drm/i915: simplify allocation of
 driver-internal requests
Date: Tue, 22 Dec 2015 11:36:37 +0000
Message-ID: <567935C5.6040905@intel.com>
References: <1450713885-5828-1-git-send-email-david.s.gordon@intel.com>
 <1450713885-5828-4-git-send-email-david.s.gordon@intel.com>
 <20151222090816.GB2641@nuc-i3427.alporthouse.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"; Format="flowed"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by gabe.freedesktop.org (Postfix) with ESMTP id 55E2E6E178
 for <intel-gfx@lists.freedesktop.org>; Tue, 22 Dec 2015 03:36:50 -0800 (PST)
In-Reply-To: <20151222090816.GB2641@nuc-i3427.alporthouse.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

T24gMjIvMTIvMTUgMDk6MDgsIENocmlzIFdpbHNvbiB3cm90ZToKPiBPbiBNb24sIERlYyAyMSwg
MjAxNSBhdCAwNDowNDo0MlBNICswMDAwLCBEYXZlIEdvcmRvbiB3cm90ZToKPj4gVGhlcmUgYXJl
IGEgbnVtYmVyIG9mIHBsYWNlcyB3aGVyZSB0aGUgZHJpdmVyIG5lZWRzIGEgcmVxdWVzdCwgYnV0
IGlzbid0Cj4+IHdvcmtpbmcgb24gYmVoYWxmIG9mIGFueSBzcGVjaWZpYyB1c2VyIG9yIGluIGEg
c3BlY2lmaWMgY29udGV4dC4gRm9yCj4+IHN1Y2ggcmVxdWVzdHMsIHdlIGFzc29jaWF0ZSB0aGVt
IHdpdGggdGhlIGRlZmF1bHQgY29udGV4dCBmb3IgdGhlIGVuZ2luZQo+PiB0aGF0IHRoZSByZXF1
ZXN0IHdpbGwgYmUgc3VibWl0dGVkIHRvLgo+Pgo+PiBUaGlzIHBhdGNoIHByb3ZpZGVzIGEgc2hv
cnRoYW5kIGZvciBkb2luZyBzdWNoIHJlcXVlc3QgYWxsb2NhdGlvbnMgYW5kCj4+IGNoYW5nZXMg
YWxsIHN1Y2ggY2FsbHMgdG8gdXNlIHRoZSBuZXcgZnVuY3Rpb24uCj4+Cj4+IFNpZ25lZC1vZmYt
Ynk6IERhdmUgR29yZG9uIDxkYXZpZC5zLmdvcmRvbkBpbnRlbC5jb20+Cj4+IENjOiBDaHJpcyBX
aWxzb24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51az4KPj4gLS0tCj4+ICAgZHJpdmVycy9ncHUv
ZHJtL2k5MTUvaTkxNV9kcnYuaCAgICAgIHwgIDIgKysKPj4gICBkcml2ZXJzL2dwdS9kcm0vaTkx
NS9pOTE1X2dlbS5jICAgICAgfCAzNiArKysrKysrKysrKysrKysrKysrKysrKysrKysrLS0tLS0t
LS0KPj4gICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMgfCAgNiArKysrLS0K
Pj4gICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9vdmVybGF5LmMgfCAyNCArKysrKysrKysr
KystLS0tLS0tLS0tLS0KPj4gICA0IGZpbGVzIGNoYW5nZWQsIDQ2IGluc2VydGlvbnMoKyksIDIy
IGRlbGV0aW9ucygtKQo+Pgo+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkx
NV9kcnYuaCBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmgKPj4gaW5kZXggNjY2ZDA3
Yy4uNDk1NWRiOSAxMDA2NDQKPj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYu
aAo+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oCj4+IEBAIC0yMjcwLDYg
KzIyNzAsOCBAQCBzdHJ1Y3QgZHJtX2k5MTVfZ2VtX3JlcXVlc3Qgewo+PiAgIGludCBpOTE1X2dl
bV9yZXF1ZXN0X2FsbG9jKHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKnJpbmcsCj4+ICAgCQkJICAg
c3RydWN0IGludGVsX2NvbnRleHQgKmN0eCwKPj4gICAJCQkgICBzdHJ1Y3QgZHJtX2k5MTVfZ2Vt
X3JlcXVlc3QgKipyZXFfb3V0KTsKPj4gK3N0cnVjdCBkcm1faTkxNV9nZW1fcmVxdWVzdCAqIF9f
bXVzdF9jaGVjawo+PiArCWk5MTVfZ2VtX3JlcXVlc3RfYWxsb2NfYW5vbihzdHJ1Y3QgaW50ZWxf
ZW5naW5lX2NzICpyaW5nKTsKPj4gICB2b2lkIGk5MTVfZ2VtX3JlcXVlc3RfY2FuY2VsKHN0cnVj
dCBkcm1faTkxNV9nZW1fcmVxdWVzdCAqcmVxKTsKPj4gICB2b2lkIGk5MTVfZ2VtX3JlcXVlc3Rf
ZnJlZShzdHJ1Y3Qga3JlZiAqcmVxX3JlZik7Cj4+ICAgaW50IGk5MTVfZ2VtX3JlcXVlc3RfYWRk
X3RvX2NsaWVudChzdHJ1Y3QgZHJtX2k5MTVfZ2VtX3JlcXVlc3QgKnJlcSwKPj4gZGlmZiAtLWdp
dCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkx
NS9pOTE1X2dlbS5jCj4+IGluZGV4IGJlMWY5ODQuLjlmOWMwYzAgMTAwNjQ0Cj4+IC0tLSBhL2Ry
aXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtLmMKPj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5
MTUvaTkxNV9nZW0uYwo+PiBAQCAtMjc1MSw2ICsyNzUxLDIxIEBAIGVycjoKPj4gICAJcmV0dXJu
IHJldDsKPj4gICB9Cj4+Cj4+ICsvKgo+PiArICogQWxsb2NhdGUgYSByZXF1ZXN0IGFzc29jaWF0
ZWQgd2l0aCB0aGUgZGVmYXVsdCBjb250ZXh0IGZvciB0aGUgZ2l2ZW4KPj4gKyAqIHJpbmcuIFRo
aXMgY2FuIGJlIHVzZWQgd2hlcmUgdGhlIGRyaXZlciBuZWVkcyBhIHJlcXVlc3QgZm9yIGludGVy
bmFsCj4+ICsgKiBwdXJwb3NlcyBub3QgZGlyZWN0bHkgcmVsYXRlZCB0byBhIHVzZXIgYmF0Y2gg
c3VibWlzc2lvbi4KPj4gKyAqLwo+PiArc3RydWN0IGRybV9pOTE1X2dlbV9yZXF1ZXN0ICoKPj4g
K2k5MTVfZ2VtX3JlcXVlc3RfYWxsb2NfYW5vbihzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICpyaW5n
KQo+PiArewo+Cj4gQXMgZGVtb25zdHJhdGVkLCBuby4gQ29udGV4dHMgbmVlZCB0byBiZSBjb25z
aWRlcmVkIHByb3Blcmx5IGZpcnN0Lgo+Cj4+ICsJc3RydWN0IGRybV9pOTE1X2dlbV9yZXF1ZXN0
ICpyZXE7Cj4+ICsJaW50IGVycjsKPj4gKwo+PiArCWVyciA9IGk5MTVfZ2VtX3JlcXVlc3RfYWxs
b2MocmluZywgcmluZy0+ZGVmYXVsdF9jb250ZXh0LCAmcmVxKTsKPj4gKwlyZXR1cm4gZXJyID8g
RVJSX1BUUihlcnIpIDogcmVxOwo+PiArfQo+PiArCj4+ICAgdm9pZCBpOTE1X2dlbV9yZXF1ZXN0
X2NhbmNlbChzdHJ1Y3QgZHJtX2k5MTVfZ2VtX3JlcXVlc3QgKnJlcSkKPj4gICB7Cj4+ICAgCWlu
dGVsX3JpbmdfcmVzZXJ2ZWRfc3BhY2VfY2FuY2VsKHJlcS0+cmluZ2J1Zik7Cj4+IEBAIC0zMTY4
LDkgKzMxODMsMTMgQEAgX19pOTE1X2dlbV9vYmplY3Rfc3luYyhzdHJ1Y3QgZHJtX2k5MTVfZ2Vt
X29iamVjdCAqb2JqLAo+PiAgIAkJCXJldHVybiAwOwo+Pgo+PiAgIAkJaWYgKCp0b19yZXEgPT0g
TlVMTCkgewo+PiAtCQkJcmV0ID0gaTkxNV9nZW1fcmVxdWVzdF9hbGxvYyh0bywgdG8tPmRlZmF1
bHRfY29udGV4dCwgdG9fcmVxKTsKPj4gLQkJCWlmIChyZXQpCj4+IC0JCQkJcmV0dXJuIHJldDsK
Pj4gKwkJCXN0cnVjdCBkcm1faTkxNV9nZW1fcmVxdWVzdCAqcmVxOwo+PiArCj4+ICsJCQlyZXEg
PSBpOTE1X2dlbV9yZXF1ZXN0X2FsbG9jX2Fub24odG8pOwo+Cj4gV3JvbmcgY29udGV4dC4gUGxl
YXNlIHNlZSBwYXRjaGVzIHRvIGZpeCB0aGlzIG1lc3MuCj4KPj4gKwkJCWlmIChJU19FUlIocmVx
KSkKPj4gKwkJCQlyZXR1cm4gUFRSX0VSUihyZXEpOwo+PiArCj4+ICsJCQkqdG9fcmVxID0gcmVx
Owo+PiAgIAkJfQo+Pgo+PiAgIAkJdHJhY2VfaTkxNV9nZW1fcmluZ19zeW5jX3RvKCp0b19yZXEs
IGZyb20sIGZyb21fcmVxKTsKPj4gQEAgLTMzNzAsOSArMzM4OSw5IEBAIGludCBpOTE1X2dwdV9p
ZGxlKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYpCj4+ICAgCQlpZiAoIWk5MTUuZW5hYmxlX2V4ZWNs
aXN0cykgewo+PiAgIAkJCXN0cnVjdCBkcm1faTkxNV9nZW1fcmVxdWVzdCAqcmVxOwo+Pgo+PiAt
CQkJcmV0ID0gaTkxNV9nZW1fcmVxdWVzdF9hbGxvYyhyaW5nLCByaW5nLT5kZWZhdWx0X2NvbnRl
eHQsICZyZXEpOwo+PiAtCQkJaWYgKHJldCkKPj4gLQkJCQlyZXR1cm4gcmV0Owo+PiArCQkJcmVx
ID0gaTkxNV9nZW1fcmVxdWVzdF9hbGxvY19hbm9uKHJpbmcpOwo+PiArCQkJaWYgKElTX0VSUihy
ZXEpKQo+PiArCQkJCXJldHVybiBQVFJfRVJSKHJlcSk7Cj4+Cj4+ICAgCQkJcmV0ID0gaTkxNV9z
d2l0Y2hfY29udGV4dChyZXEpOwo+PiAgIAkJCWlmIChyZXQpIHsKPj4gQEAgLTQ4NjcsOCArNDg4
Niw5IEBAIGk5MTVfZ2VtX2luaXRfaHcoc3RydWN0IGRybV9kZXZpY2UgKmRldikKPj4gICAJZm9y
X2VhY2hfcmluZyhyaW5nLCBkZXZfcHJpdiwgaSkgewo+PiAgIAkJc3RydWN0IGRybV9pOTE1X2dl
bV9yZXF1ZXN0ICpyZXE7Cj4+Cj4+IC0JCXJldCA9IGk5MTVfZ2VtX3JlcXVlc3RfYWxsb2Mocmlu
ZywgcmluZy0+ZGVmYXVsdF9jb250ZXh0LCAmcmVxKTsKPj4gLQkJaWYgKHJldCkgewo+PiArCQly
ZXEgPSBpOTE1X2dlbV9yZXF1ZXN0X2FsbG9jX2Fub24ocmluZyk7Cj4+ICsJCWlmIChJU19FUlIo
cmVxKSkgewo+PiArCQkJcmV0ID0gUFRSX0VSUihyZXEpOwo+PiAgIAkJCWk5MTVfZ2VtX2NsZWFu
dXBfcmluZ2J1ZmZlcihkZXYpOwo+PiAgIAkJCWdvdG8gb3V0Owo+PiAgIAkJfQo+PiBkaWZmIC0t
Z2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jIGIvZHJpdmVycy9ncHUv
ZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4+IGluZGV4IGFiZDJkMjkuLjU3MTZmNGEgMTAwNjQ0
Cj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+PiArKysgYi9k
cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPj4gQEAgLTExNjYyLDkgKzExNjYy
LDExIEBAIHN0YXRpYyBpbnQgaW50ZWxfY3J0Y19wYWdlX2ZsaXAoc3RydWN0IGRybV9jcnRjICpj
cnRjLAo+PiAgIAkJCQkJb2JqLT5sYXN0X3dyaXRlX3JlcSk7Cj4+ICAgCX0gZWxzZSB7Cj4+ICAg
CQlpZiAoIXJlcXVlc3QpIHsKPj4gLQkJCXJldCA9IGk5MTVfZ2VtX3JlcXVlc3RfYWxsb2Mocmlu
ZywgcmluZy0+ZGVmYXVsdF9jb250ZXh0LCAmcmVxdWVzdCk7Cj4+IC0JCQlpZiAocmV0KQo+Cj4g
V3JvbmcgY29udGV4dC4KPiAtQ2hyaXMKCldoYXQgZG8geW91IG1lYW4sICJ3cm9uZyBjb250ZXh0
Ii4gVGhlIGxpbmUgYWJvdmUgaXMgdGhlIHdheSBpdCAKKmN1cnJlbnRseSogd29ya3MsIHdoaWNo
IEknbSByZXBsYWNpbmcgd2l0aCBvbmUgdGhhdCAqZG9lc24ndCogcmVmZXIgdG8gCnRoZSBkZWZh
dWx0IGNvbnRleHQuCgpUaGlzIHBhdGNoIGRvZXNuJ3QgY2hhbmdlIGFueSBmdW5jdGlvbmFsaXR5
LCBqdXN0IHNpbXBsaWZpZXMgaXQgYnkgCnJlZHVjaW5nIHRoZSBudW1iZXIgb2YgaW5zdGFuY2Vz
IG9mICJkZWZhdWx0X2NvbnRleHQiIHNvIHRoYXQgcGF0Y2ggNC82IApjYW4gYWN0dWFsbHkgZ2V0
IHJpZCBvZiByaW5nLT5kZWZhdWx0X2NvbnRleHQgZW50aXJlbHkuIEkgdGhvdWdodCB0aGF0IAp3
YXMgd2hhdCB5b3Ugd2VyZSBhaW1pbmcgZm9yPwoKLkRhdmUuCgpfX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVs
LWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9t
YWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=