From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH 2/4] x86: misc printk() adjustments
Date: Tue, 22 Dec 2015 11:48:48 +0000
Message-ID: <567938A0.7070202@citrix.com>
References: <56781AAD02000078000C1EBA@prv-mh.provo.novell.com>
	<56781BFA02000078000C1ECD@prv-mh.provo.novell.com>
	<56780FAB.4080307@citrix.com>
	<56781F5C02000078000C1F3A@prv-mh.provo.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta3.messagelabs.com ([195.245.230.39])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <prvs=791043b03=Andrew.Cooper3@citrix.com>)
	id 1aBLR0-0005fG-1V
	for xen-devel@lists.xenproject.org; Tue, 22 Dec 2015 11:48:54 +0000
In-Reply-To: <56781F5C02000078000C1F3A@prv-mh.provo.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>, Keir Fraser <keir@xen.org>
List-Id: xen-devel@lists.xenproject.org

On 21/12/15 14:48, Jan Beulich wrote:
>>>> On 21.12.15 at 15:41, <andrew.cooper3@citrix.com> wrote:
>> On 21/12/15 14:34, Jan Beulich wrote:
>>> --- a/xen/arch/x86/io_apic.c
>>> +++ b/xen/arch/x86/io_apic.c
>>> @@ -2310,13 +2310,14 @@ int ioapic_guest_read(unsigned long phys
>>>      return 0;
>>>  }
>>>  
>>> -#define WARN_BOGUS_WRITE(f, a...)                                       \
>>> -    dprintk(XENLOG_INFO, "\n%s: "                                        \
>>> -            "apic=%d, pin=%d, irq=%d\n"                 \
>>> -            "%s: new_entry=%08x\n"                      \
>>> -            "%s: " f, __FUNCTION__, apic, pin, irq,        \
>>> -            __FUNCTION__, *(u32 *)&rte,           \
>>> -            __FUNCTION__ , ##a )
>>> +#define WARN_BOGUS_WRITE(f, a...)                       \
>>> +    dprintk(XENLOG_INFO, "\n"                           \
>>> +            XENLOG_INFO "%s: apic=%d, pin=%d, irq=%d\n" \
>>> +            XENLOG_INFO "%s: new_entry=%08x\n"          \
>>> +            XENLOG_INFO "%s: " f "\n",                  \
>>> +            __func__, apic, pin, irq,                   \
>>> +            __func__, *(u32 *)&rte,                     \
>>> +            __func__, ##a )
>>>  
>>>  int ioapic_guest_write(unsigned long physbase, unsigned int reg, u32 val)
>>>  {
>>> @@ -2388,7 +2389,7 @@ int ioapic_guest_write(unsigned long phy
>>>          rte.vector = desc->arch.vector;
>>>          if ( *(u32*)&rte != ret )
>>>              WARN_BOGUS_WRITE("old_entry=%08x pirq=%d\n%s: "
>>> -                             "Attempt to modify IO-APIC pin for in-use IRQ!\n",
>>> +                             "Attempt to modify IO-APIC pin for in-use IRQ!",
>>>                               ret, pirq, __FUNCTION__);
>> Given that this is the sole user of WARN_BOGUS_WRITE(), I would
>> recommend folding it all together in a simple dprintk(), and remove some
>> of the redundant information, and fixing the resulting message to take
>> up fewer lines.
> If you feel strongly about this I could certainly do so, but I did
> consider that option and decided against it to retain the option
> of using the macro (again?) in a second place.

I don't forsee it being useful to use again.

Either way, Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>

~Andrew