From: Javier Martinez Canillas <javier@osg.samsung.com>
To: Valdis Kletnieks <Valdis.Kletnieks@vt.edu>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: next-20151222 - compile failure in drivers/media/usb/uvc/uvc_driver.c
Date: Tue, 22 Dec 2015 09:40:43 -0300 [thread overview]
Message-ID: <567944CB.4070505@osg.samsung.com> (raw)
In-Reply-To: <75073.1450779516@turing-police.cc.vt.edu>
Hello Valdis,
On 12/22/2015 07:18 AM, Valdis Kletnieks wrote:
> next-20151222 fails to build for me:
>
> CC drivers/media/usb/uvc/uvc_driver.o
> drivers/media/usb/uvc/uvc_driver.c: In function 'uvc_probe':
> drivers/media/usb/uvc/uvc_driver.c:1941:32: error: 'struct uvc_device' has no member named 'mdev'
> if (media_device_register(&dev->mdev) < 0)
> ^
> scripts/Makefile.build:258: recipe for target 'drivers/media/usb/uvc/uvc_driver.o' failed
>
> 'git blame' points at that line being added in:
>
> commit 1590ad7b52714fddc958189103c95541b49b1dae
> Author: Javier Martinez Canillas <javier@osg.samsung.com>
> Date: Fri Dec 11 20:57:08 2015 -0200
>
> [media] media-device: split media initialization and registration
>
> Not sure what went wrong here.
>
It was my forgetting to test with !CONFIG_MEDIA_CONTROLLER...
Anyways, I've already posted a fix for this:
https://lkml.org/lkml/2015/12/21/224
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
next prev parent reply other threads:[~2015-12-22 12:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-22 10:18 next-20151222 - compile failure in drivers/media/usb/uvc/uvc_driver.c Valdis Kletnieks
2015-12-22 12:40 ` Javier Martinez Canillas [this message]
2015-12-22 17:01 ` Valdis.Kletnieks
2015-12-22 18:06 ` Laurent Pinchart
2015-12-22 18:33 ` Mauro Carvalho Chehab
2015-12-22 23:07 ` Laurent Pinchart
2015-12-23 12:21 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=567944CB.4070505@osg.samsung.com \
--to=javier@osg.samsung.com \
--cc=Valdis.Kletnieks@vt.edu \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.