From mboxrd@z Thu Jan 1 00:00:00 1970 From: Doug Goldstein Subject: Re: [PATCH] build: save generated config in /boot Date: Tue, 22 Dec 2015 06:45:20 -0600 Message-ID: <567945E0.2060701@cardoe.com> References: <1450474548-26428-1-git-send-email-cardoe@cardoe.com> <5677FA9802000078000C1DA7@prv-mh.provo.novell.com> <5677F350.8020001@citrix.com> <5678046C02000078000C1DF2@prv-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2939083170451866843==" Return-path: In-Reply-To: <5678046C02000078000C1DF2@prv-mh.provo.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich , Andrew Cooper Cc: Keir Fraser , Tim Deegan , Ian Jackson , Ian Campbell , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============2939083170451866843== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="GRQdpoDWcALf7dWQotDqVqHJfnW1G7CNv" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --GRQdpoDWcALf7dWQotDqVqHJfnW1G7CNv Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 12/21/15 6:53 AM, Jan Beulich wrote: >>>> On 21.12.15 at 13:40, wrote: >> On 21/12/15 12:11, Jan Beulich wrote: >>>>>> On 18.12.15 at 22:35, wrote: >>>> Since we now support changing Xen options with Kconfig, we should sa= ve >>>> the configuration that was used to build up Xen. This will save it i= n >>>> /boot alongside the installed xen.gz and call it >>>> xen-$(FULLVERSION).config >>>> >>>> Suggested-by: Ian Campbell >>>> Signed-off-by: Doug Goldstein >>>> --- >>>> xen/Makefile | 1 + >>>> 1 file changed, 1 insertion(+) >>>> >>>> diff --git a/xen/Makefile b/xen/Makefile >>>> index 9023863..460b977 100644 >>>> --- a/xen/Makefile >>>> +++ b/xen/Makefile >>>> @@ -58,6 +58,7 @@ _install: $(TARGET)$(CONFIG_XEN_INSTALL_SUFFIX) >>>> ln -f -s $(T)-$(XEN_FULLVERSION)$(Z) $(D)$(BOOT_DIR)/$(T)$(Z) >>>> [ -d "$(D)$(DEBUG_DIR)" ] || $(INSTALL_DIR) $(D)$(DEBUG_DIR) >>>> $(INSTALL_DATA) $(TARGET)-syms $(D)$(DEBUG_DIR)/$(T)-syms-$(XEN_FU= LLVERSION) >>>> + $(INSTALL_DATA) $(KCONFIG_CONFIG)=20 >> $(D)$(BOOT_DIR)/$(T)-$(XEN_FULLVERSION).config >>> Was it really suggested to put this into /boot? It has no business >>> being there... >> >> A typical Linux has: >> >> andrewcoop@andrewcoop:/local/xen.git/xen$ ls -lA /boot/ >> total 21044 >> -rw-r--r-- 1 root root 157726 Dec 15 15:40 config-3.16.0-4-amd64 >> drwxr-xr-x 5 root root 4096 Dec 18 07:53 grub >> -rw-r--r-- 1 root root 15535038 Dec 18 07:52 initrd.img-3.16.0-4-amd6= 4 >> drwx------ 2 root root 16384 Oct 19 11:11 lost+found >> -rw-r--r-- 1 root root 2676277 Dec 15 15:40 System.map-3.16.0-4-amd6= 4 >> -rw-r--r-- 1 root root 3118928 Dec 15 15:37 vmlinuz-3.16.0-4-amd64 >> >> which at the very least is consistent between Debian and RHEL derivati= ves. >> >> IMO, doing the same for Xen is sensible. >=20 > I'm afraid I have to disagree - just because Linux does things a > certain way doesn't mean that the only (sensible) way. Imo /boot > should hold exclusively stuff needed for booting. Remember how > we moved xen-syms out of there not so long ago? You could have > objected to that change too, considering that Linux puts > System.map and sometimes also the uncompressed vmlinux there. > Yet I think it was a correct move, and the change here should > follow that model instead of Linux'es. >=20 > Jan >=20 I don't think you're correct here Jan. Looking at most distros I have at hand (I'll admit I don't have SuSE available to me). The uncompressed kernel is not in /boot. In fact all of them use /usr/lib/debug so Xen did follow Linux here. --=20 Doug Goldstein --GRQdpoDWcALf7dWQotDqVqHJfnW1G7CNv Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0 iQJ8BAEBCgBmBQJWeUXjXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRBNTM5MEQ2RTNFMTkyNzlCNzVDMzIwOTVB MkJDMDNEQzg3RUQxQkQ0AAoJEKK8A9yH7RvUxNcP/1wl/yOPE5NrHbbpj85ipTxM k0/K3Nhg8AokTHSyQ1s6s8oIg/XT8hVR5JpfKiei5o1WnHdJ3uObEObBbN4R48+J AcJNIIM2bvPoF4fV6CqP+gTU+G7GhH+L7DYm+sgIt7LVrvxLDzwEwc5/TA5It2wJ L+IgolOGOQoseOrsWeynmmV841GXNCTJagGh4YMrMk5lk2VQAwz7pzeXd5tmkTAP Crw9wuZId3LLt82dpZvoe36owotXsAZAIees9bt+jiJQI/gGsCSB61oucRpsCXGy b/z4A/eRdaFE4W8nESu4E/FmoiR+PTixddlG+ea063gUZCNmrX6Qs3WbNEFoW2pz nm79PFaZhy5uHgkmhbIvn+U3hwSo1o4dxcj+QGxejie3EGt7d3Q9T5gtxN+gIr4q LO6wAGBE7HWQONZezJjxMJ/CZ27hcrx1N3iiV2N0drLUctxhBO0Py3TijPlMsNwi xqwsoBmKALYikLg00Fl9ByMq/0r8m69TDciKIdWsigijlcYktSP7MrcHBTA0co77 JaS0GTOrvGsZUUIXyHqQ098BD8IuQAikeuVZq7KkAEmBnTU66LVwzBGWLEGW9zDL +RT3GCbLq6f0Iy/vUjbwknViwF8jXuW5ltkDztOnYHC/pN74grnqzOlLMQ6ODu0V UzUq64IV7oHfS3dFcw+V =xS9p -----END PGP SIGNATURE----- --GRQdpoDWcALf7dWQotDqVqHJfnW1G7CNv-- --===============2939083170451866843== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============2939083170451866843==--