From mboxrd@z Thu Jan 1 00:00:00 1970 From: Doug Goldstein Subject: Re: [PATCH] build: save generated config in /boot Date: Tue, 22 Dec 2015 06:45:45 -0600 Message-ID: <567945F9.7040109@cardoe.com> References: <1450474548-26428-1-git-send-email-cardoe@cardoe.com> <5677FA9802000078000C1DA7@prv-mh.provo.novell.com> <56780E25.9090806@cardoe.com> <56781FFA02000078000C1F3D@prv-mh.provo.novell.com> <567818B3.6060908@cardoe.com> <56782A4402000078000C1FD0@prv-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0269676465265675366==" Return-path: In-Reply-To: <56782A4402000078000C1FD0@prv-mh.provo.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: Keir Fraser , Tim Deegan , Ian Jackson , Ian Campbell , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============0269676465265675366== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="n1WE4w13oiI3BNONnlN8HhqWsniD3eGaf" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --n1WE4w13oiI3BNONnlN8HhqWsniD3eGaf Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 12/21/15 9:35 AM, Jan Beulich wrote: >>>> On 21.12.15 at 16:20, wrote: >> On 12/21/15 8:51 AM, Jan Beulich wrote: >>>>>> On 21.12.15 at 15:35, wrote: >>>> On 12/21/15 6:11 AM, Jan Beulich wrote: >>>>>>>> On 18.12.15 at 22:35, wrote: >>>>>> Since we now support changing Xen options with Kconfig, we should = save >>>>>> the configuration that was used to build up Xen. This will save it= in >>>>>> /boot alongside the installed xen.gz and call it >>>>>> xen-$(FULLVERSION).config >>>>>> >>>>>> Suggested-by: Ian Campbell >>>>>> Signed-off-by: Doug Goldstein >>>>>> --- >>>>>> xen/Makefile | 1 + >>>>>> 1 file changed, 1 insertion(+) >>>>>> >>>>>> diff --git a/xen/Makefile b/xen/Makefile >>>>>> index 9023863..460b977 100644 >>>>>> --- a/xen/Makefile >>>>>> +++ b/xen/Makefile >>>>>> @@ -58,6 +58,7 @@ _install: $(TARGET)$(CONFIG_XEN_INSTALL_SUFFIX) >>>>>> ln -f -s $(T)-$(XEN_FULLVERSION)$(Z) $(D)$(BOOT_DIR)/$(T)$(Z) >>>>>> [ -d "$(D)$(DEBUG_DIR)" ] || $(INSTALL_DIR) $(D)$(DEBUG_DIR) >>>>>> $(INSTALL_DATA) $(TARGET)-syms $(D)$(DEBUG_DIR)/$(T)-syms-$(XEN_= FULLVERSION) >>>>>> + $(INSTALL_DATA) $(KCONFIG_CONFIG)=20 >>>> $(D)$(BOOT_DIR)/$(T)-$(XEN_FULLVERSION).config >>>>> >>>>> Was it really suggested to put this into /boot? It has no business >>>>> being there... >>>> >>>> Yes. By multiple people. Ian Campbell was the first person to sugges= t it >>>> in that location. >>> >>> Okay, so I've looked it up, and no, he didn't. He just gave this as o= ne >>> possibility: >>> >>> "It occurred to me this morning that we probably ought to stash the .= config >>> somewhere on install in such a way that it can be associated with th= e Xen >>> binary (i.e. with the same full suffix as the binary itself, not the= >>> abridged symlink names), maybe as $(BOOT_DIR)/$(T)- >>> $(XEN_FULLVERSION).config?" >>> >>> But yes, I'm sorry for not noticing this as an undesirable place righ= t >>> away. >> >> Ok well I'm at a loss here because the quote clearly shows him >> suggesting that location. Do you have a suggested location because so >> far I've just got a no from you on the only suggested location. >=20 > Match the xen-syms location? >=20 > Jan >=20 I guess I fail to grasp the rationale behind not putting it in /boot. --=20 Doug Goldstein --n1WE4w13oiI3BNONnlN8HhqWsniD3eGaf Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0 iQJ8BAEBCgBmBQJWeUX6XxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRBNTM5MEQ2RTNFMTkyNzlCNzVDMzIwOTVB MkJDMDNEQzg3RUQxQkQ0AAoJEKK8A9yH7RvUXjsP/1XGOVGovnB79W+uq7U4Gdp7 NeEq80XpHz9PXowk3dj1lfvWulG4wyFUQkBbXlYv/wi3pm82fx4xi0zR283OcpIQ QqMsJsWeh8OJfdegJ+jUBLRk/P245SACOYDwiy92e1Od2P03FtfGG/d3bxDelvZW 6FotaID2/p36v7D7OF3/Ja2HiP41DdAVznAN/l/3RHyn7BnFg5lmG25Q0tyQ8UwI Zpwlu+8d2cTACbLRfnq6ZkH9A1PfJf/uv0W8UJs7ZKr2uyCmnE3A806SyRBEd+Ws EDoN78T/0FpJUAJyZxig49wic31yqlo/UykFYa66xnDHHfw/T6j6tjWZW1vKDPX0 lKwBQgvyMbHgl51d6Z4735VdlmeY13/5Iomixqx72o+16I1A/ErvRzKOw/L7eAVu lR3M3yTam7t0wA3cZWpYsGtgbr0CooOQlcYNs4NfWE/chW7cd4Y862no9NjtmsvA JBze7PSWStHEyKZ/orA9SbYm0Me/iFWG1+uwwIIRp9dZNUt0MygaUxTv7HoNpNKZ zrLWi+kgY3SU7rzl4quFisO5hTKxUlintAudSWHPwMVMEf7+Oqfi8X8YVUI9D1Z1 0AoTFrfHqOcfP7eFN0Jpdy3jIPAKcQ+yGcCCyDATTGE6TRycxu8pnSUJopB0z8OW Nyz1SVd1lk4Gr4Bnot6u =hSQG -----END PGP SIGNATURE----- --n1WE4w13oiI3BNONnlN8HhqWsniD3eGaf-- --===============0269676465265675366== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============0269676465265675366==--