Re: [PATCH 3/4] xen: uprev to 4.6.0

[Doug Goldstein <cardoe@cardoe.com>]

[-- Attachment #1: Type: text/plain, Size: 2139 bytes --]

On 12/22/15 8:26 AM, Doug Goldstein wrote:
> On 12/22/15 7:00 AM, Chris Patterson wrote:
>> On Tue, Dec 22, 2015 at 12:45 AM, Doug Goldstein <cardoe@cardoe.com> wrote:
>>
>>> Any reason why you can't work with upstream on a solution to the headers
>>> cross compile issue?
>>>
>>
>> I wouldn't declare that it is a bug, but it sounded like upstream just
>> wasn't "finished" yet.  If you look at the commit that introduced it,
>> it was deemed to be "simplistic" and was meant only for native builds.
>>
>> commit 6f1d3ce238905fc7b4c563a3611576ca25a09a49
>> Author: Keir Fraser <keir.fraser@citrix.com>
>> Date:   Wed Jun 17 07:21:03 2009 +0100
>>
>>     Introduce mechanism to check standard conformance of headers
>>
>>     While pretty simplistic, it appears to serve the purpose at the moment
>>     (i.e. it spotted two places where a GNU extension was used withou
>>     proper preprocessor conditionals). The "simplistic" here includes that
>>     the checking gets only done for native builds, and ia64 gets excluded
>>     due to its arch-specific header intentionally (for whatever reason)
>>     checking that anonymous struct/unions can be used.
>>
>>     Signed-off-by: Jan Beulich <jbeulich@novell.com>
>>
>>
>> Since it appeared to be a sanity check (for developers?), I didn't
>> think it was worth digging in too far.
>>
>> But since you asked!! I did revisit and it actually looks like the
>> root problem was that CXX is being dropping its OE cross flags (most
>> importantly, --sysroot).
>>
>> It appears that CXX needs to be added to the list of variables updated
>> in ${S}/config/StdGNU.mk.  I'll fix that and post a v2 shortly :)
>>
>> Thanks!
>> -Chris
>>
> 
> So actually the only variables that should be sed'd are LD, CC, CPP, and
> CXX. I actually tracked this down a while back and I've got a patchset
> that needs to be submitted that contains a number of fixes for 4.6 as well.
> 

I just pushed my most recent branch. Feel free to grab any bits from
here for a v2.

https://github.com/cardoe/meta-virtualization/commits/xen-fixes

-- 
Doug Goldstein


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 978 bytes --]