From: Vlastimil Babka <vbabka@suse.cz>
To: Michal Hocko <mhocko@kernel.org>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
Cc: Andrew Morton <akpm@linux-foundation.org>, linux-mm@kvack.org
Subject: Re: [PATCH] mm: make sure isolate_lru_page() is never called for tail page
Date: Tue, 22 Dec 2015 16:57:51 +0100 [thread overview]
Message-ID: <567972FF.4090408@suse.cz> (raw)
In-Reply-To: <20151216144749.GB23092@dhcp22.suse.cz>
On 12/16/2015 03:47 PM, Michal Hocko wrote:
> On Wed 16-12-15 16:29:30, Kirill A. Shutemov wrote:
>> The VM_BUG_ON_PAGE() would catch such cases if any still exists.
>
> Thanks, this better than a silent breakage.
>
>> Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
>
> Acked-by: Michal Hocko <mhocko@suse.com>
Acked-by: Vlastimil Babka <vbabka@suse.cz>
>
>> ---
>> mm/vmscan.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/mm/vmscan.c b/mm/vmscan.c
>> index 964390906167..05dd182f04fd 100644
>> --- a/mm/vmscan.c
>> +++ b/mm/vmscan.c
>> @@ -1436,6 +1436,7 @@ int isolate_lru_page(struct page *page)
>> int ret = -EBUSY;
>>
>> VM_BUG_ON_PAGE(!page_count(page), page);
>> + VM_BUG_ON_PAGE(PageTail(page), page);
>>
>> if (PageLRU(page)) {
>> struct zone *zone = page_zone(page);
>> --
>> 2.6.2
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2015-12-22 15:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-16 14:29 [PATCH] mm: make sure isolate_lru_page() is never called for tail page Kirill A. Shutemov
2015-12-16 14:47 ` Michal Hocko
2015-12-22 15:57 ` Vlastimil Babka [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=567972FF.4090408@suse.cz \
--to=vbabka@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.