Re: [Qemu-devel] [PATCH 1/7] qom: add user_creatable_add & user_creatable_del methods

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1242 bytes --]

On 12/22/2015 04:06 AM, Daniel P. Berrange wrote:
> The QMP monitor code has two helper methods object_add
> and qmp_object_del that are called from several places
> in the code (QMP, HMP and main emulator startup).
> 
> We soon need to use this code from qemu-img, qemu-io
> and qemu-nbd too, but don't want those to depend on
> the monitor.
> 
> To avoid this, move object_add to user_creatable_add
> an qmp_object_del to user_creatable_del, to the
> object_interfaces.c file where they can be easily
> shared with all users of QOM
> 
> Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
> ---
>  hmp.c                           | 11 ++++--
>  include/monitor/monitor.h       |  3 --
>  include/qom/object_interfaces.h | 31 +++++++++++++++++
>  qmp.c                           | 75 ++++------------------------------------
>  qom/object_interfaces.c         | 76 +++++++++++++++++++++++++++++++++++++++++
>  vl.c                            |  8 +++--
>  6 files changed, 127 insertions(+), 77 deletions(-)

Looks like fairly straightforward code motion.
Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]