From mboxrd@z Thu Jan 1 00:00:00 1970 From: Doug Goldstein Subject: Re: [PATCH] build: save generated config in /boot Date: Tue, 22 Dec 2015 10:02:22 -0600 Message-ID: <5679740E.9090309@cardoe.com> References: <1450474548-26428-1-git-send-email-cardoe@cardoe.com> <5677FA9802000078000C1DA7@prv-mh.provo.novell.com> <56780E25.9090806@cardoe.com> <56781FFA02000078000C1F3D@prv-mh.provo.novell.com> <567818B3.6060908@cardoe.com> <56782A4402000078000C1FD0@prv-mh.provo.novell.com> <567945F9.7040109@cardoe.com> <5679558002000078000C23CE@prv-mh.provo.novell.com> <56796237.4090102@citrix.com> <5679818402000078000C253F@prv-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5026422345162198918==" Return-path: In-Reply-To: <5679818402000078000C253F@prv-mh.provo.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich , Andrew Cooper Cc: Keir Fraser , Tim Deegan , Ian Jackson , Ian Campbell , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============5026422345162198918== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="P6nSseSfdlvWQ1daHKf4gqk60NXsAqmPu" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --P6nSseSfdlvWQ1daHKf4gqk60NXsAqmPu Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 12/22/15 9:59 AM, Jan Beulich wrote: >>>> On 22.12.15 at 15:46, wrote: >> On 22/12/15 12:52, Jan Beulich wrote: >>>>>> On 22.12.15 at 13:45, wrote: >>>> On 12/21/15 9:35 AM, Jan Beulich wrote: >>>>>>>> On 21.12.15 at 16:20, wrote: >>>>>> On 12/21/15 8:51 AM, Jan Beulich wrote: >>>>>>>>>> On 21.12.15 at 15:35, wrote: >>>>>>>> On 12/21/15 6:11 AM, Jan Beulich wrote: >>>>>>>>>>>> On 18.12.15 at 22:35, wrote: >>>>>>>>>> Since we now support changing Xen options with Kconfig, we sho= uld save >>>>>>>>>> the configuration that was used to build up Xen. This will sav= e it in >>>>>>>>>> /boot alongside the installed xen.gz and call it >>>>>>>>>> xen-$(FULLVERSION).config >>>>>>>>>> >>>>>>>>>> Suggested-by: Ian Campbell >>>>>>>>>> Signed-off-by: Doug Goldstein >>>>>>>>>> --- >>>>>>>>>> xen/Makefile | 1 + >>>>>>>>>> 1 file changed, 1 insertion(+) >>>>>>>>>> >>>>>>>>>> diff --git a/xen/Makefile b/xen/Makefile >>>>>>>>>> index 9023863..460b977 100644 >>>>>>>>>> --- a/xen/Makefile >>>>>>>>>> +++ b/xen/Makefile >>>>>>>>>> @@ -58,6 +58,7 @@ _install: $(TARGET)$(CONFIG_XEN_INSTALL_SUFF= IX) >>>>>>>>>> ln -f -s $(T)-$(XEN_FULLVERSION)$(Z) $(D)$(BOOT_DIR)/$(T)$(Z= ) >>>>>>>>>> [ -d "$(D)$(DEBUG_DIR)" ] || $(INSTALL_DIR) $(D)$(DEBUG_DIR)= >>>>>>>>>> $(INSTALL_DATA) $(TARGET)-syms $(D)$(DEBUG_DIR)/$(T)-syms-$(= XEN_FULLVERSION) >>>>>>>>>> + $(INSTALL_DATA) $(KCONFIG_CONFIG)=20 >>>>>>>> $(D)$(BOOT_DIR)/$(T)-$(XEN_FULLVERSION).config >>>>>>>>> Was it really suggested to put this into /boot? It has no busin= ess >>>>>>>>> being there... >>>>>>>> Yes. By multiple people. Ian Campbell was the first person to su= ggest it >>>>>>>> in that location. >>>>>>> Okay, so I've looked it up, and no, he didn't. He just gave this = as one >>>>>>> possibility: >>>>>>> >>>>>>> "It occurred to me this morning that we probably ought to stash t= he .config >>>>>>> somewhere on install in such a way that it can be associated wit= h the Xen >>>>>>> binary (i.e. with the same full suffix as the binary itself, not= the >>>>>>> abridged symlink names), maybe as $(BOOT_DIR)/$(T)- >>>>>>> $(XEN_FULLVERSION).config?" >>>>>>> >>>>>>> But yes, I'm sorry for not noticing this as an undesirable place = right >>>>>>> away. >>>>>> Ok well I'm at a loss here because the quote clearly shows him >>>>>> suggesting that location. Do you have a suggested location because= so >>>>>> far I've just got a no from you on the only suggested location. >>>>> Match the xen-syms location? >>>> I guess I fail to grasp the rationale behind not putting it in /boot= =2E >>> It's the other way around really - you'd have to provide a reason >>> (other than "Linux does so too") for putting it in /boot. >> >> I disagree. >> >> Xen being consistent with Linux in this regard is in the best interest= >> of the users of Xen, as they end up finding similar information in >> similar places. >> >> The onus is on you to provide a reason why we should deliberately do >> something different. >=20 > I'm sorry, but no - why would we slavishly follow what Linux does, no > matter whether it makes sense? >=20 > Jan >=20 How does it not make sense in this case? That's what Andrew and I are asking you to explain. --=20 Doug Goldstein --P6nSseSfdlvWQ1daHKf4gqk60NXsAqmPu Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0 iQJ8BAEBCgBmBQJWeXQQXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRBNTM5MEQ2RTNFMTkyNzlCNzVDMzIwOTVB MkJDMDNEQzg3RUQxQkQ0AAoJEKK8A9yH7RvUDSIP/3l7Ym8BNUEb4l22m4y0rexA hT1DDfSWLIQEPDYrLkFpy064I1vLJrZo07usZWql4lf3bqoNCoA1Hq0HMwwDS7eW 7p/iaO8IrvBNBQq8pQnXD7utx+TUo1Nrlo7XeRPxCYoVE1OmbYNSdQA+aij35Fy9 8aG+Zfr1ka97MZtAKPQDsoNjESXSszUVwIyf5TGwdDFXqHvekmaVAcWdmyhl5H3l oPQOVlEMMbpFadj6PED7xfE3it7vX+wV0NzamwTNx8GWkbdp8z7+N+WqhblfmBn8 2nv/M3T0q10orRRD7/dAtlSSMIAiIndrzgUhed89TF8wHhCLx8eS1TkrPsk/TVuq 3om//GzQPDj33z4rHpryayQdGMEsHu+YKLhvsfHnumlytZVXqAO9SNivQVa7gEdJ WQezRimkhDL1y/6Ilkie2rxduB/9NdQuSF00UJXMIN6L8Q9AYVpbpm8ijjJz5Sf9 h6H9eZLOqQ0ma9DjueIFvVR994Ctto8uwQA85lH3wdaM1fyfVlXDHcBI/d0xy9rl F8zPMqdhafv6/1aHlK4aQhI3rB0DUVYgvQBFMlS8SVxoNj2Ml1AG9cTdwbn8fLYx o9+fWIJ3da+qzyElToR/j2n/9fdqnCr9txHn1Tdd5sLBD/JjQO4lFwA4MZdL3jtn KrHAn6uSUto4J3vyqN4s =DLqM -----END PGP SIGNATURE----- --P6nSseSfdlvWQ1daHKf4gqk60NXsAqmPu-- --===============5026422345162198918== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============5026422345162198918==--